* [PATCH net] net: phy: Fix MDIO_THUNDER dependencies
@ 2017-06-13 0:18 Florian Fainelli
2017-06-13 15:45 ` Randy Dunlap
2017-06-13 17:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2017-06-13 0:18 UTC (permalink / raw)
To: netdev; +Cc: rdunlap, arnd, Florian Fainelli, Andrew Lunn, open list
After commit 90eff9096c01 ("net: phy: Allow splitting MDIO
bus/device support from PHYs") we could create a configuration where
MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined
references:
drivers/built-in.o: In function `thunder_mdiobus_pci_remove':
>> mdio-thunder.c:(.text+0x2a212f): undefined reference to
>> `mdiobus_unregister'
>> mdio-thunder.c:(.text+0x2a2138): undefined reference to
>> `mdiobus_free'
drivers/built-in.o: In function `thunder_mdiobus_pci_probe':
mdio-thunder.c:(.text+0x2a22e7): undefined reference to
`devm_mdiobus_alloc_size'
mdio-thunder.c:(.text+0x2a236f): undefined reference to
`of_mdiobus_register'
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index c360dd6ead22..3ab6c58d4be6 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -127,6 +127,7 @@ config MDIO_THUNDER
tristate "ThunderX SOCs MDIO buses"
depends on 64BIT
depends on PCI
+ depends on !(MDIO_DEVICE=y && PHYLIB=m)
select MDIO_CAVIUM
help
This driver supports the MDIO interfaces found on Cavium
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies
2017-06-13 0:18 [PATCH net] net: phy: Fix MDIO_THUNDER dependencies Florian Fainelli
@ 2017-06-13 15:45 ` Randy Dunlap
2017-06-13 17:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2017-06-13 15:45 UTC (permalink / raw)
To: Florian Fainelli, netdev; +Cc: arnd, Andrew Lunn, open list
On 06/12/17 17:18, Florian Fainelli wrote:
> After commit 90eff9096c01 ("net: phy: Allow splitting MDIO
> bus/device support from PHYs") we could create a configuration where
> MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined
> references:
>
> drivers/built-in.o: In function `thunder_mdiobus_pci_remove':
>>> mdio-thunder.c:(.text+0x2a212f): undefined reference to
>>> `mdiobus_unregister'
>>> mdio-thunder.c:(.text+0x2a2138): undefined reference to
>>> `mdiobus_free'
> drivers/built-in.o: In function `thunder_mdiobus_pci_probe':
> mdio-thunder.c:(.text+0x2a22e7): undefined reference to
> `devm_mdiobus_alloc_size'
> mdio-thunder.c:(.text+0x2a236f): undefined reference to
> `of_mdiobus_register'
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/net/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index c360dd6ead22..3ab6c58d4be6 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -127,6 +127,7 @@ config MDIO_THUNDER
> tristate "ThunderX SOCs MDIO buses"
> depends on 64BIT
> depends on PCI
> + depends on !(MDIO_DEVICE=y && PHYLIB=m)
> select MDIO_CAVIUM
> help
> This driver supports the MDIO interfaces found on Cavium
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies
2017-06-13 0:18 [PATCH net] net: phy: Fix MDIO_THUNDER dependencies Florian Fainelli
2017-06-13 15:45 ` Randy Dunlap
@ 2017-06-13 17:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-13 17:01 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, rdunlap, arnd, andrew, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 12 Jun 2017 17:18:51 -0700
> After commit 90eff9096c01 ("net: phy: Allow splitting MDIO
> bus/device support from PHYs") we could create a configuration where
> MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined
> references:
>
> drivers/built-in.o: In function `thunder_mdiobus_pci_remove':
>>> mdio-thunder.c:(.text+0x2a212f): undefined reference to
>>> `mdiobus_unregister'
>>> mdio-thunder.c:(.text+0x2a2138): undefined reference to
>>> `mdiobus_free'
> drivers/built-in.o: In function `thunder_mdiobus_pci_probe':
> mdio-thunder.c:(.text+0x2a22e7): undefined reference to
> `devm_mdiobus_alloc_size'
> mdio-thunder.c:(.text+0x2a236f): undefined reference to
> `of_mdiobus_register'
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-13 17:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 0:18 [PATCH net] net: phy: Fix MDIO_THUNDER dependencies Florian Fainelli
2017-06-13 15:45 ` Randy Dunlap
2017-06-13 17:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.