All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] workqueue: Ensure that cpumask set for pools created after boot
@ 2017-05-10 16:48 Michael Bringmann
  2017-05-10 17:33 ` Tejun Heo
  2017-05-19  6:06 ` [lkp-robot] [workqueue] d7c99c89c5: [No primary change] perf-stat.cpu-migrations -91% kernel test robot
  0 siblings, 2 replies; 27+ messages in thread
From: Michael Bringmann @ 2017-05-10 16:48 UTC (permalink / raw)
  To: Tejun Heo, Lai Jiangshan, linux-kernel; +Cc: Nathan Fontenot, Michael Bringmann


On NUMA systems with dynamic processors, the content of the cpumask
may change over time.  As new processors are added via DLPAR operations,
workqueues are created for them.  This patch ensures that the pools
created for new workqueues will be initialized with a cpumask before
the first worker is created, attached, and woken up.  If the mask is
not set up, then the kernel will crash when 'wakeup_process' is unable
to find a valid CPU to which to assign the new worker.

Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
---
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c74bf39..6091069 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3366,6 +3366,8 @@ static struct worker_pool *get_unbound_pool(const struct workqueue_attrs *attrs)
 	copy_workqueue_attrs(pool->attrs, attrs);
 	pool->node = target_node;
 
+	cpumask_copy(pool->attrs->cpumask, cpumask_of(smp_processor_id()));
+
 	/*
 	 * no_numa isn't a worker_pool attribute, always clear it.  See
 	 * 'struct workqueue_attrs' comments for detail.

^ permalink raw reply related	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2017-07-27 17:04 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-10 16:48 [PATCH] workqueue: Ensure that cpumask set for pools created after boot Michael Bringmann
2017-05-10 17:33 ` Tejun Heo
2017-05-15 15:48   ` Michael Bringmann
2017-05-16 15:55     ` Tejun Heo
2017-05-23 19:44       ` Michael Bringmann
2017-05-23 19:49         ` Tejun Heo
2017-05-23 20:09           ` Michael Bringmann
2017-05-23 20:10             ` Tejun Heo
2017-05-24 16:30               ` Michael Bringmann
2017-05-24 23:39               ` Michael Bringmann
2017-05-25 15:03                 ` Tejun Heo
2017-05-25 15:07                   ` Tejun Heo
2017-05-25 15:30                     ` Michael Bringmann
2017-06-06 16:18                       ` Michael Bringmann
2017-06-06 18:09                         ` Tejun Heo
2017-06-12 14:47                           ` Michael Bringmann
2017-06-12 16:14                             ` Tejun Heo
2017-06-12 17:10                               ` Michael Bringmann
2017-06-12 17:32                                 ` Tejun Heo
2017-06-13 20:04                                   ` Michael Bringmann
2017-06-13 20:10                                     ` Tejun Heo
2017-06-28 21:15                                       ` Michael Bringmann
2017-06-28 21:24                                         ` Tejun Heo
2017-07-26 15:25                                           ` Michael Bringmann
2017-07-26 19:16                                             ` Tejun Heo
2017-07-27 17:04                                               ` Michael Bringmann
2017-05-19  6:06 ` [lkp-robot] [workqueue] d7c99c89c5: [No primary change] perf-stat.cpu-migrations -91% kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.