All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] documentation: updates to static library support in SDK
@ 2017-06-14 12:12 Maxin B. John
  2017-06-14 17:57 ` Andre McCurdy
  0 siblings, 1 reply; 4+ messages in thread
From: Maxin B. John @ 2017-06-14 12:12 UTC (permalink / raw)
  To: yocto; +Cc: srifenbark

For development purposes, static libraries need to be
present only in the SDK. We do not need those static
libraries in the image for most scenarios. So, replace
IMAGE_INSTALL with TOOLCHAIN_TARGET_TASK in the documentation.

Suggested-by: Anders Darander <anders@chargestorm.se>
Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 documentation/adt-manual/adt-prepare.xml         | 8 ++++----
 documentation/sdk-manual/sdk-appendix-obtain.xml | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/documentation/adt-manual/adt-prepare.xml b/documentation/adt-manual/adt-prepare.xml
index 65df1d0..7587305 100644
--- a/documentation/adt-manual/adt-prepare.xml
+++ b/documentation/adt-manual/adt-prepare.xml
@@ -684,16 +684,16 @@
         <note>
             By default, this toolchain does not build static binaries.
             If you want to use the toolchain to build these types of libraries,
-            you need to be sure your image has the appropriate static
+            you need to be sure your SDK has the appropriate static
             development libraries.
             Use the
-            <ulink url='&YOCTO_DOCS_REF_URL;#var-IMAGE_INSTALL'><filename>IMAGE_INSTALL</filename></ulink>
+            <ulink url='&YOCTO_DOCS_REF_URL;#var-TOOLCHAIN_TARGET_TASK'><filename>TOOLCHAIN_TARGET_TASK</filename></ulink>
             variable inside your <filename>local.conf</filename> file to
-            install the appropriate library packages.
+            include the appropriate library packages in SDK.
             Following is an example using <filename>glibc</filename> static
             development libraries:
             <literallayout class='monospaced'>
-     IMAGE_INSTALL_append = " glibc-staticdev"
+     TOOLCHAIN_TARGET_TASK_append = " glibc-staticdev"
             </literallayout>
         </note>
     </para>
diff --git a/documentation/sdk-manual/sdk-appendix-obtain.xml b/documentation/sdk-manual/sdk-appendix-obtain.xml
index 3156f77..86e0eff 100644
--- a/documentation/sdk-manual/sdk-appendix-obtain.xml
+++ b/documentation/sdk-manual/sdk-appendix-obtain.xml
@@ -96,16 +96,16 @@
                 <listitem><para>
                     By default, this toolchain does not build static binaries.
                     If you want to use the toolchain to build these types of
-                    libraries, you need to be sure your image has the
+                    libraries, you need to be sure your SDK has the
                     appropriate static development libraries.
                     Use the
-                    <ulink url='&YOCTO_DOCS_REF_URL;#var-IMAGE_INSTALL'><filename>IMAGE_INSTALL</filename></ulink>
+                    <ulink url='&YOCTO_DOCS_REF_URL;#var-TOOLCHAIN_TARGET_TASK'><filename>TOOLCHAIN_TARGET_TASK</filename></ulink>
                     variable inside your <filename>local.conf</filename> file
-                    to install the appropriate library packages.
+                    to install the appropriate library packages in SDK.
                     Following is an example using <filename>glibc</filename>
                     static development libraries:
                     <literallayout class='monospaced'>
-     IMAGE_INSTALL_append = " glibc-staticdev"
+     TOOLCHAIN_TARGET_TASK_append = " glibc-staticdev"
                     </literallayout>
                     </para></listitem>
                 <listitem><para>
-- 
2.4.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] documentation: updates to static library support in SDK
  2017-06-14 12:12 [PATCH] documentation: updates to static library support in SDK Maxin B. John
@ 2017-06-14 17:57 ` Andre McCurdy
  2017-06-15  8:12   ` Maxin B. John
       [not found]   ` <CAFNP8OtKLxr+sn2y1-scG9rf_qpJ_3=V8pirFVX7FO8xWNPSdQ@mail.gmail.com>
  0 siblings, 2 replies; 4+ messages in thread
From: Andre McCurdy @ 2017-06-14 17:57 UTC (permalink / raw)
  To: Maxin B. John; +Cc: Yocto discussion list, srifenbark

On Wed, Jun 14, 2017 at 5:12 AM, Maxin B. John <maxin.john@intel.com> wrote:
> For development purposes, static libraries need to be
> present only in the SDK. We do not need those static
> libraries in the image for most scenarios. So, replace
> IMAGE_INSTALL with TOOLCHAIN_TARGET_TASK in the documentation.
>
> Suggested-by: Anders Darander <anders@chargestorm.se>
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
>  documentation/adt-manual/adt-prepare.xml         | 8 ++++----
>  documentation/sdk-manual/sdk-appendix-obtain.xml | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/documentation/adt-manual/adt-prepare.xml b/documentation/adt-manual/adt-prepare.xml
> index 65df1d0..7587305 100644
> --- a/documentation/adt-manual/adt-prepare.xml
> +++ b/documentation/adt-manual/adt-prepare.xml
> @@ -684,16 +684,16 @@
>          <note>
>              By default, this toolchain does not build static binaries.
>              If you want to use the toolchain to build these types of libraries,
> -            you need to be sure your image has the appropriate static
> +            you need to be sure your SDK has the appropriate static
>              development libraries.
>              Use the
> -            <ulink url='&YOCTO_DOCS_REF_URL;#var-IMAGE_INSTALL'><filename>IMAGE_INSTALL</filename></ulink>
> +            <ulink url='&YOCTO_DOCS_REF_URL;#var-TOOLCHAIN_TARGET_TASK'><filename>TOOLCHAIN_TARGET_TASK</filename></ulink>
>              variable inside your <filename>local.conf</filename> file to
> -            install the appropriate library packages.
> +            include the appropriate library packages in SDK.
>              Following is an example using <filename>glibc</filename> static
>              development libraries:
>              <literallayout class='monospaced'>
> -     IMAGE_INSTALL_append = " glibc-staticdev"
> +     TOOLCHAIN_TARGET_TASK_append = " glibc-staticdev"

That should perhaps be "libc-staticdev" so the same instructions work
for musl (although it looks like currently musl doesn't rprovide
libc-staticdev so that would need to be fixed too).

>              </literallayout>
>          </note>
>      </para>
> diff --git a/documentation/sdk-manual/sdk-appendix-obtain.xml b/documentation/sdk-manual/sdk-appendix-obtain.xml
> index 3156f77..86e0eff 100644
> --- a/documentation/sdk-manual/sdk-appendix-obtain.xml
> +++ b/documentation/sdk-manual/sdk-appendix-obtain.xml
> @@ -96,16 +96,16 @@
>                  <listitem><para>
>                      By default, this toolchain does not build static binaries.
>                      If you want to use the toolchain to build these types of
> -                    libraries, you need to be sure your image has the
> +                    libraries, you need to be sure your SDK has the
>                      appropriate static development libraries.
>                      Use the
> -                    <ulink url='&YOCTO_DOCS_REF_URL;#var-IMAGE_INSTALL'><filename>IMAGE_INSTALL</filename></ulink>
> +                    <ulink url='&YOCTO_DOCS_REF_URL;#var-TOOLCHAIN_TARGET_TASK'><filename>TOOLCHAIN_TARGET_TASK</filename></ulink>
>                      variable inside your <filename>local.conf</filename> file
> -                    to install the appropriate library packages.
> +                    to install the appropriate library packages in SDK.
>                      Following is an example using <filename>glibc</filename>
>                      static development libraries:
>                      <literallayout class='monospaced'>
> -     IMAGE_INSTALL_append = " glibc-staticdev"
> +     TOOLCHAIN_TARGET_TASK_append = " glibc-staticdev"
>                      </literallayout>
>                      </para></listitem>
>                  <listitem><para>
> --
> 2.4.0
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] documentation: updates to static library support in SDK
  2017-06-14 17:57 ` Andre McCurdy
@ 2017-06-15  8:12   ` Maxin B. John
       [not found]   ` <CAFNP8OtKLxr+sn2y1-scG9rf_qpJ_3=V8pirFVX7FO8xWNPSdQ@mail.gmail.com>
  1 sibling, 0 replies; 4+ messages in thread
From: Maxin B. John @ 2017-06-15  8:12 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: Yocto discussion list, srifenbark

Hi Andre,

On Wed, Jun 14, 2017 at 10:57:41AM -0700, Andre McCurdy wrote:
> On Wed, Jun 14, 2017 at 5:12 AM, Maxin B. John <maxin.john@intel.com> wrote:
> > For development purposes, static libraries need to be
> > present only in the SDK. We do not need those static
> > libraries in the image for most scenarios. So, replace
> > IMAGE_INSTALL with TOOLCHAIN_TARGET_TASK in the documentation.
> >
> > Suggested-by: Anders Darander <anders@chargestorm.se>
> > Signed-off-by: Maxin B. John <maxin.john@intel.com>
> > ---
> >  documentation/adt-manual/adt-prepare.xml         | 8 ++++----
> >  documentation/sdk-manual/sdk-appendix-obtain.xml | 8 ++++----
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/documentation/adt-manual/adt-prepare.xml b/documentation/adt-manual/adt-prepare.xml
> > index 65df1d0..7587305 100644
> > --- a/documentation/adt-manual/adt-prepare.xml
> > +++ b/documentation/adt-manual/adt-prepare.xml
> > @@ -684,16 +684,16 @@
> >          <note>
> >              By default, this toolchain does not build static binaries.
> >              If you want to use the toolchain to build these types of libraries,
> > -            you need to be sure your image has the appropriate static
> > +            you need to be sure your SDK has the appropriate static
> >              development libraries.
> >              Use the
> > -            <ulink url='&YOCTO_DOCS_REF_URL;#var-IMAGE_INSTALL'><filename>IMAGE_INSTALL</filename></ulink>
> > +            <ulink url='&YOCTO_DOCS_REF_URL;#var-TOOLCHAIN_TARGET_TASK'><filename>TOOLCHAIN_TARGET_TASK</filename></ulink>
> >              variable inside your <filename>local.conf</filename> file to
> > -            install the appropriate library packages.
> > +            include the appropriate library packages in SDK.
> >              Following is an example using <filename>glibc</filename> static
> >              development libraries:
> >              <literallayout class='monospaced'>
> > -     IMAGE_INSTALL_append = " glibc-staticdev"
> > +     TOOLCHAIN_TARGET_TASK_append = " glibc-staticdev"
> 
> That should perhaps be "libc-staticdev" so the same instructions work
> for musl (although it looks like currently musl doesn't rprovide
> libc-staticdev so that would need to be fixed too).

I agree with your suggestion that examples in documentation shouldn't be
specific for a particular libc implementation.

Filed a bug for musl libc-staticdev support:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=11669

> >              </literallayout>
> >          </note>
> >      </para>
> > diff --git a/documentation/sdk-manual/sdk-appendix-obtain.xml b/documentation/sdk-manual/sdk-appendix-obtain.xml
> > index 3156f77..86e0eff 100644
> > --- a/documentation/sdk-manual/sdk-appendix-obtain.xml
> > +++ b/documentation/sdk-manual/sdk-appendix-obtain.xml
> > @@ -96,16 +96,16 @@
> >                  <listitem><para>
> >                      By default, this toolchain does not build static binaries.
> >                      If you want to use the toolchain to build these types of
> > -                    libraries, you need to be sure your image has the
> > +                    libraries, you need to be sure your SDK has the
> >                      appropriate static development libraries.
> >                      Use the
> > -                    <ulink url='&YOCTO_DOCS_REF_URL;#var-IMAGE_INSTALL'><filename>IMAGE_INSTALL</filename></ulink>
> > +                    <ulink url='&YOCTO_DOCS_REF_URL;#var-TOOLCHAIN_TARGET_TASK'><filename>TOOLCHAIN_TARGET_TASK</filename></ulink>
> >                      variable inside your <filename>local.conf</filename> file
> > -                    to install the appropriate library packages.
> > +                    to install the appropriate library packages in SDK.
> >                      Following is an example using <filename>glibc</filename>
> >                      static development libraries:
> >                      <literallayout class='monospaced'>
> > -     IMAGE_INSTALL_append = " glibc-staticdev"
> > +     TOOLCHAIN_TARGET_TASK_append = " glibc-staticdev"
> >                      </literallayout>
> >                      </para></listitem>

Best Regards,
Maxin


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] documentation: updates to static library support in SDK
       [not found]   ` <CAFNP8OtKLxr+sn2y1-scG9rf_qpJ_3=V8pirFVX7FO8xWNPSdQ@mail.gmail.com>
@ 2017-06-15  8:15     ` Maxin B. John
  0 siblings, 0 replies; 4+ messages in thread
From: Maxin B. John @ 2017-06-15  8:15 UTC (permalink / raw)
  To: Scott Rifenbark; +Cc: Yocto discussion list

Hi Scott,

On Wed, Jun 14, 2017 at 11:29:15AM -0700, Scott Rifenbark wrote:
>Maxin,
>
>Can you send out a new patch with the correction?
>

Sure, will send an updated patch soon.

>Scott
>>
>>On Wed, Jun 14, 2017 at 10:57 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>
>>>    On Wed, Jun 14, 2017 at 5:12 AM, Maxin B. John <maxin.john@intel.com> wrote:
>>> For development purposes, static libraries need to be
<snip>

Best Regards,
Maxin


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-15  8:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-14 12:12 [PATCH] documentation: updates to static library support in SDK Maxin B. John
2017-06-14 17:57 ` Andre McCurdy
2017-06-15  8:12   ` Maxin B. John
     [not found]   ` <CAFNP8OtKLxr+sn2y1-scG9rf_qpJ_3=V8pirFVX7FO8xWNPSdQ@mail.gmail.com>
2017-06-15  8:15     ` Maxin B. John

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.