From: Philipp Zabel <pza@pengutronix.de> To: Linus Walleij <linus.walleij@linaro.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Stephen Boyd <sboyd@codeaurora.org>, Rob Herring <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, Michael Turquette <mturquette@baylibre.com>, linux-clk <linux-clk@vger.kernel.org>, Janos Laube <janos.dev@gmail.com>, Paulius Zaleckas <paulius.zaleckas@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Hans Ulli Kroll <ulli.kroll@googlemail.com>, Florian Fainelli <f.fainelli@gmail.com> Subject: Re: [PATCH 2/2 v4] clk: Add Gemini SoC clock controller Date: Thu, 15 Jun 2017 23:55:50 +0200 [thread overview] Message-ID: <20170615215550.z4ypeh345gopd2pg@pengutronix.de> (raw) In-Reply-To: <CACRpkdY+aSyec9PZaoXErzsRefWg2zzw1xihQt_whmote-jBBw@mail.gmail.com> Hi Linus, On Thu, Jun 15, 2017 at 02:57:53PM +0200, Linus Walleij wrote: > On Thu, Jun 15, 2017 at 10:55 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > > If clocks and resets are provided by the same hardware module, you can > > have a single (platform) driver registering both the clock and reset > > controllers. > > Cfr. drivers/clk/renesas/renesas-cpg-mssr.c. > > That is indeed an option. > > So I would say, clk & reset maintainers: would you prefer that I merge the > reset control into the clock driver as well, ask Philipp to drop the pending > reset control patches from his subsystem tree and have you manage the > combined driver and bindings? The reset/next pull requests are not merged into the arm-soc tree yet. I suppose I could retract the pull requests and drop the Gemini reset patches, if the patches in arm-soc/gemeni/dts are also dropped from arm-soc/for-next. > It seems to me as very ugly from a divide & conquer subsystem and file > split point of view. > > I seems elegant from the "make clocks a platform device" point of view. > > I am happy with either approach as long as it works. > > I guess it is up to the taste of the subsystem maintainers, especially > clk. > > If I get some time I might just hack this up and send the patches so > it is on the table as an alternative to the current v5 patch. Certainly it is > better than going back and augmenting the DT bindings. I have a slight preference for keeping the DT bindings simple, even if that means merging the reset controller into the clock driver. regards Philipp
WARNING: multiple messages have this Message-ID (diff)
From: pza@pengutronix.de (Philipp Zabel) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2 v4] clk: Add Gemini SoC clock controller Date: Thu, 15 Jun 2017 23:55:50 +0200 [thread overview] Message-ID: <20170615215550.z4ypeh345gopd2pg@pengutronix.de> (raw) In-Reply-To: <CACRpkdY+aSyec9PZaoXErzsRefWg2zzw1xihQt_whmote-jBBw@mail.gmail.com> Hi Linus, On Thu, Jun 15, 2017 at 02:57:53PM +0200, Linus Walleij wrote: > On Thu, Jun 15, 2017 at 10:55 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > > If clocks and resets are provided by the same hardware module, you can > > have a single (platform) driver registering both the clock and reset > > controllers. > > Cfr. drivers/clk/renesas/renesas-cpg-mssr.c. > > That is indeed an option. > > So I would say, clk & reset maintainers: would you prefer that I merge the > reset control into the clock driver as well, ask Philipp to drop the pending > reset control patches from his subsystem tree and have you manage the > combined driver and bindings? The reset/next pull requests are not merged into the arm-soc tree yet. I suppose I could retract the pull requests and drop the Gemini reset patches, if the patches in arm-soc/gemeni/dts are also dropped from arm-soc/for-next. > It seems to me as very ugly from a divide & conquer subsystem and file > split point of view. > > I seems elegant from the "make clocks a platform device" point of view. > > I am happy with either approach as long as it works. > > I guess it is up to the taste of the subsystem maintainers, especially > clk. > > If I get some time I might just hack this up and send the patches so > it is on the table as an alternative to the current v5 patch. Certainly it is > better than going back and augmenting the DT bindings. I have a slight preference for keeping the DT bindings simple, even if that means merging the reset controller into the clock driver. regards Philipp
next prev parent reply other threads:[~2017-06-15 21:55 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-24 8:20 [PATCH 2/2 v4] clk: Add Gemini SoC clock controller Linus Walleij 2017-05-24 8:20 ` Linus Walleij 2017-06-01 7:02 ` Stephen Boyd 2017-06-01 7:02 ` Stephen Boyd 2017-06-05 13:34 ` Linus Walleij 2017-06-05 13:34 ` Linus Walleij 2017-06-05 19:58 ` Stephen Boyd 2017-06-05 19:58 ` Stephen Boyd 2017-06-08 12:18 ` Linus Walleij 2017-06-08 12:18 ` Linus Walleij 2017-06-12 6:21 ` Linus Walleij 2017-06-12 6:21 ` Linus Walleij 2017-06-12 21:02 ` Stephen Boyd 2017-06-12 21:02 ` Stephen Boyd 2017-06-14 11:31 ` Linus Walleij 2017-06-14 11:31 ` Linus Walleij 2017-06-14 15:55 ` Stephen Boyd 2017-06-14 15:55 ` Stephen Boyd [not found] ` <20170612210248.GP20170-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2017-06-15 7:16 ` Linus Walleij 2017-06-15 7:16 ` Linus Walleij 2017-06-15 7:16 ` Linus Walleij 2017-06-15 8:55 ` Geert Uytterhoeven 2017-06-15 8:55 ` Geert Uytterhoeven [not found] ` <CAMuHMdXdYNTLCUfQ9rdj8Fffff5G6fGREcHs5-E5LbwPU9yyLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-06-15 12:57 ` Linus Walleij 2017-06-15 12:57 ` Linus Walleij 2017-06-15 12:57 ` Linus Walleij 2017-06-15 21:00 ` Stephen Boyd 2017-06-15 21:00 ` Stephen Boyd [not found] ` <20170615210020.GG20170-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2017-06-16 8:35 ` Linus Walleij 2017-06-16 8:35 ` Linus Walleij 2017-06-16 8:35 ` Linus Walleij 2017-06-15 21:55 ` Philipp Zabel [this message] 2017-06-15 21:55 ` Philipp Zabel 2017-06-16 8:38 ` Linus Walleij 2017-06-16 8:38 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170615215550.z4ypeh345gopd2pg@pengutronix.de \ --to=pza@pengutronix.de \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=geert@linux-m68k.org \ --cc=janos.dev@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=paulius.zaleckas@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=ulli.kroll@googlemail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.