From: Lennart Poettering <mzxreary@0pointer.de>
To: Bastien Nocera <hadess@hadess.net>
Cc: "Zheng, Lv" <lv.zheng@intel.com>,
"Brown, Len" <len.brown@intel.com>,
"systemd-devel@lists.freedesktop.org"
<systemd-devel@lists.freedesktop.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lv Zheng <zetalog@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI
Date: Fri, 16 Jun 2017 18:32:55 +0200 [thread overview]
Message-ID: <20170616163255.GA3461@gardel-login> (raw)
In-Reply-To: <33C872C7-EFB2-4CA0-8CAD-8B6E8916180C@hadess.net>
On Fri, 16.06.17 11:06, Bastien Nocera (hadess@hadess.net) wrote:
> > Let's consider this case with delay:
> > After resume, gnome-setting-daemon queries SW_LID and got "close".
> > Then it lights up the wrong monitors.
> > Then I believe "open" will be delivered to it several seconds later.
> > Should gnome-setting-daemon light-up correct monitors this time?
> > So it just looks like user programs behave with a delay accordingly because of the "platform turnaround" delay.
>
> If you implement it in such a way that GNOME settings daemon behaves weirdly, you'll get my revert request in the mail. Do. Not. Ever. Lie.
Just to mention this:
the reason logind applies the timeout and doesn't immediately react to
lid changes is to be friendly to users, if they quickly close and
reopen the lid. It's not supposed to be a work-around around broken
input drivers.
I am very sure that input drivers shouldn't lie to userspace. If you
don't know the state of the switch, then you don#t know it, and should
clarify that to userspace somehow.
Lennart
--
Lennart Poettering, Red Hat
next prev parent reply other threads:[~2017-06-16 16:32 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 18:46 [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Benjamin Tissoires
2017-06-01 18:46 ` Benjamin Tissoires
2017-06-01 18:46 ` [WIP PATCH 1/4] ACPI: button: extract input creation/destruction helpers Benjamin Tissoires
2017-06-01 18:46 ` Benjamin Tissoires
2017-06-01 18:46 ` [WIP PATCH 2/4] ACPI: button: remove the LID input node when the state is unknown Benjamin Tissoires
2017-06-01 18:46 ` Benjamin Tissoires
2017-06-05 3:19 ` Zheng, Lv
2017-06-05 3:19 ` Zheng, Lv
2017-06-06 10:22 ` Benjamin Tissoires
2017-06-06 10:22 ` Benjamin Tissoires
2017-06-07 1:27 ` Peter Hutterer
2017-06-07 1:27 ` Peter Hutterer
2017-06-07 9:56 ` Zheng, Lv
2017-06-07 9:56 ` Zheng, Lv
2017-06-01 18:46 ` [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events Benjamin Tissoires
2017-06-05 4:28 ` Zheng, Lv
2017-06-05 4:28 ` Zheng, Lv
2017-06-06 10:31 ` Benjamin Tissoires
2017-06-06 10:31 ` Benjamin Tissoires
2017-06-01 18:46 ` [WIP PATCH 4/4] ACPI: button: Fix lid notification locks Benjamin Tissoires
2017-06-05 3:33 ` Zheng, Lv
2017-06-05 3:33 ` Zheng, Lv
2017-06-06 10:29 ` Benjamin Tissoires
2017-06-06 10:29 ` Benjamin Tissoires
2017-06-07 9:47 ` Zheng, Lv
2017-06-07 9:47 ` Zheng, Lv
2017-06-01 21:43 ` [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Bastien Nocera
2017-06-02 7:24 ` Benjamin Tissoires
2017-06-05 2:25 ` Zheng, Lv
2017-06-05 2:25 ` Zheng, Lv
2017-06-07 7:48 ` Lennart Poettering
2017-06-07 7:48 ` [systemd-devel] " Lennart Poettering
2017-06-13 10:06 ` Benjamin Tissoires
2017-06-13 10:06 ` [systemd-devel] " Benjamin Tissoires
2017-06-15 2:52 ` Zheng, Lv
2017-06-15 2:52 ` Zheng, Lv
2017-06-15 6:47 ` Peter Hutterer
2017-06-15 6:47 ` Peter Hutterer
2017-06-15 7:33 ` Zheng, Lv
2017-06-15 7:33 ` Zheng, Lv
2017-06-15 7:57 ` Peter Hutterer
2017-06-15 7:57 ` Peter Hutterer
2017-06-16 5:37 ` Zheng, Lv
2017-06-16 5:37 ` Zheng, Lv
2017-06-16 7:23 ` Benjamin Tissoires
2017-06-16 7:23 ` Benjamin Tissoires
2017-06-16 7:45 ` Zheng, Lv
2017-06-16 7:45 ` Zheng, Lv
2017-06-16 8:09 ` Benjamin Tissoires
2017-06-16 8:09 ` [systemd-devel] " Benjamin Tissoires
2017-06-16 8:53 ` Zheng, Lv
2017-06-16 8:53 ` Zheng, Lv
2017-06-16 9:06 ` Bastien Nocera
2017-06-16 9:06 ` Bastien Nocera
2017-06-16 9:06 ` Bastien Nocera
2017-06-16 16:32 ` Lennart Poettering [this message]
2017-06-16 16:32 ` Lennart Poettering
2017-06-19 2:16 ` Zheng, Lv
2017-06-19 2:16 ` Zheng, Lv
2017-06-19 1:43 ` Zheng, Lv
2017-06-19 1:43 ` Zheng, Lv
2017-06-19 22:08 ` Bastien Nocera
2017-06-19 22:08 ` [systemd-devel] " Bastien Nocera
2017-06-20 2:45 ` Zheng, Lv
2017-06-20 2:45 ` Zheng, Lv
2017-06-21 10:23 ` Bastien Nocera
2017-06-21 10:23 ` Bastien Nocera
2017-06-22 3:16 ` Zheng, Lv
2017-06-22 3:16 ` Zheng, Lv
2017-06-14 23:50 ` Zheng, Lv
2017-06-14 23:50 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616163255.GA3461@gardel-login \
--to=mzxreary@0pointer.de \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=systemd-devel@lists.freedesktop.org \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.