From: Yury Norov <ynorov@caviumnetworks.com> To: Catalin Marinas <catalin.marinas@arm.com>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: Yury Norov <ynorov@caviumnetworks.com>, Adam Borowski <kilobyte@angband.pl>, Andreas Schwab <schwab@suse.de>, Andrew Pinski <pinskia@gmail.com>, Bamvor Zhangjian <bamvor.zhangjian@huawei.com>, Chris Metcalf <cmetcalf@ezchip.com>, Chris Metcalf <cmetcalf@mellanox.com>, Florian Weimer <fweimer@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, James Hogan <james.hogan@imgtec.com>, James Morse <james.morse@arm.com>, Joseph Myers <joseph@codesourcery.com>, Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>, Nathan_Lynch@mentor.com, Prasun.Kapoor@caviumnetworks.com, Ramana Radhakrishnan <ramana.gcc@googlemail.com>, Steve Ellcey <sellcey@caviumnetworks.com>, Alexander Graf <agraf@suse.de>, Mark Brown <broonie@kernel.org>, christoph.muellner@theobroma-systems.com, davem@davemloft.net, Geert Uytterhoeven <geert@linux-m68k.org>, Alexey Klimov <klimov.linux@gmail.com>, linyongting@huawei.com, manuel.montezelo@gmail.com, philipp.tomsich@theobroma-systems.com, schwidefsky@de.ibm.com, szabolcs.nagy@arm.com, zhouchengming1@huawei.com Subject: [PATCH 08/20] thread: move thread bits accessors to separated file Date: Mon, 19 Jun 2017 18:49:51 +0300 [thread overview] Message-ID: <20170619155003.13218-9-ynorov@caviumnetworks.com> (raw) In-Reply-To: <20170619155003.13218-1-ynorov@caviumnetworks.com> They may be accessed from low-level code, so isolating is a measure to avoid circular dependencies in header files. The exact reason for circular dependency is WARN_ON() macro added in patch edd63a27 "set_restore_sigmask() is never called without SIGPENDING (and never should be)" Signed-off-by: Yury Norov <ynorov@caviumnetworks.com> --- include/linux/thread_bits.h | 63 +++++++++++++++++++++++++++++++++++++++++++ include/linux/thread_info.h | 65 +++++++++------------------------------------ 2 files changed, 75 insertions(+), 53 deletions(-) create mode 100644 include/linux/thread_bits.h diff --git a/include/linux/thread_bits.h b/include/linux/thread_bits.h new file mode 100644 index 000000000000..87354331bc7b --- /dev/null +++ b/include/linux/thread_bits.h @@ -0,0 +1,63 @@ +/* thread_bits.h: common low-level thread bits accessors */ + +#ifndef _LINUX_THREAD_BITS_H +#define _LINUX_THREAD_BITS_H + +#ifndef __ASSEMBLY__ + +#include <linux/bitops.h> +#include <asm/thread_info.h> + +#ifdef CONFIG_THREAD_INFO_IN_TASK +/* + * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the + * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels, + * including <asm/current.h> can cause a circular dependency on some platforms. + */ +#include <asm/current.h> +#define current_thread_info() ((struct thread_info *)current) +#endif + +/* + * flag set/clear/test wrappers + * - pass TIF_xxxx constants to these functions + */ + +static inline void set_ti_thread_flag(struct thread_info *ti, int flag) +{ + set_bit(flag, (unsigned long *)&ti->flags); +} + +static inline void clear_ti_thread_flag(struct thread_info *ti, int flag) +{ + clear_bit(flag, (unsigned long *)&ti->flags); +} + +static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag) +{ + return test_and_set_bit(flag, (unsigned long *)&ti->flags); +} + +static inline int test_and_clear_ti_thread_flag(struct thread_info *ti, int flag) +{ + return test_and_clear_bit(flag, (unsigned long *)&ti->flags); +} + +static inline int test_ti_thread_flag(struct thread_info *ti, int flag) +{ + return test_bit(flag, (unsigned long *)&ti->flags); +} + +#define set_thread_flag(flag) \ + set_ti_thread_flag(current_thread_info(), flag) +#define clear_thread_flag(flag) \ + clear_ti_thread_flag(current_thread_info(), flag) +#define test_and_set_thread_flag(flag) \ + test_and_set_ti_thread_flag(current_thread_info(), flag) +#define test_and_clear_thread_flag(flag) \ + test_and_clear_ti_thread_flag(current_thread_info(), flag) +#define test_thread_flag(flag) \ + test_ti_thread_flag(current_thread_info(), flag) + +#endif /* !__ASSEMBLY__ */ +#endif /* _LINUX_THREAD_BITS_H */ diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h index d7d3ea637dd0..c40a89357329 100644 --- a/include/linux/thread_info.h +++ b/include/linux/thread_info.h @@ -7,9 +7,21 @@ #ifndef _LINUX_THREAD_INFO_H #define _LINUX_THREAD_INFO_H +/* + * For per-arch arch_within_stack_frames() implementations, defined in + * asm/thread_info.h. + */ +enum { + BAD_STACK = -1, + NOT_STACK = 0, + GOOD_FRAME, + GOOD_STACK, +}; + #include <linux/types.h> #include <linux/bug.h> #include <linux/restart_block.h> +#include <linux/thread_bits.h> #ifdef CONFIG_THREAD_INFO_IN_TASK /* @@ -22,18 +34,6 @@ #endif #include <linux/bitops.h> - -/* - * For per-arch arch_within_stack_frames() implementations, defined in - * asm/thread_info.h. - */ -enum { - BAD_STACK = -1, - NOT_STACK = 0, - GOOD_FRAME, - GOOD_STACK, -}; - #include <asm/thread_info.h> #ifdef __KERNEL__ @@ -45,47 +45,6 @@ enum { # define THREADINFO_GFP (GFP_KERNEL_ACCOUNT | __GFP_NOTRACK) #endif -/* - * flag set/clear/test wrappers - * - pass TIF_xxxx constants to these functions - */ - -static inline void set_ti_thread_flag(struct thread_info *ti, int flag) -{ - set_bit(flag, (unsigned long *)&ti->flags); -} - -static inline void clear_ti_thread_flag(struct thread_info *ti, int flag) -{ - clear_bit(flag, (unsigned long *)&ti->flags); -} - -static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag) -{ - return test_and_set_bit(flag, (unsigned long *)&ti->flags); -} - -static inline int test_and_clear_ti_thread_flag(struct thread_info *ti, int flag) -{ - return test_and_clear_bit(flag, (unsigned long *)&ti->flags); -} - -static inline int test_ti_thread_flag(struct thread_info *ti, int flag) -{ - return test_bit(flag, (unsigned long *)&ti->flags); -} - -#define set_thread_flag(flag) \ - set_ti_thread_flag(current_thread_info(), flag) -#define clear_thread_flag(flag) \ - clear_ti_thread_flag(current_thread_info(), flag) -#define test_and_set_thread_flag(flag) \ - test_and_set_ti_thread_flag(current_thread_info(), flag) -#define test_and_clear_thread_flag(flag) \ - test_and_clear_ti_thread_flag(current_thread_info(), flag) -#define test_thread_flag(flag) \ - test_ti_thread_flag(current_thread_info(), flag) - #define tif_need_resched() test_thread_flag(TIF_NEED_RESCHED) #ifndef CONFIG_HAVE_ARCH_WITHIN_STACK_FRAMES -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: ynorov@caviumnetworks.com (Yury Norov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/20] thread: move thread bits accessors to separated file Date: Mon, 19 Jun 2017 18:49:51 +0300 [thread overview] Message-ID: <20170619155003.13218-9-ynorov@caviumnetworks.com> (raw) In-Reply-To: <20170619155003.13218-1-ynorov@caviumnetworks.com> They may be accessed from low-level code, so isolating is a measure to avoid circular dependencies in header files. The exact reason for circular dependency is WARN_ON() macro added in patch edd63a27 "set_restore_sigmask() is never called without SIGPENDING (and never should be)" Signed-off-by: Yury Norov <ynorov@caviumnetworks.com> --- include/linux/thread_bits.h | 63 +++++++++++++++++++++++++++++++++++++++++++ include/linux/thread_info.h | 65 +++++++++------------------------------------ 2 files changed, 75 insertions(+), 53 deletions(-) create mode 100644 include/linux/thread_bits.h diff --git a/include/linux/thread_bits.h b/include/linux/thread_bits.h new file mode 100644 index 000000000000..87354331bc7b --- /dev/null +++ b/include/linux/thread_bits.h @@ -0,0 +1,63 @@ +/* thread_bits.h: common low-level thread bits accessors */ + +#ifndef _LINUX_THREAD_BITS_H +#define _LINUX_THREAD_BITS_H + +#ifndef __ASSEMBLY__ + +#include <linux/bitops.h> +#include <asm/thread_info.h> + +#ifdef CONFIG_THREAD_INFO_IN_TASK +/* + * For CONFIG_THREAD_INFO_IN_TASK kernels we need <asm/current.h> for the + * definition of current, but for !CONFIG_THREAD_INFO_IN_TASK kernels, + * including <asm/current.h> can cause a circular dependency on some platforms. + */ +#include <asm/current.h> +#define current_thread_info() ((struct thread_info *)current) +#endif + +/* + * flag set/clear/test wrappers + * - pass TIF_xxxx constants to these functions + */ + +static inline void set_ti_thread_flag(struct thread_info *ti, int flag) +{ + set_bit(flag, (unsigned long *)&ti->flags); +} + +static inline void clear_ti_thread_flag(struct thread_info *ti, int flag) +{ + clear_bit(flag, (unsigned long *)&ti->flags); +} + +static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag) +{ + return test_and_set_bit(flag, (unsigned long *)&ti->flags); +} + +static inline int test_and_clear_ti_thread_flag(struct thread_info *ti, int flag) +{ + return test_and_clear_bit(flag, (unsigned long *)&ti->flags); +} + +static inline int test_ti_thread_flag(struct thread_info *ti, int flag) +{ + return test_bit(flag, (unsigned long *)&ti->flags); +} + +#define set_thread_flag(flag) \ + set_ti_thread_flag(current_thread_info(), flag) +#define clear_thread_flag(flag) \ + clear_ti_thread_flag(current_thread_info(), flag) +#define test_and_set_thread_flag(flag) \ + test_and_set_ti_thread_flag(current_thread_info(), flag) +#define test_and_clear_thread_flag(flag) \ + test_and_clear_ti_thread_flag(current_thread_info(), flag) +#define test_thread_flag(flag) \ + test_ti_thread_flag(current_thread_info(), flag) + +#endif /* !__ASSEMBLY__ */ +#endif /* _LINUX_THREAD_BITS_H */ diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h index d7d3ea637dd0..c40a89357329 100644 --- a/include/linux/thread_info.h +++ b/include/linux/thread_info.h @@ -7,9 +7,21 @@ #ifndef _LINUX_THREAD_INFO_H #define _LINUX_THREAD_INFO_H +/* + * For per-arch arch_within_stack_frames() implementations, defined in + * asm/thread_info.h. + */ +enum { + BAD_STACK = -1, + NOT_STACK = 0, + GOOD_FRAME, + GOOD_STACK, +}; + #include <linux/types.h> #include <linux/bug.h> #include <linux/restart_block.h> +#include <linux/thread_bits.h> #ifdef CONFIG_THREAD_INFO_IN_TASK /* @@ -22,18 +34,6 @@ #endif #include <linux/bitops.h> - -/* - * For per-arch arch_within_stack_frames() implementations, defined in - * asm/thread_info.h. - */ -enum { - BAD_STACK = -1, - NOT_STACK = 0, - GOOD_FRAME, - GOOD_STACK, -}; - #include <asm/thread_info.h> #ifdef __KERNEL__ @@ -45,47 +45,6 @@ enum { # define THREADINFO_GFP (GFP_KERNEL_ACCOUNT | __GFP_NOTRACK) #endif -/* - * flag set/clear/test wrappers - * - pass TIF_xxxx constants to these functions - */ - -static inline void set_ti_thread_flag(struct thread_info *ti, int flag) -{ - set_bit(flag, (unsigned long *)&ti->flags); -} - -static inline void clear_ti_thread_flag(struct thread_info *ti, int flag) -{ - clear_bit(flag, (unsigned long *)&ti->flags); -} - -static inline int test_and_set_ti_thread_flag(struct thread_info *ti, int flag) -{ - return test_and_set_bit(flag, (unsigned long *)&ti->flags); -} - -static inline int test_and_clear_ti_thread_flag(struct thread_info *ti, int flag) -{ - return test_and_clear_bit(flag, (unsigned long *)&ti->flags); -} - -static inline int test_ti_thread_flag(struct thread_info *ti, int flag) -{ - return test_bit(flag, (unsigned long *)&ti->flags); -} - -#define set_thread_flag(flag) \ - set_ti_thread_flag(current_thread_info(), flag) -#define clear_thread_flag(flag) \ - clear_ti_thread_flag(current_thread_info(), flag) -#define test_and_set_thread_flag(flag) \ - test_and_set_ti_thread_flag(current_thread_info(), flag) -#define test_and_clear_thread_flag(flag) \ - test_and_clear_ti_thread_flag(current_thread_info(), flag) -#define test_thread_flag(flag) \ - test_ti_thread_flag(current_thread_info(), flag) - #define tif_need_resched() test_thread_flag(TIF_NEED_RESCHED) #ifndef CONFIG_HAVE_ARCH_WITHIN_STACK_FRAMES -- 2.11.0
next prev parent reply other threads:[~2017-06-19 15:56 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-19 15:49 [PATCH v8 00/20] ILP32 for ARM64 Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 01/20] compat ABI: use non-compat openat and open_by_handle_at variants Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 02/20] 32-bit userspace ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls from default list Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 21:42 ` James Hogan 2017-06-19 21:42 ` James Hogan 2017-06-19 21:58 ` Arnd Bergmann 2017-06-19 21:58 ` Arnd Bergmann 2017-06-19 22:10 ` James Hogan 2017-06-19 22:10 ` James Hogan 2017-06-20 13:37 ` Yury Norov 2017-06-20 13:37 ` Yury Norov 2017-06-20 14:20 ` Arnd Bergmann 2017-06-20 14:20 ` Arnd Bergmann 2017-06-20 14:54 ` Yury Norov 2017-06-20 14:54 ` Yury Norov 2017-06-20 15:27 ` Arnd Bergmann 2017-06-20 15:27 ` Arnd Bergmann 2017-06-20 21:14 ` Palmer Dabbelt 2017-06-20 21:14 ` Palmer Dabbelt 2017-06-20 14:36 ` Yury Norov 2017-06-20 14:36 ` Yury Norov 2017-06-20 14:42 ` Yury Norov 2017-06-20 14:42 ` Yury Norov 2017-06-19 15:49 ` [PATCH 04/20] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 05/20] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 06/20] arm64: ensure the kernel is compiled for LP64 Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 07/20] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` Yury Norov [this message] 2017-06-19 15:49 ` [PATCH 08/20] thread: move thread bits accessors to separated file Yury Norov [not found] ` <mvma8432jsx.fsf@suse.de> 2017-07-17 15:51 ` Yury Norov 2017-07-17 15:51 ` Yury Norov 2017-06-19 15:49 ` [PATCH 09/20] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 10/20] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov 2017-06-19 15:49 ` [PATCH 10/20] arm64: ilp32: add is_ilp32_compat_{task, thread} " Yury Norov 2017-06-19 15:49 ` [PATCH 11/20] arm64: introduce binfmt_elf32.c Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 12/20] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 13/20] arm64: ilp32: share aarch32 syscall handlers Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 14/20] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 15/20] arm64: signal: share lp64 signal routines to ilp32 Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:49 ` [PATCH 16/20] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov 2017-06-19 15:49 ` Yury Norov 2017-06-19 15:50 ` [PATCH 17/20] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov 2017-06-19 15:50 ` Yury Norov 2017-06-19 15:50 ` [PATCH 18/20] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov 2017-06-19 15:50 ` Yury Norov 2017-06-19 15:50 ` [PATCH 19/20] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov 2017-06-19 15:50 ` Yury Norov 2017-06-19 15:50 ` [PATCH 20/20] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov 2017-06-19 15:50 ` Yury Norov 2017-06-29 16:10 ` [PATCH v8 00/20] ILP32 for ARM64 Catalin Marinas 2017-06-29 16:10 ` Catalin Marinas 2017-07-06 21:59 ` Yury Norov 2017-07-06 21:59 ` Yury Norov 2017-07-07 17:11 ` Catalin Marinas 2017-07-07 17:11 ` Catalin Marinas 2017-07-24 11:26 ` Yury Norov 2017-07-24 11:26 ` Yury Norov 2017-07-27 17:12 ` Catalin Marinas 2017-07-27 17:12 ` Catalin Marinas 2017-07-31 12:37 ` Yury Norov 2017-07-31 12:37 ` Yury Norov 2017-08-08 13:34 ` Catalin Marinas 2017-08-08 13:34 ` Catalin Marinas 2017-08-21 10:21 ` Yury Norov 2017-08-21 10:21 ` Yury Norov 2017-09-04 11:54 ` Yury Norov 2017-09-04 11:54 ` Yury Norov 2017-09-18 10:06 ` Catalin Marinas 2017-09-18 10:06 ` Catalin Marinas 2017-09-15 11:29 ` Yury Norov 2017-09-15 11:29 ` Yury Norov 2017-11-16 11:11 ` Yury Norov 2017-11-16 11:11 ` Yury Norov 2017-12-11 10:32 ` Catalin Marinas 2017-12-11 10:32 ` Catalin Marinas 2017-12-11 13:13 ` Yury Norov 2017-12-11 13:13 ` Yury Norov 2018-02-02 8:16 ` Yury Norov 2018-02-02 8:16 ` Yury Norov 2018-02-02 8:58 ` Bamvor Zhang 2018-02-02 8:58 ` Bamvor Zhang -- strict thread matches above, loose matches on Subject: below -- 2017-06-04 11:59 Yury Norov 2017-06-04 11:59 ` [PATCH 08/20] thread: move thread bits accessors to separated file Yury Norov 2017-06-04 11:59 ` Yury Norov 2017-03-01 19:19 [PATCH v7 resend 00/20] ILP32 for ARM64 Yury Norov 2017-03-01 19:19 ` [PATCH 08/20] thread: move thread bits accessors to separated file Yury Norov 2017-03-01 19:19 ` Yury Norov 2017-01-09 11:29 [PATCH v7 00/20] ILP32 for ARM64 Yury Norov 2017-01-09 11:29 ` [PATCH 08/20] thread: move thread bits accessors to separated file Yury Norov 2017-01-09 11:29 ` Yury Norov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170619155003.13218-9-ynorov@caviumnetworks.com \ --to=ynorov@caviumnetworks.com \ --cc=Nathan_Lynch@mentor.com \ --cc=Prasun.Kapoor@caviumnetworks.com \ --cc=agraf@suse.de \ --cc=arnd@arndb.de \ --cc=bamvor.zhangjian@huawei.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=christoph.muellner@theobroma-systems.com \ --cc=cmetcalf@ezchip.com \ --cc=cmetcalf@mellanox.com \ --cc=davem@davemloft.net \ --cc=fweimer@redhat.com \ --cc=geert@linux-m68k.org \ --cc=heiko.carstens@de.ibm.com \ --cc=james.hogan@imgtec.com \ --cc=james.morse@arm.com \ --cc=joseph@codesourcery.com \ --cc=kilobyte@angband.pl \ --cc=klimov.linux@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linyongting@huawei.com \ --cc=manuel.montezelo@gmail.com \ --cc=maxim.kuvyrkov@linaro.org \ --cc=philipp.tomsich@theobroma-systems.com \ --cc=pinskia@gmail.com \ --cc=ramana.gcc@googlemail.com \ --cc=schwab@suse.de \ --cc=schwidefsky@de.ibm.com \ --cc=sellcey@caviumnetworks.com \ --cc=szabolcs.nagy@arm.com \ --cc=zhouchengming1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.