From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-nvdimm@lists.01.org, stable@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] dax: Fix inefficiency in dax_writeback_mapping_range()
Date: Mon, 19 Jun 2017 10:34:52 -0600 [thread overview]
Message-ID: <20170619163452.GA27087@linux.intel.com> (raw)
In-Reply-To: <20170619124531.21491-1-jack@suse.cz>
On Mon, Jun 19, 2017 at 02:45:31PM +0200, Jan Kara wrote:
> dax_writeback_mapping_range() fails to update iteration index when
> searching radix tree for entries needing cache flushing. Thus each
> pagevec worth of entries is searched starting from the start which is
> inefficient and prone to livelocks. Update index properly.
>
> CC: stable@vger.kernel.org
> Fixes: 9973c98ecfda3a1dfcab981665b5f1e39bcde64a
> Signed-off-by: Jan Kara <jack@suse.cz>
Yep, this seems good, thanks.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [PATCH] dax: Fix inefficiency in dax_writeback_mapping_range()
Date: Mon, 19 Jun 2017 10:34:52 -0600 [thread overview]
Message-ID: <20170619163452.GA27087@linux.intel.com> (raw)
In-Reply-To: <20170619124531.21491-1-jack@suse.cz>
On Mon, Jun 19, 2017 at 02:45:31PM +0200, Jan Kara wrote:
> dax_writeback_mapping_range() fails to update iteration index when
> searching radix tree for entries needing cache flushing. Thus each
> pagevec worth of entries is searched starting from the start which is
> inefficient and prone to livelocks. Update index properly.
>
> CC: stable@vger.kernel.org
> Fixes: 9973c98ecfda3a1dfcab981665b5f1e39bcde64a
> Signed-off-by: Jan Kara <jack@suse.cz>
Yep, this seems good, thanks.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-19 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 12:45 [PATCH] dax: Fix inefficiency in dax_writeback_mapping_range() Jan Kara
2017-06-19 12:45 ` Jan Kara
2017-06-19 12:45 ` Jan Kara
2017-06-19 16:34 ` Ross Zwisler [this message]
2017-06-19 16:34 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619163452.GA27087@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.