Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

[陈晓光]

Hi, Guys
Any comments for this change?


Thanks
Xiaoguang

2017-06-02 7:27 GMT+08:00  <xgchenshy@gmail.com>:
> From: Xiaoguang Chen <xgchenshy@gmail.com>
>
> dwapb_irq_set_type overwrites polarity register value for
> IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0
> by default, then it will set falling edge irq trigger.
> and the gpio may requires rising edge irq for the first time,
> and it will be missed.
>
> Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case
> can solve this issue.
>
> Signed-off-by: Xiaoguang Chen <xgchenshy@gmail.com>
> ---
>  drivers/gpio/gpio-dwapb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index f051c45..80913e4 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -288,7 +288,8 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
>         irq_setup_alt_chip(d, type);
>
>         dwapb_write(gpio, GPIO_INTTYPE_LEVEL, level);
> -       dwapb_write(gpio, GPIO_INT_POLARITY, polarity);
> +       if （type != IRQ_TYPE_EDGE_BOTH）
> +               dwapb_write(gpio, GPIO_INT_POLARITY, polarity);
>         spin_unlock_irqrestore(&gc->bgpio_lock, flags);
>
>         return 0;
> --
> 2.8.4 (Apple Git-73)
>

Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

[Linus Walleij]

Adding driver authors to the To: Line and top posting to get some
review.

Yours,
Linus Walleij


On Fri, Jun 2, 2017 at 1:27 AM,  <xgchenshy@gmail.com> wrote:
> From: Xiaoguang Chen <xgchenshy@gmail.com>
>
> dwapb_irq_set_type overwrites polarity register value for
> IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0
> by default, then it will set falling edge irq trigger.
> and the gpio may requires rising edge irq for the first time,
> and it will be missed.
>
> Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case
> can solve this issue.
>
> Signed-off-by: Xiaoguang Chen <xgchenshy@gmail.com>
> ---
>  drivers/gpio/gpio-dwapb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index f051c45..80913e4 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -288,7 +288,8 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
>         irq_setup_alt_chip(d, type);
>
>         dwapb_write(gpio, GPIO_INTTYPE_LEVEL, level);
> -       dwapb_write(gpio, GPIO_INT_POLARITY, polarity);
> +       if （type != IRQ_TYPE_EDGE_BOTH）
> +               dwapb_write(gpio, GPIO_INT_POLARITY, polarity);
>         spin_unlock_irqrestore(&gc->bgpio_lock, flags);
>
>         return 0;
> --
> 2.8.4 (Apple Git-73)
>

Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

[Jisheng Zhang]

On Fri, 9 Jun 2017 11:26:19 +0200 Linus Walleij wrote:

> 
> On Fri, Jun 2, 2017 at 1:27 AM,  <xgchenshy@gmail.com> wrote:
> > From: Xiaoguang Chen <xgchenshy@gmail.com>
> >
> > dwapb_irq_set_type overwrites polarity register value for
> > IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0
> > by default, then it will set falling edge irq trigger.
> > and the gpio may requires rising edge irq for the first time,
> > and it will be missed.
> >
> > Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case
> > can solve this issue.

I think this is a correct fix.

> >
> > Signed-off-by: Xiaoguang Chen <xgchenshy@gmail.com>

Tested-by: Jisheng Zhang <jszhang@marvell.com>

> > ---
> >  drivers/gpio/gpio-dwapb.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> > index f051c45..80913e4 100644
> > --- a/drivers/gpio/gpio-dwapb.c
> > +++ b/drivers/gpio/gpio-dwapb.c
> > @@ -288,7 +288,8 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
> >         irq_setup_alt_chip(d, type);
> >
> >         dwapb_write(gpio, GPIO_INTTYPE_LEVEL, level);
> > -       dwapb_write(gpio, GPIO_INT_POLARITY, polarity);
> > +       if （type != IRQ_TYPE_EDGE_BOTH）
> > +               dwapb_write(gpio, GPIO_INT_POLARITY, polarity);
> >         spin_unlock_irqrestore(&gc->bgpio_lock, flags);
> >
> >         return 0;
> > --
> > 2.8.4 (Apple Git-73)
> >  

Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

[Jisheng Zhang]

On Mon, 12 Jun 2017 13:05:30 +0800 Jisheng Zhang wrote:

> On Fri, 9 Jun 2017 11:26:19 +0200 Linus Walleij wrote:
> 
> > 
> > On Fri, Jun 2, 2017 at 1:27 AM,  <xgchenshy@gmail.com> wrote:  
> > > From: Xiaoguang Chen <xgchenshy@gmail.com>
> > >
> > > dwapb_irq_set_type overwrites polarity register value for
> > > IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0
> > > by default, then it will set falling edge irq trigger.
> > > and the gpio may requires rising edge irq for the first time,
> > > and it will be missed.
> > >
> > > Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case
> > > can solve this issue.  
> 
> I think this is a correct fix.
> 
> > >
> > > Signed-off-by: Xiaoguang Chen <xgchenshy@gmail.com>  
> 
> Tested-by: Jisheng Zhang <jszhang@marvell.com>

Per my test, this patch fixes the following bug:

make use of CD-GPIO mechanism. Cold boot with sdcard inserted, hot-unplug
the sdcard, sometimes, kernel won't get the remove interrupt.

Thanks

Re: [PATCH] gpio: dwapb: fix missing first irq for edgeboth irq type

[Linus Walleij]

On Fri, Jun 2, 2017 at 1:27 AM,  <xgchenshy@gmail.com> wrote:

> From: Xiaoguang Chen <xgchenshy@gmail.com>
>
> dwapb_irq_set_type overwrites polarity register value for
> IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0
> by default, then it will set falling edge irq trigger.
> and the gpio may requires rising edge irq for the first time,
> and it will be missed.
>
> Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case
> can solve this issue.
>
> Signed-off-by: Xiaoguang Chen <xgchenshy@gmail.com>

Patch applied with Jisheng's tested tag.

Yours,
Linus Walleij