From: Christoph Hellwig <hch@infradead.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk, sza@esh.hu,
arnd@arndb.de, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, alexandre.torgue@st.com,
robin.murphy@arm.com, benjamin.gaignard@linaro.org,
kbuild-all@01.org, Joerg Roedel <jroedel@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset
Date: Tue, 20 Jun 2017 06:24:00 -0700 [thread overview]
Message-ID: <20170620132400.GB11370@infradead.org> (raw)
In-Reply-To: <1495621472-9323-2-git-send-email-vladimir.murzin@arm.com>
> - sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
> + sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));
Needs a line break instead of the overly long line.
Otherwise this looks fine to me.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/7] dma: Take into account dma_pfn_offset
Date: Tue, 20 Jun 2017 06:24:00 -0700 [thread overview]
Message-ID: <20170620132400.GB11370@infradead.org> (raw)
In-Reply-To: <1495621472-9323-2-git-send-email-vladimir.murzin@arm.com>
> - sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
> + sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));
Needs a line break instead of the overly long line.
Otherwise this looks fine to me.
next prev parent reply other threads:[~2017-06-20 13:24 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 10:24 [PATCH v5 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-05-24 10:24 ` [PATCH v5 1/7] dma: Take into account dma_pfn_offset Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-06-20 13:24 ` Christoph Hellwig [this message]
2017-06-20 13:24 ` Christoph Hellwig
2017-06-22 12:47 ` Vladimir Murzin
2017-06-22 12:47 ` Vladimir Murzin
2017-05-24 10:24 ` [PATCH v5 2/7] dma: Add simple dma_noop_mmap Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-06-20 13:23 ` Christoph Hellwig
2017-06-20 13:23 ` Christoph Hellwig
2017-06-22 12:46 ` Vladimir Murzin
2017-06-22 12:46 ` Vladimir Murzin
2017-06-26 9:45 ` Christoph Hellwig
2017-06-26 9:45 ` Christoph Hellwig
2017-05-24 10:24 ` [PATCH v5 3/7] drivers: dma-coherent: Account dma_pfn_offset when used with device tree Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-06-20 13:42 ` Christoph Hellwig
2017-06-20 13:42 ` Christoph Hellwig
2017-06-20 13:50 ` Robin Murphy
2017-06-20 13:50 ` Robin Murphy
2017-06-26 9:37 ` Christoph Hellwig
2017-06-26 9:37 ` Christoph Hellwig
2017-06-22 12:59 ` Vladimir Murzin
2017-06-22 12:59 ` Vladimir Murzin
2017-05-24 10:24 ` [PATCH v5 4/7] drivers: dma-coherent: Introduce default DMA pool Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-06-20 13:49 ` Christoph Hellwig
2017-06-20 13:49 ` Christoph Hellwig
2017-06-20 14:24 ` Robin Murphy
2017-06-20 14:24 ` Robin Murphy
2017-06-26 9:42 ` Christoph Hellwig
2017-06-26 9:42 ` Christoph Hellwig
2017-06-26 14:08 ` Vladimir Murzin
2017-06-26 14:08 ` Vladimir Murzin
2017-06-27 14:36 ` Robin Murphy
2017-06-27 14:36 ` Robin Murphy
2017-06-27 15:22 ` Christoph Hellwig
2017-06-27 15:22 ` Christoph Hellwig
2017-06-22 13:18 ` Vladimir Murzin
2017-06-22 13:18 ` Vladimir Murzin
2017-06-26 9:44 ` Christoph Hellwig
2017-06-26 9:44 ` Christoph Hellwig
2017-05-24 10:24 ` [PATCH v5 5/7] ARM: NOMMU: Introduce dma operations for noMMU Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-05-24 10:24 ` [PATCH v5 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class cpus Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-05-24 10:24 ` [PATCH v5 7/7] ARM: dma-mapping: Remove traces of NOMMU code Vladimir Murzin
2017-05-24 10:24 ` Vladimir Murzin
2017-06-08 8:28 ` [PATCH v5 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Vladimir Murzin
2017-06-08 8:28 ` Vladimir Murzin
2017-06-08 16:25 ` Russell King - ARM Linux
2017-06-08 16:25 ` Russell King - ARM Linux
2017-06-15 7:25 ` Vladimir Murzin
2017-06-15 7:25 ` Vladimir Murzin
2017-06-20 12:59 ` Vladimir Murzin
2017-06-20 12:59 ` Vladimir Murzin
2017-06-20 13:00 ` Christoph Hellwig
2017-06-20 13:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620132400.GB11370@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jroedel@suse.de \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=sza@esh.hu \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.