* [PATCH] drm/amdgpu: fix typo in amdgpu_debugfs_test_ib_init
@ 2017-06-21 21:51 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-06-21 21:51 UTC (permalink / raw)
To: Alex Deucher
Cc: Arnd Bergmann, Christian König, David Airlie, Chunming Zhou,
Monk Liu, Tom St Denis, Huang Rui, Ken Wang, Junwei Zhang,
amd-gfx, dri-devel, linux-kernel
The debugfs interface has calls a function that was evidently
defined under the wrong name in some configurations:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:64:12: error: 'amdgpu_debugfs_test_ib_ring_init' used but never defined [-Werror]
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3803:12: error: 'amdgpu_debugfs_test_ib_init' defined but not used [-Werror=unused-function]
This fixes the function name.
Fixes: 4f0955fcc052 ("drm/amdgpu: export test ib debugfs interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 2ee7c50c70f9..4a8fc15467cf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3800,7 +3800,7 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
return 0;
}
#else
-static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
+static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
{
return 0;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdgpu: fix typo in amdgpu_debugfs_test_ib_init
@ 2017-06-21 21:51 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-06-21 21:51 UTC (permalink / raw)
To: Alex Deucher
Cc: Tom St Denis, Arnd Bergmann, linux-kernel, amd-gfx, Huang Rui,
dri-devel, Junwei Zhang, Ken Wang, Christian König,
Monk Liu
The debugfs interface has calls a function that was evidently
defined under the wrong name in some configurations:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:64:12: error: 'amdgpu_debugfs_test_ib_ring_init' used but never defined [-Werror]
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3803:12: error: 'amdgpu_debugfs_test_ib_init' defined but not used [-Werror=unused-function]
This fixes the function name.
Fixes: 4f0955fcc052 ("drm/amdgpu: export test ib debugfs interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 2ee7c50c70f9..4a8fc15467cf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3800,7 +3800,7 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
return 0;
}
#else
-static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
+static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
{
return 0;
}
--
2.9.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: fix typo in amdgpu_debugfs_test_ib_init
@ 2017-06-21 22:10 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-06-21 22:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alex Deucher, Tom St Denis, LKML, amd-gfx list, Huang Rui,
Maling list - DRI developers, Junwei Zhang, Ken Wang,
Christian König, Monk Liu
On Wed, Jun 21, 2017 at 5:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The debugfs interface has calls a function that was evidently
> defined under the wrong name in some configurations:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:64:12: error: 'amdgpu_debugfs_test_ib_ring_init' used but never defined [-Werror]
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3803:12: error: 'amdgpu_debugfs_test_ib_init' defined but not used [-Werror=unused-function]
>
> This fixes the function name.
>
> Fixes: 4f0955fcc052 ("drm/amdgpu: export test ib debugfs interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 2ee7c50c70f9..4a8fc15467cf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3800,7 +3800,7 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
> return 0;
> }
> #else
> -static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
> +static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
> {
> return 0;
> }
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: fix typo in amdgpu_debugfs_test_ib_init
@ 2017-06-21 22:10 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-06-21 22:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tom St Denis, LKML, Maling list - DRI developers, Junwei Zhang,
Huang Rui, amd-gfx list, Alex Deucher, Ken Wang,
Christian König, Monk Liu
On Wed, Jun 21, 2017 at 5:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The debugfs interface has calls a function that was evidently
> defined under the wrong name in some configurations:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:64:12: error: 'amdgpu_debugfs_test_ib_ring_init' used but never defined [-Werror]
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3803:12: error: 'amdgpu_debugfs_test_ib_init' defined but not used [-Werror=unused-function]
>
> This fixes the function name.
>
> Fixes: 4f0955fcc052 ("drm/amdgpu: export test ib debugfs interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 2ee7c50c70f9..4a8fc15467cf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3800,7 +3800,7 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
> return 0;
> }
> #else
> -static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
> +static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
> {
> return 0;
> }
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-21 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 21:51 [PATCH] drm/amdgpu: fix typo in amdgpu_debugfs_test_ib_init Arnd Bergmann
2017-06-21 21:51 ` Arnd Bergmann
2017-06-21 22:10 ` Alex Deucher
2017-06-21 22:10 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.