All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/dt-utils: new package
@ 2017-06-20 15:24 Marcin Niestroj
  2017-06-21 20:23 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Marcin Niestroj @ 2017-06-20 15:24 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/dt-utils/Config.in   |  8 ++++++++
 package/dt-utils/dt-utils.mk | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/dt-utils/Config.in
 create mode 100644 package/dt-utils/dt-utils.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index afc45962c..84f06be13 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1063,6 +1063,7 @@ N:	Marcin Niestroj <m.niestroj@grinn-global.com>
 F:	board/grinn/
 F:	configs/grinn_*
 F:	package/argparse/
+F:	package/dt-utils/
 F:	package/easydbus/
 F:	package/luaossl/
 F:	package/rs485conf/
diff --git a/package/Config.in b/package/Config.in
index 9df0b4247..4c04aa80d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -382,6 +382,7 @@ endmenu
 	source "package/devmem2/Config.in"
 	source "package/dmidecode/Config.in"
 	source "package/dmraid/Config.in"
+	source "package/dt-utils/Config.in"
 	source "package/dtv-scan-tables/Config.in"
 	source "package/dvb-apps/Config.in"
 	source "package/dvbsnoop/Config.in"
diff --git a/package/dt-utils/Config.in b/package/dt-utils/Config.in
new file mode 100644
index 000000000..3cf4681d6
--- /dev/null
+++ b/package/dt-utils/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_DT_UTILS
+	bool "dt-utils"
+	depends on BR2_PACKAGE_HAS_UDEV
+	help
+	  Tools for flattened device-tree dumping and barebox state
+	  manipulation.
+
+	  https://git.pengutronix.de/cgit/tools/dt-utils/
diff --git a/package/dt-utils/dt-utils.mk b/package/dt-utils/dt-utils.mk
new file mode 100644
index 000000000..d7c053ac1
--- /dev/null
+++ b/package/dt-utils/dt-utils.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# dt-utils
+#
+################################################################################
+
+DT_UTILS_VERSION = v2017.03.0
+DT_UTILS_SITE = https://git.pengutronix.de/git/tools/dt-utils
+DT_UTILS_SITE_METHOD = git
+DT_UTILS_LICENSE = GPLv2
+DT_UTILS_LICENSE_FILES = COPYING
+DT_UTILS_DEPENDENCIES = udev
+DT_UTILS_AUTORECONF = YES
+
+$(eval $(autotools-package))
-- 
2.13.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/dt-utils: new package
  2017-06-20 15:24 [Buildroot] [PATCH] package/dt-utils: new package Marcin Niestroj
@ 2017-06-21 20:23 ` Thomas Petazzoni
  2017-06-21 20:24   ` Thomas Petazzoni
  2017-06-23 10:37   ` Marcin Niestroj
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-06-21 20:23 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 20 Jun 2017 17:24:43 +0200, Marcin Niestroj wrote:
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> ---
>  DEVELOPERS                   |  1 +
>  package/Config.in            |  1 +
>  package/dt-utils/Config.in   |  8 ++++++++
>  package/dt-utils/dt-utils.mk | 15 +++++++++++++++
>  4 files changed, 25 insertions(+)
>  create mode 100644 package/dt-utils/Config.in
>  create mode 100644 package/dt-utils/dt-utils.mk

This package doesn't build with the following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.05-444-g6c704ba.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_DT_UTILS=y
# BR2_TARGET_ROOTFS_TAR is not set


> diff --git a/package/dt-utils/Config.in b/package/dt-utils/Config.in
> new file mode 100644
> index 000000000..3cf4681d6
> --- /dev/null
> +++ b/package/dt-utils/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_DT_UTILS
> +	bool "dt-utils"
> +	depends on BR2_PACKAGE_HAS_UDEV
> +	help
> +	  Tools for flattened device-tree dumping and barebox state
> +	  manipulation.
> +
> +	  https://git.pengutronix.de/cgit/tools/dt-utils/

You need to add a Config.in comment here about the udev dependency.
Grep around in the Buildroot tree to see the proper formatting for such
dependencies.

> +DT_UTILS_VERSION = v2017.03.0
> +DT_UTILS_SITE = https://git.pengutronix.de/git/tools/dt-utils
> +DT_UTILS_SITE_METHOD = git
> +DT_UTILS_LICENSE = GPLv2

Please use SPDX license codes, so GPL-2.0.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/dt-utils: new package
  2017-06-21 20:23 ` Thomas Petazzoni
@ 2017-06-21 20:24   ` Thomas Petazzoni
  2017-06-23 10:37   ` Marcin Niestroj
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-06-21 20:24 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 21 Jun 2017 22:23:26 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 20 Jun 2017 17:24:43 +0200, Marcin Niestroj wrote:
> > Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> > ---
> >  DEVELOPERS                   |  1 +
> >  package/Config.in            |  1 +
> >  package/dt-utils/Config.in   |  8 ++++++++
> >  package/dt-utils/dt-utils.mk | 15 +++++++++++++++
> >  4 files changed, 25 insertions(+)
> >  create mode 100644 package/dt-utils/Config.in
> >  create mode 100644 package/dt-utils/dt-utils.mk  
> 
> This package doesn't build with the following defconfig:
> 
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.05-444-g6c704ba.tar.bz2"
> BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
> BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
> BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
> # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
> BR2_TOOLCHAIN_EXTERNAL_CXX=y
> BR2_INIT_NONE=y
> BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_DT_UTILS=y
> # BR2_TARGET_ROOTFS_TAR is not set

Sorry, forgot to give the error message:

  CC       src/fdtdump-fdtdump.o
  GEN      src/libdt-utils.pc
In file included from ./src/dt/list.h:4:0,
                 from ./src/dt/dt.h:5,
                 from src/dtblint-imx-pinmux.c:13:
./src/dt/common.h:181:22: error: static declaration of ?strlcpy? follows non-static declaration
 static inline size_t strlcpy(char *dest, const char *src, size_t size)
                      ^
In file included from ./src/dt/common.h:11:0,
                 from ./src/dt/list.h:4,
                 from ./src/dt/dt.h:5,
                 from src/dtblint-imx-pinmux.c:13:
/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/string.h:424:15: note: previous declaration of ?strlcpy? was here
 extern size_t strlcpy(char *__restrict dst, const char *__restrict src,
               ^

(several times)

Could you fix those issues, and send an updated version?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/dt-utils: new package
  2017-06-21 20:23 ` Thomas Petazzoni
  2017-06-21 20:24   ` Thomas Petazzoni
@ 2017-06-23 10:37   ` Marcin Niestroj
  1 sibling, 0 replies; 4+ messages in thread
From: Marcin Niestroj @ 2017-06-23 10:37 UTC (permalink / raw)
  To: buildroot

Hi,

On 21.06.2017 22:23, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 20 Jun 2017 17:24:43 +0200, Marcin Niestroj wrote:
>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>> ---
>>   DEVELOPERS                   |  1 +
>>   package/Config.in            |  1 +
>>   package/dt-utils/Config.in   |  8 ++++++++
>>   package/dt-utils/dt-utils.mk | 15 +++++++++++++++
>>   4 files changed, 25 insertions(+)
>>   create mode 100644 package/dt-utils/Config.in
>>   create mode 100644 package/dt-utils/dt-utils.mk
> 
> This package doesn't build with the following defconfig:

Thanks for spotting that. I've only tested this package with glibc
library. Looks like this package also didn't build with musl.

> 
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.05-444-g6c704ba.tar.bz2"
> BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
> BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
> BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
> # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
> BR2_TOOLCHAIN_EXTERNAL_CXX=y
> BR2_INIT_NONE=y
> BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_DT_UTILS=y
> # BR2_TARGET_ROOTFS_TAR is not set
> 


-- 
Marcin Niestroj

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-23 10:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-20 15:24 [Buildroot] [PATCH] package/dt-utils: new package Marcin Niestroj
2017-06-21 20:23 ` Thomas Petazzoni
2017-06-21 20:24   ` Thomas Petazzoni
2017-06-23 10:37   ` Marcin Niestroj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.