All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: pressure: st_pressure_core: disable multiread by default for LPS22HB
@ 2017-06-22 17:46 Lorenzo Bianconi
  2017-06-24 19:46 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2017-06-22 17:46 UTC (permalink / raw)
  To: jic23; +Cc: gregor.boirie, linux-iio, lorenzo.bianconi

Set multiread variable to false for LPS22HB pressure sensor since
it is already enabled in CTRL_REG2. Previous configuration does not
cause any issue in I2C communication since SUB Msb has no meaning
whereas it breaks register address in SPI communication

Fixes: e039e2f5b4da (iio:st_pressure:initial lps22hb sensor support)
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
---
 drivers/iio/pressure/st_pressure_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
index aa61ec15c139..f1bce05ffa13 100644
--- a/drivers/iio/pressure/st_pressure_core.c
+++ b/drivers/iio/pressure/st_pressure_core.c
@@ -456,7 +456,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
 			.mask_od = 0x40,
 			.addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,
 		},
-		.multi_read_bit = true,
+		.multi_read_bit = false,
 		.bootime = 2,
 	},
 };
-- 
2.13.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: pressure: st_pressure_core: disable multiread by default for LPS22HB
  2017-06-22 17:46 [PATCH] iio: pressure: st_pressure_core: disable multiread by default for LPS22HB Lorenzo Bianconi
@ 2017-06-24 19:46 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-06-24 19:46 UTC (permalink / raw)
  To: Lorenzo Bianconi; +Cc: gregor.boirie, linux-iio, lorenzo.bianconi

On Thu, 22 Jun 2017 19:46:43 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:

> Set multiread variable to false for LPS22HB pressure sensor since
> it is already enabled in CTRL_REG2. Previous configuration does not
> cause any issue in I2C communication since SUB Msb has no meaning
> whereas it breaks register address in SPI communication
> 
> Fixes: e039e2f5b4da (iio:st_pressure:initial lps22hb sensor support)
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
This will probably only go upstream after the merge window now.

Jonathan

> ---
>  drivers/iio/pressure/st_pressure_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
> index aa61ec15c139..f1bce05ffa13 100644
> --- a/drivers/iio/pressure/st_pressure_core.c
> +++ b/drivers/iio/pressure/st_pressure_core.c
> @@ -456,7 +456,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
>  			.mask_od = 0x40,
>  			.addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,
>  		},
> -		.multi_read_bit = true,
> +		.multi_read_bit = false,
>  		.bootime = 2,
>  	},
>  };


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-24 19:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 17:46 [PATCH] iio: pressure: st_pressure_core: disable multiread by default for LPS22HB Lorenzo Bianconi
2017-06-24 19:46 ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.