All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>, Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <keith.busch@intel.com>,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] nvme: allocate queues for all possible CPUs
Date: Mon, 26 Jun 2017 12:20:58 +0200	[thread overview]
Message-ID: <20170626102058.10200-4-hch@lst.de> (raw)
In-Reply-To: <20170626102058.10200-1-hch@lst.de>

Unlike most drіvers that simply pass the maximum possible vectors to
pci_alloc_irq_vectors NVMe needs to configure the device before allocting
the vectors, so it needs a manual update for the new scheme of using
all present CPUs.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 951042a375d6..b3dcd7abc6d7 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1525,7 +1525,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
 	struct pci_dev *pdev = to_pci_dev(dev->dev);
 	int result, nr_io_queues, size;
 
-	nr_io_queues = num_online_cpus();
+	nr_io_queues = num_present_cpus();
 	result = nvme_set_queue_count(&dev->ctrl, &nr_io_queues);
 	if (result < 0)
 		return result;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme: allocate queues for all possible CPUs
Date: Mon, 26 Jun 2017 12:20:58 +0200	[thread overview]
Message-ID: <20170626102058.10200-4-hch@lst.de> (raw)
In-Reply-To: <20170626102058.10200-1-hch@lst.de>

Unlike most dr?vers that simply pass the maximum possible vectors to
pci_alloc_irq_vectors NVMe needs to configure the device before allocting
the vectors, so it needs a manual update for the new scheme of using
all present CPUs.

Signed-off-by: Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 951042a375d6..b3dcd7abc6d7 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1525,7 +1525,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
 	struct pci_dev *pdev = to_pci_dev(dev->dev);
 	int result, nr_io_queues, size;
 
-	nr_io_queues = num_online_cpus();
+	nr_io_queues = num_present_cpus();
 	result = nvme_set_queue_count(&dev->ctrl, &nr_io_queues);
 	if (result < 0)
 		return result;
-- 
2.11.0

  parent reply	other threads:[~2017-06-26 10:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26 10:20 block: spread MSI(-X) vectors to all possible CPUs Christoph Hellwig
2017-06-26 10:20 ` Christoph Hellwig
2017-06-26 10:20 ` [PATCH 1/3] blk-mq: include all present CPUs in the default queue mapping Christoph Hellwig
2017-06-26 10:20   ` Christoph Hellwig
2017-06-28 21:03   ` [tip:irq/core] blk-mq: Include " tip-bot for Christoph Hellwig
2017-07-02 17:47   ` [PATCH 1/3] blk-mq: include " Sagi Grimberg
2017-07-02 17:47     ` Sagi Grimberg
2017-06-26 10:20 ` [PATCH 2/3] blk-mq: create hctx for each present CPU Christoph Hellwig
2017-06-26 10:20   ` Christoph Hellwig
2017-06-28 21:04   ` [tip:irq/core] blk-mq: Create " tip-bot for Christoph Hellwig
2017-07-02 17:47   ` [PATCH 2/3] blk-mq: create " Sagi Grimberg
2017-07-02 17:47     ` Sagi Grimberg
2017-06-26 10:20 ` Christoph Hellwig [this message]
2017-06-26 10:20   ` [PATCH 3/3] nvme: allocate queues for all possible CPUs Christoph Hellwig
2017-06-28 21:05   ` [tip:irq/core] nvme: Allocate " tip-bot for Christoph Hellwig
2017-07-02 17:47   ` [PATCH 3/3] nvme: allocate " Sagi Grimberg
2017-07-02 17:47     ` Sagi Grimberg
2017-06-27 18:24 ` block: spread MSI(-X) vectors to " Jens Axboe
2017-06-27 18:24   ` Jens Axboe
2017-07-03 10:49   ` Max Gurtovoy
2017-07-03 10:49     ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626102058.10200-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.