All of lore.kernel.org
 help / color / mirror / Atom feed
* [kees:for-next/fortify 8/8] include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
@ 2017-06-25  1:16 kbuild test robot
  2017-06-26 21:45 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2017-06-25  1:16 UTC (permalink / raw)
  To: Daniel Micay
  Cc: kbuild-all, Kees Cook, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/fortify
head:   d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
commit: d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282 [8/8] include/linux/string.h: add the option of fortified string.h functions
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/page_32.h:34:0,
                    from arch/x86/include/asm/page.h:13,
                    from arch/x86/include/asm/thread_info.h:11,
                    from include/linux/thread_info.h:37,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:80,
                    from include/linux/spinlock.h:50,
                    from include/linux/mmzone.h:7,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:14,
                    from drivers/scsi/csiostor/csio_lnode.c:37:
   In function 'memcpy',
       inlined from 'csio_append_attrib' at drivers/scsi/csiostor/csio_lnode.c:248:2,
       inlined from 'csio_ln_fdmi_dprt_cbfn' at drivers/scsi/csiostor/csio_lnode.c:471:2:
>> include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
       __read_overflow2();
       ^~~~~~~~~~~~~~~~~~
   In function 'memcpy',
       inlined from 'csio_append_attrib' at drivers/scsi/csiostor/csio_lnode.c:248:2,
       inlined from 'csio_ln_fdmi_rhba_cbfn' at drivers/scsi/csiostor/csio_lnode.c:337:2:
>> include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
       __read_overflow2();
       ^~~~~~~~~~~~~~~~~~

vim +/__read_overflow2 +309 include/linux/string.h

   303		size_t p_size = __builtin_object_size(p, 0);
   304		size_t q_size = __builtin_object_size(q, 0);
   305		if (__builtin_constant_p(size)) {
   306			if (p_size < size)
   307				__write_overflow();
   308			if (q_size < size)
 > 309				__read_overflow2();
   310		}
   311		if (p_size < size || q_size < size)
   312			fortify_panic(__func__);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60187 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kees:for-next/fortify 8/8] include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
  2017-06-25  1:16 [kees:for-next/fortify 8/8] include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter kbuild test robot
@ 2017-06-26 21:45 ` Andrew Morton
  2017-06-26 21:52   ` Daniel Micay
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2017-06-26 21:45 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Daniel Micay, kbuild-all, Kees Cook, Linux Memory Management List

On Sun, 25 Jun 2017 09:16:32 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/fortify
> head:   d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
> commit: d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282 [8/8] include/linux/string.h: add the option of fortified string.h functions
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from arch/x86/include/asm/page_32.h:34:0,
>                     from arch/x86/include/asm/page.h:13,
>                     from arch/x86/include/asm/thread_info.h:11,
>                     from include/linux/thread_info.h:37,
>                     from arch/x86/include/asm/preempt.h:6,
>                     from include/linux/preempt.h:80,
>                     from include/linux/spinlock.h:50,
>                     from include/linux/mmzone.h:7,
>                     from include/linux/gfp.h:5,
>                     from include/linux/slab.h:14,
>                     from drivers/scsi/csiostor/csio_lnode.c:37:
>    In function 'memcpy',
>        inlined from 'csio_append_attrib' at drivers/scsi/csiostor/csio_lnode.c:248:2,

hm, this was added by Kees's 42c335f7e6702 ("scsi: csiostor: Avoid
content leaks and casts").

I think I'll tend to ignore these odd stragglers now - a few more will
probably pop up and we can fix them after 4.13-rc1 as they are
reported.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kees:for-next/fortify 8/8] include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
  2017-06-26 21:45 ` Andrew Morton
@ 2017-06-26 21:52   ` Daniel Micay
  2017-06-26 21:55     ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Micay @ 2017-06-26 21:52 UTC (permalink / raw)
  To: Andrew Morton, kbuild test robot
  Cc: kbuild-all, Kees Cook, Linux Memory Management List

On Mon, 2017-06-26 at 14:45 -0700, Andrew Morton wrote:
> On Sun, 25 Jun 2017 09:16:32 +0800 kbuild test robot <fengguang.wu@int
> el.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.g
> > it for-next/fortify
> > head:   d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
> > commit: d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282 [8/8]
> > include/linux/string.h: add the option of fortified string.h
> > functions
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         git checkout d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from arch/x86/include/asm/page_32.h:34:0,
> >                     from arch/x86/include/asm/page.h:13,
> >                     from arch/x86/include/asm/thread_info.h:11,
> >                     from include/linux/thread_info.h:37,
> >                     from arch/x86/include/asm/preempt.h:6,
> >                     from include/linux/preempt.h:80,
> >                     from include/linux/spinlock.h:50,
> >                     from include/linux/mmzone.h:7,
> >                     from include/linux/gfp.h:5,
> >                     from include/linux/slab.h:14,
> >                     from drivers/scsi/csiostor/csio_lnode.c:37:
> >    In function 'memcpy',
> >        inlined from 'csio_append_attrib' at
> > drivers/scsi/csiostor/csio_lnode.c:248:2,
> 
> hm, this was added by Kees's 42c335f7e6702 ("scsi: csiostor: Avoid
> content leaks and casts").
> 
> I think I'll tend to ignore these odd stragglers now - a few more will
> probably pop up and we can fix them after 4.13-rc1 as they are
> reported.

It's in the scsi for-next tree. The issue that we ran into with fortify
in the kspp tree was that scsi was merged into next after it so tests
still ran into this. I assume that for 4.13-rc1 they'll both be merged
so there shouldn't be a problem then. I'm not very familiar with how the
workflow works or how issues like this should be handled.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kees:for-next/fortify 8/8] include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
  2017-06-26 21:52   ` Daniel Micay
@ 2017-06-26 21:55     ` Andrew Morton
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2017-06-26 21:55 UTC (permalink / raw)
  To: Daniel Micay
  Cc: kbuild test robot, kbuild-all, Kees Cook, Linux Memory Management List

On Mon, 26 Jun 2017 17:52:30 -0400 Daniel Micay <danielmicay@gmail.com> wrote:

> On Mon, 2017-06-26 at 14:45 -0700, Andrew Morton wrote:
> > On Sun, 25 Jun 2017 09:16:32 +0800 kbuild test robot <fengguang.wu@int
> > el.com> wrote:
> > 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.g
> > > it for-next/fortify
> > > head:   d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
> > > commit: d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282 [8/8]
> > > include/linux/string.h: add the option of fortified string.h
> > > functions
> > > config: i386-allmodconfig (attached as .config)
> > > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > > reproduce:
> > >         git checkout d481d95b725d2abc7ed31f2f8c4c95c2bd8b0282
> > >         # save the attached .config to linux build tree
> > >         make ARCH=i386 
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    In file included from arch/x86/include/asm/page_32.h:34:0,
> > >                     from arch/x86/include/asm/page.h:13,
> > >                     from arch/x86/include/asm/thread_info.h:11,
> > >                     from include/linux/thread_info.h:37,
> > >                     from arch/x86/include/asm/preempt.h:6,
> > >                     from include/linux/preempt.h:80,
> > >                     from include/linux/spinlock.h:50,
> > >                     from include/linux/mmzone.h:7,
> > >                     from include/linux/gfp.h:5,
> > >                     from include/linux/slab.h:14,
> > >                     from drivers/scsi/csiostor/csio_lnode.c:37:
> > >    In function 'memcpy',
> > >        inlined from 'csio_append_attrib' at
> > > drivers/scsi/csiostor/csio_lnode.c:248:2,
> > 
> > hm, this was added by Kees's 42c335f7e6702 ("scsi: csiostor: Avoid
> > content leaks and casts").
> > 
> > I think I'll tend to ignore these odd stragglers now - a few more will
> > probably pop up and we can fix them after 4.13-rc1 as they are
> > reported.
> 
> It's in the scsi for-next tree. The issue that we ran into with fortify
> in the kspp tree was that scsi was merged into next after it so tests
> still ran into this. I assume that for 4.13-rc1 they'll both be merged
> so there shouldn't be a problem then. I'm not very familiar with how the
> workflow works or how issues like this should be handled.

I've staged this patchset after all the linux-next trees, so during the
merge window I'll be waiting until all the depended-upon trees have
merged before sending this series into Linus.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-26 21:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-25  1:16 [kees:for-next/fortify 8/8] include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter kbuild test robot
2017-06-26 21:45 ` Andrew Morton
2017-06-26 21:52   ` Daniel Micay
2017-06-26 21:55     ` Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.