All of lore.kernel.org
 help / color / mirror / Atom feed
From: <laurentiu.tudor@nxp.com>
To: <gregkh@linuxfoundation.org>, <stuyoder@gmail.com>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
	<marc.zyngier@arm.com>, <agraf@suse.de>, <arnd@arndb.de>,
	<ioana.ciornei@nxp.com>, <ruxandra.radulescu@nxp.com>,
	<bharat.bhushan@nxp.com>, <catalin.horghidan@nxp.com>,
	<leoyang.li@nxp.com>, <roy.pledge@nxp.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call
Date: Tue, 27 Jun 2017 17:41:21 +0300	[thread overview]
Message-ID: <20170627144135.15599-2-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170627144135.15599-1-laurentiu.tudor@nxp.com>

From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
v2:
 - new patch

 drivers/staging/fsl-mc/bus/dprc-driver.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 80c080f..1765e2d 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,8 +29,9 @@ struct dprc_child_objs {
 static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
 				struct dprc_obj_desc *obj_desc)
 {
-	return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
-		mc_dev->obj_desc.id == obj_desc->id;
+	return mc_dev->obj_desc.id == obj_desc->id &&
+	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+
 }
 
 static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)
-- 
2.9.4

WARNING: multiple messages have this Message-ID (diff)
From: laurentiu.tudor@nxp.com (laurentiu.tudor at nxp.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call
Date: Tue, 27 Jun 2017 17:41:21 +0300	[thread overview]
Message-ID: <20170627144135.15599-2-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170627144135.15599-1-laurentiu.tudor@nxp.com>

From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
v2:
 - new patch

 drivers/staging/fsl-mc/bus/dprc-driver.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 80c080f..1765e2d 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,8 +29,9 @@ struct dprc_child_objs {
 static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
 				struct dprc_obj_desc *obj_desc)
 {
-	return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
-		mc_dev->obj_desc.id == obj_desc->id;
+	return mc_dev->obj_desc.id == obj_desc->id &&
+	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+
 }
 
 static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)
-- 
2.9.4

  reply	other threads:[~2017-06-27 14:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 14:41 [PATCH v2 00/15] staging: fsl-mc: clean up header files laurentiu.tudor
2017-06-27 14:41 ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` laurentiu.tudor [this message]
2017-06-27 14:41   ` [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 02/15] staging: fsl-mc: be consistent when checking strcmp() return laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 03/15] staging: fsl-mc: drop useless #includes laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 04/15] staging: fsl-mc: decouple the mc-bus public headers from dprc.h laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 05/15] staging: fsl-mc: delete duplicated function prototypes laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 06/15] staging: fsl-mc: delete prototype of unimplemented function laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 07/15] staging: fsl-mc: turn several exported functions static laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 08/15] staging: fsl-mc: move irq domain creation prototype to public header laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 09/15] staging: fsl-mc: move couple of definitions " laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 10/15] staging: fsl-mc: move rest of mc-bus.h to private header laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 11/15] staging: fsl-mc: remove dpmng API files laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 12/15] staging: fsl-mc: fix a few implicit includes laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 13/15] staging: fsl-mc: move mc-sys.h contents in the public header laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 14/15] staging: fsl-mc: move mc-cmd.h " laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 14:41 ` [PATCH v2 15/15] staging: fsl-mc: make dprc.h header private laurentiu.tudor
2017-06-27 14:41   ` laurentiu.tudor at nxp.com
2017-06-27 15:33 ` [PATCH v2 00/15] staging: fsl-mc: clean up header files Arnd Bergmann
2017-06-27 15:33   ` Arnd Bergmann
2017-06-27 16:00   ` gregkh
2017-06-27 16:00     ` gregkh
2017-06-27 20:21     ` Arnd Bergmann
2017-06-27 20:21       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627144135.15599-2-laurentiu.tudor@nxp.com \
    --to=laurentiu.tudor@nxp.com \
    --cc=agraf@suse.de \
    --cc=arnd@arndb.de \
    --cc=bharat.bhushan@nxp.com \
    --cc=catalin.horghidan@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=roy.pledge@nxp.com \
    --cc=ruxandra.radulescu@nxp.com \
    --cc=stuyoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.