[Buildroot] [PATCH 1/2] .gitlab-ci.yml: regenerate

[Buildroot] [PATCH 1/2] .gitlab-ci.yml: regenerate

[Arnout Vandecappelle]

engicam_imx6ul_isiot_defconfig was added in commit 0235bc6176, but it
should have been engicam_imx6ul_isiot_mmc_defconfig.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 1f2410e862..38eaf89d19 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -92,7 +92,7 @@ cubieboard2_defconfig: *defconfig
 engicam_imx6qdl_icore_defconfig: *defconfig
 engicam_imx6qdl_icore_rqs_defconfig: *defconfig
 engicam_imx6ul_geam_defconfig: *defconfig
-engicam_imx6ul_isiot_defconfig: *defconfig
+engicam_imx6ul_isiot_mmc_defconfig: *defconfig
 firefly_rk3288_defconfig: *defconfig
 firefly_rk3288_demo_defconfig: *defconfig
 freescale_imx28evk_defconfig: *defconfig
-- 
2.13.1

[Buildroot] [PATCH 2/2] Makefile: regenerat .gitlab-ci.yml when configs/ directory changes

[Arnout Vandecappelle]

The dependencies were not correct. For example, if a defconfig is
removed, the .gitlab-ci.yml file has to be regenerated but the
dependency doesn't reflect this. Therefore, it should depend on the
configs directory instead of on the individual defconfig files.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
I have an intuition that using a directory as a dependency is less
reliable, but I did some testing (renaming defconfigs, adding, removing)
and it seems to work fine.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 88d98e0405..e4d9e60fae 100644
--- a/Makefile
+++ b/Makefile
@@ -1098,7 +1098,7 @@ release:
 print-version:
 	@echo $(BR2_VERSION_FULL)
 
-.gitlab-ci.yml: .gitlab-ci.yml.in configs/*_defconfig
+.gitlab-ci.yml: .gitlab-ci.yml.in configs
 	(cd configs; LC_ALL=C ls -1 *_defconfig) | sed 's/$$/: *defconfig/' | cat $< - > $@
 
 include docs/manual/manual.mk
-- 
2.13.1

[Buildroot] [PATCH 1/2] .gitlab-ci.yml: regenerate

[Jagan Teki]

On Wed, Jun 28, 2017 at 12:02 AM, Arnout Vandecappelle
(Essensium/Mind) <arnout@mind.be> wrote:
> engicam_imx6ul_isiot_defconfig was added in commit 0235bc6176, but it
> should have been engicam_imx6ul_isiot_mmc_defconfig.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 1f2410e862..38eaf89d19 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -92,7 +92,7 @@ cubieboard2_defconfig: *defconfig
>  engicam_imx6qdl_icore_defconfig: *defconfig
>  engicam_imx6qdl_icore_rqs_defconfig: *defconfig
>  engicam_imx6ul_geam_defconfig: *defconfig
> -engicam_imx6ul_isiot_defconfig: *defconfig
> +engicam_imx6ul_isiot_mmc_defconfig: *defconfig

This shouldn't be _mmc, will fix and send the patch.

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.