[Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies

[Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies

[Bartosz Golaszewski]

Qt5Multimedia conditionally builds support for pulseaudio and alsa if
it detects corresponding libraries in the system but we need to
explicitly depend on these packages.

v1 -> v2:
- also added libglib2 as dependency for pulseaudio support
- new patch: add alsa to dependencies

Bartosz Golaszewski (2):
  qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies
  qt5multimedia: conditionally add alsa-lib to dependencies

 package/qt5/qt5multimedia/qt5multimedia.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.9.3

[Buildroot] [PATCH v2 1/2] qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies

[Bartosz Golaszewski]

Qt5Multimedia includes support for pulseaudio if it detects libpulse
and libpulse-mainloop-glib in the system at build-time. We need to
depend on pulseaudio and libglib2 if it is selected.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 package/qt5/qt5multimedia/qt5multimedia.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/qt5/qt5multimedia/qt5multimedia.mk b/package/qt5/qt5multimedia/qt5multimedia.mk
index 133536e..19312ff 100644
--- a/package/qt5/qt5multimedia/qt5multimedia.mk
+++ b/package/qt5/qt5multimedia/qt5multimedia.mk
@@ -26,6 +26,10 @@ ifeq ($(BR2_PACKAGE_QT5DECLARATIVE),y)
 QT5MULTIMEDIA_DEPENDENCIES += qt5declarative
 endif
 
+ifeq ($(BR2_PACKAGE_LIBGLIB2)$(BR2_PACKAGE_PULSEAUDIO),yy)
+QT5MULTIMEDIA_DEPENDENCIES += libglib2 pulseaudio
+endif
+
 define QT5MULTIMEDIA_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
 endef
-- 
2.9.3

[Buildroot] [PATCH v2 2/2] qt5multimedia: conditionally add alsa-lib to dependencies

[Bartosz Golaszewski]

Qt5Multimedia builds the alsa plugin if it detects libasound in the
system. Add alsa-lib to dependencies if BR2_PACKAGE_ALSA_LIB is
selected.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 package/qt5/qt5multimedia/qt5multimedia.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/qt5/qt5multimedia/qt5multimedia.mk b/package/qt5/qt5multimedia/qt5multimedia.mk
index 19312ff..062d980 100644
--- a/package/qt5/qt5multimedia/qt5multimedia.mk
+++ b/package/qt5/qt5multimedia/qt5multimedia.mk
@@ -30,6 +30,10 @@ ifeq ($(BR2_PACKAGE_LIBGLIB2)$(BR2_PACKAGE_PULSEAUDIO),yy)
 QT5MULTIMEDIA_DEPENDENCIES += libglib2 pulseaudio
 endif
 
+ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
+QT5MULTIMEDIA_DEPENDENCIES += alsa-lib
+endif
+
 define QT5MULTIMEDIA_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
 endef
-- 
2.9.3

[Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies

[Bartosz Golaszewski]

2017-06-27 9:53 GMT+02:00 Bartosz Golaszewski <brgl@bgdev.pl>:
> Qt5Multimedia conditionally builds support for pulseaudio and alsa if
> it detects corresponding libraries in the system but we need to
> explicitly depend on these packages.
>
> v1 -> v2:
> - also added libglib2 as dependency for pulseaudio support
> - new patch: add alsa to dependencies
>
> Bartosz Golaszewski (2):
>   qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies
>   qt5multimedia: conditionally add alsa-lib to dependencies
>
>  package/qt5/qt5multimedia/qt5multimedia.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> --
> 2.9.3
>

Wanted to CC Peter Seiderer, not Peter Korsgaard.

Thanks,
Bartosz

[Buildroot] [PATCH v2 1/2] qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies

[Peter Seiderer]

On Tue, 27 Jun 2017 09:53:08 +0200, Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> Qt5Multimedia includes support for pulseaudio if it detects libpulse
> and libpulse-mainloop-glib in the system at build-time. We need to
> depend on pulseaudio and libglib2 if it is selected.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
>  package/qt5/qt5multimedia/qt5multimedia.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/qt5/qt5multimedia/qt5multimedia.mk b/package/qt5/qt5multimedia/qt5multimedia.mk
> index 133536e..19312ff 100644
> --- a/package/qt5/qt5multimedia/qt5multimedia.mk
> +++ b/package/qt5/qt5multimedia/qt5multimedia.mk
> @@ -26,6 +26,10 @@ ifeq ($(BR2_PACKAGE_QT5DECLARATIVE),y)
>  QT5MULTIMEDIA_DEPENDENCIES += qt5declarative
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBGLIB2)$(BR2_PACKAGE_PULSEAUDIO),yy)
> +QT5MULTIMEDIA_DEPENDENCIES += libglib2 pulseaudio
> +endif
> +
>  define QT5MULTIMEDIA_CONFIGURE_CMDS
>  	(cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
>  endef

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

[Buildroot] [PATCH v2 2/2] qt5multimedia: conditionally add alsa-lib to dependencies

[Peter Seiderer]

Hello Bartoz,

On Tue, 27 Jun 2017 09:53:09 +0200, Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> Qt5Multimedia builds the alsa plugin if it detects libasound in the
> system. Add alsa-lib to dependencies if BR2_PACKAGE_ALSA_LIB is
> selected.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
>  package/qt5/qt5multimedia/qt5multimedia.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/qt5/qt5multimedia/qt5multimedia.mk b/package/qt5/qt5multimedia/qt5multimedia.mk
> index 19312ff..062d980 100644
> --- a/package/qt5/qt5multimedia/qt5multimedia.mk
> +++ b/package/qt5/qt5multimedia/qt5multimedia.mk
> @@ -30,6 +30,10 @@ ifeq ($(BR2_PACKAGE_LIBGLIB2)$(BR2_PACKAGE_PULSEAUDIO),yy)
>  QT5MULTIMEDIA_DEPENDENCIES += libglib2 pulseaudio
>  endif
>  
> +ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
> +QT5MULTIMEDIA_DEPENDENCIES += alsa-lib
> +endif
> +
>  define QT5MULTIMEDIA_CONFIGURE_CMDS
>  	(cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
>  endef

Thanks for taking care of it...

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

[Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies

[Thomas Petazzoni]

Hello,

On Tue, 27 Jun 2017 09:53:07 +0200, Bartosz Golaszewski wrote:

> Bartosz Golaszewski (2):
>   qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies
>   qt5multimedia: conditionally add alsa-lib to dependencies

Both applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v2 0/2] qt5multimedia: add missing dependencies

[Peter Korsgaard]

>>>>> "Bartosz" == Bartosz Golaszewski <brgl@bgdev.pl> writes:

 > Qt5Multimedia conditionally builds support for pulseaudio and alsa if
 > it detects corresponding libraries in the system but we need to
 > explicitly depend on these packages.

 > v1 -> v2:
 > - also added libglib2 as dependency for pulseaudio support
 > - new patch: add alsa to dependencies

 > Bartosz Golaszewski (2):
 >   qt5multimedia: conditionally add pulseaudio & libglib2 to dependencies
 >   qt5multimedia: conditionally add alsa-lib to dependencies

Committed both to 2017.02.x and 2017.05.x, thanks.

-- 
Bye, Peter Korsgaard