* [PATCH 0/1] fix ls-remote help message
@ 2017-06-27 20:34 Silvio Fricke
2017-06-27 20:34 ` [PATCH 1/1] ls-remote: remove "-h" from help text Silvio Fricke
0 siblings, 1 reply; 4+ messages in thread
From: Silvio Fricke @ 2017-06-27 20:34 UTC (permalink / raw)
To: git; +Cc: Silvio Fricke
Hi,
a small patch about a wrong help text. Please include when okay.
Best Regards,
Silvio
Silvio Fricke (1):
ls-remote: remove "-h" from help text
builtin/ls-remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.13.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ls-remote: remove "-h" from help text
2017-06-27 20:34 [PATCH 0/1] fix ls-remote help message Silvio Fricke
@ 2017-06-27 20:34 ` Silvio Fricke
2017-06-27 21:09 ` Jonathan Nieder
0 siblings, 1 reply; 4+ messages in thread
From: Silvio Fricke @ 2017-06-27 20:34 UTC (permalink / raw)
To: git; +Cc: Silvio Fricke
This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is
asking for help") and the wrong help text was introduced in ba5f28bf79ea
("ls-remote: use parse-options api").
This patch removes the "-h" on the help text.
Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
---
builtin/ls-remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
index b2d7d5ce6..cd54f7e98 100644
--- a/builtin/ls-remote.c
+++ b/builtin/ls-remote.c
@@ -56,7 +56,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
N_("path of git-upload-pack on the remote host"),
PARSE_OPT_HIDDEN },
OPT_BIT('t', "tags", &flags, N_("limit to tags"), REF_TAGS),
- OPT_BIT('h', "heads", &flags, N_("limit to heads"), REF_HEADS),
+ OPT_BIT(0, "heads", &flags, N_("limit to heads"), REF_HEADS),
OPT_BIT(0, "refs", &flags, N_("do not show peeled tags"), REF_NORMAL),
OPT_BOOL(0, "get-url", &get_url,
N_("take url.<base>.insteadOf into account")),
--
2.13.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ls-remote: remove "-h" from help text
2017-06-27 20:34 ` [PATCH 1/1] ls-remote: remove "-h" from help text Silvio Fricke
@ 2017-06-27 21:09 ` Jonathan Nieder
2017-06-28 9:34 ` S. Fricke
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Nieder @ 2017-06-27 21:09 UTC (permalink / raw)
To: Silvio Fricke; +Cc: git
Hi,
Silvio Fricke wrote:
> This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is
> asking for help") and the wrong help text was introduced in ba5f28bf79ea
> ("ls-remote: use parse-options api").
> This patch removes the "-h" on the help text.
>
> Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
> ---
> builtin/ls-remote.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Without this patch, I'm able to run
git ls-remote -h .
This patch removes that support. Intended?
Thanks and hope that helps,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ls-remote: remove "-h" from help text
2017-06-27 21:09 ` Jonathan Nieder
@ 2017-06-28 9:34 ` S. Fricke
0 siblings, 0 replies; 4+ messages in thread
From: S. Fricke @ 2017-06-28 9:34 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: git
Hi Jonathan,
> > This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is
> > [...]
>
> Without this patch, I'm able to run
>
> git ls-remote -h .
>
> This patch removes that support. Intended?
*hihi* okay it was to counter-intuitive for me. "91a640ffb6d" talks about this
issue.
Thanks for enlightenment :-)
Silvio
--
-- S. Fricke ---------------------------------------- silvio@port1024.net --
Diplom-Informatiker (FH)
Linux-Development Matrix: @silvio:port1024.net
----------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-28 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 20:34 [PATCH 0/1] fix ls-remote help message Silvio Fricke
2017-06-27 20:34 ` [PATCH 1/1] ls-remote: remove "-h" from help text Silvio Fricke
2017-06-27 21:09 ` Jonathan Nieder
2017-06-28 9:34 ` S. Fricke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.