From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Andrey Ryabinin <aryabinin@virtuozzo.com>, Ingo Molnar <mingo@kernel.org> Cc: Dmitry Vyukov <dvyukov@google.com>, Mark Rutland <mark.rutland@arm.com>, Peter Zijlstra <peterz@infradead.org>, Will Deacon <will.deacon@arm.com>, "H. Peter Anvin" <hpa@zytor.com>, kasan-dev <kasan-dev@googlegroups.com>, "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH] locking/atomics: don't alias ____ptr Date: Wed, 28 Jun 2017 14:12:52 +0200 [thread overview] Message-ID: <20170628121246.qnk2csgzbgpqrmw3@linutronix.de> (raw) In-Reply-To: <1c1cbbfb-8e34-dd33-0e73-bbb2a758e962@virtuozzo.com> On 2017-06-28 14:15:18 [+0300], Andrey Ryabinin wrote: > The main problem here is that arch_cmpxchg64_local() calls cmpxhg_local() instead of using arch_cmpxchg_local(). > > So, the patch bellow should fix the problem, also this will fix double instrumentation of cmpcxchg64[_local](). > But I haven't tested this patch yet. tested, works. Next step? > --- > arch/x86/include/asm/cmpxchg_64.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/cmpxchg_64.h b/arch/x86/include/asm/cmpxchg_64.h > index fafaebacca2d..7046a3cc2493 100644 > --- a/arch/x86/include/asm/cmpxchg_64.h > +++ b/arch/x86/include/asm/cmpxchg_64.h > @@ -9,13 +9,13 @@ static inline void set_64bit(volatile u64 *ptr, u64 val) > #define arch_cmpxchg64(ptr, o, n) \ > ({ \ > BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ > - cmpxchg((ptr), (o), (n)); \ > + arch_cmpxchg((ptr), (o), (n)); \ > }) > > #define arch_cmpxchg64_local(ptr, o, n) \ > ({ \ > BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ > - cmpxchg_local((ptr), (o), (n)); \ > + arch_cmpxchg_local((ptr), (o), (n)); \ > }) > > #define system_has_cmpxchg_double() boot_cpu_has(X86_FEATURE_CX16) Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Andrey Ryabinin <aryabinin@virtuozzo.com>, Ingo Molnar <mingo@kernel.org> Cc: Dmitry Vyukov <dvyukov@google.com>, Mark Rutland <mark.rutland@arm.com>, Peter Zijlstra <peterz@infradead.org>, Will Deacon <will.deacon@arm.com>, "H. Peter Anvin" <hpa@zytor.com>, kasan-dev <kasan-dev@googlegroups.com>, "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH] locking/atomics: don't alias ____ptr Date: Wed, 28 Jun 2017 14:12:52 +0200 [thread overview] Message-ID: <20170628121246.qnk2csgzbgpqrmw3@linutronix.de> (raw) In-Reply-To: <1c1cbbfb-8e34-dd33-0e73-bbb2a758e962@virtuozzo.com> On 2017-06-28 14:15:18 [+0300], Andrey Ryabinin wrote: > The main problem here is that arch_cmpxchg64_local() calls cmpxhg_local() instead of using arch_cmpxchg_local(). > > So, the patch bellow should fix the problem, also this will fix double instrumentation of cmpcxchg64[_local](). > But I haven't tested this patch yet. tested, works. Next step? > --- > arch/x86/include/asm/cmpxchg_64.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/cmpxchg_64.h b/arch/x86/include/asm/cmpxchg_64.h > index fafaebacca2d..7046a3cc2493 100644 > --- a/arch/x86/include/asm/cmpxchg_64.h > +++ b/arch/x86/include/asm/cmpxchg_64.h > @@ -9,13 +9,13 @@ static inline void set_64bit(volatile u64 *ptr, u64 val) > #define arch_cmpxchg64(ptr, o, n) \ > ({ \ > BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ > - cmpxchg((ptr), (o), (n)); \ > + arch_cmpxchg((ptr), (o), (n)); \ > }) > > #define arch_cmpxchg64_local(ptr, o, n) \ > ({ \ > BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ > - cmpxchg_local((ptr), (o), (n)); \ > + arch_cmpxchg_local((ptr), (o), (n)); \ > }) > > #define system_has_cmpxchg_double() boot_cpu_has(X86_FEATURE_CX16) Sebastian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-28 12:13 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-22 14:14 [PATCH v5 0/4] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov [not found] ` <cover.1498140838.git.dvyukov@google.com> 2017-06-22 14:14 ` [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h Dmitry Vyukov 2017-06-22 14:14 ` Dmitry Vyukov 2017-06-22 21:14 ` Andrew Morton 2017-06-22 21:14 ` Andrew Morton 2017-06-23 8:23 ` Dmitry Vyukov 2017-06-23 8:23 ` Dmitry Vyukov 2017-06-23 8:54 ` Ingo Molnar 2017-06-23 8:54 ` Ingo Molnar 2017-06-23 19:00 ` Andrew Morton 2017-06-23 19:00 ` Andrew Morton 2017-06-23 13:59 ` [tip:locking/core] locking/atomic/x86: Switch " tip-bot for Dmitry Vyukov 2017-06-22 14:14 ` [PATCH v5 2/4] kasan: allow kasan_check_read/write() to accept pointers to volatiles Dmitry Vyukov 2017-06-22 14:14 ` Dmitry Vyukov 2017-06-23 14:00 ` [tip:locking/core] kasan: Allow " tip-bot for Dmitry Vyukov 2017-07-26 12:10 ` tip-bot for Dmitry Vyukov 2017-06-22 14:14 ` [PATCH v5 3/4] asm-generic: add KASAN instrumentation to atomic operations Dmitry Vyukov 2017-06-22 14:14 ` Dmitry Vyukov 2017-06-23 14:01 ` [tip:locking/core] locking/atomics, asm-generic: Add " tip-bot for Dmitry Vyukov 2017-06-28 10:02 ` [PATCH] locking/atomics: don't alias ____ptr Sebastian Andrzej Siewior 2017-06-28 10:02 ` Sebastian Andrzej Siewior 2017-06-28 10:16 ` Dmitry Vyukov 2017-06-28 10:16 ` Dmitry Vyukov 2017-06-28 11:10 ` Thomas Gleixner 2017-06-28 11:10 ` Thomas Gleixner 2017-06-28 11:12 ` Dmitry Vyukov 2017-06-28 11:12 ` Dmitry Vyukov 2017-06-28 11:21 ` Thomas Gleixner 2017-06-28 11:21 ` Thomas Gleixner 2017-06-28 12:45 ` Mark Rutland 2017-06-28 12:45 ` Mark Rutland 2017-06-28 12:24 ` Thomas Gleixner 2017-06-28 12:24 ` Thomas Gleixner 2017-06-28 12:27 ` Dmitry Vyukov 2017-06-28 12:27 ` Dmitry Vyukov 2017-06-28 13:33 ` Thomas Gleixner 2017-06-28 13:33 ` Thomas Gleixner 2017-06-28 11:15 ` Andrey Ryabinin 2017-06-28 11:15 ` Andrey Ryabinin 2017-06-28 12:12 ` Sebastian Andrzej Siewior [this message] 2017-06-28 12:12 ` Sebastian Andrzej Siewior 2017-06-28 13:20 ` Thomas Gleixner 2017-06-28 13:20 ` Thomas Gleixner 2017-06-28 13:54 ` Thomas Gleixner 2017-06-28 13:54 ` Thomas Gleixner 2017-06-28 14:14 ` Mark Rutland 2017-06-28 14:14 ` Mark Rutland 2017-06-28 15:24 ` Thomas Gleixner 2017-06-28 15:24 ` Thomas Gleixner 2017-06-28 15:54 ` Mark Rutland 2017-06-28 15:54 ` Mark Rutland 2017-06-28 16:56 ` Ingo Molnar 2017-06-28 16:56 ` Ingo Molnar 2017-06-28 18:21 ` Thomas Gleixner 2017-06-28 18:21 ` Thomas Gleixner 2017-06-29 6:47 ` Thomas Gleixner 2017-06-29 6:47 ` Thomas Gleixner 2017-06-28 14:00 ` Andrey Ryabinin 2017-06-28 14:00 ` Andrey Ryabinin 2017-06-22 14:14 ` [PATCH v5 4/4] asm-generic, x86: add comments for atomic instrumentation Dmitry Vyukov 2017-06-22 14:14 ` Dmitry Vyukov 2017-06-23 14:01 ` [tip:locking/core] locking/atomic/x86, asm-generic: Add " tip-bot for Dmitry Vyukov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170628121246.qnk2csgzbgpqrmw3@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=dvyukov@google.com \ --cc=hpa@zytor.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mark.rutland@arm.com \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.