All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v2] iommu/amd: Fix interrupt remapping when disable guest_mode
Date: Wed, 28 Jun 2017 14:44:48 +0200	[thread overview]
Message-ID: <20170628124447.GA28603@8bytes.org> (raw)
In-Reply-To: <1498469284-85652-1-git-send-email-suravee.suthikulpanit@amd.com>

On Mon, Jun 26, 2017 at 04:28:04AM -0500, Suravee Suthikulpanit wrote:
> Pass-through devices to VM guest can get updated IRQ affinity
> information via irq_set_affinity() when not running in guest mode.
> Currently, AMD IOMMU driver in GA mode ignores the updated information
> if the pass-through device is setup to use vAPIC regardless of guest_mode.
> This could cause invalid interrupt remapping.
> 
> Also, the guest_mode bit should be set and cleared only when
> SVM updates posted-interrupt interrupt remapping information.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Joerg Roedel <jroedel@suse.de>

Nervermind, I added this fixes line and applied the patch:

	Fixes: d98de49a53e48 ('iommu/amd: Enable vAPIC interrupt remapping mode by default'

  parent reply	other threads:[~2017-06-28 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26  9:28 [PATCH v2] iommu/amd: Fix interrupt remapping when disable guest_mode Suravee Suthikulpanit
2017-06-26  9:28 ` Suravee Suthikulpanit
2017-06-28  9:07 ` Joerg Roedel
2017-06-28  9:07   ` Joerg Roedel
2017-06-28 12:44 ` Joerg Roedel [this message]
2017-06-29  3:27   ` Suravee Suthikulpanit
2017-06-29  3:27     ` Suravee Suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628124447.GA28603@8bytes.org \
    --to=joro@8bytes.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.