All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 1/3] RDMA/device: Fix device removal notification when ib_clients set .add callout to NULL
Date: Wed, 28 Jun 2017 16:16:23 +0200	[thread overview]
Message-ID: <20170628141623.GB1894@lst.de> (raw)
In-Reply-To: <1498644338-19719-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

The subject looks a bit odd to me, I'd say something like

RDMA/core: make ib_device.add method optional

Otherwise this looks good to me:

Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] RDMA/device: Fix device removal notification when ib_clients set .add callout to NULL
Date: Wed, 28 Jun 2017 16:16:23 +0200	[thread overview]
Message-ID: <20170628141623.GB1894@lst.de> (raw)
In-Reply-To: <1498644338-19719-2-git-send-email-sagi@grimberg.me>

The subject looks a bit odd to me, I'd say something like

RDMA/core: make ib_device.add method optional

Otherwise this looks good to me:

Reviewed-by: Christoph Hellwig <hch at lst.de>

  parent reply	other threads:[~2017-06-28 14:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 10:05 [PATCH 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Sagi Grimberg
2017-06-28 10:05 ` Sagi Grimberg
     [not found] ` <1498644338-19719-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 10:05   ` [PATCH 1/3] RDMA/device: Fix device removal notification when ib_clients set .add callout to NULL Sagi Grimberg
2017-06-28 10:05     ` Sagi Grimberg
     [not found]     ` <1498644338-19719-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 12:40       ` Johannes Thumshirn
2017-06-28 12:40         ` Johannes Thumshirn
2017-06-28 14:16       ` Christoph Hellwig [this message]
2017-06-28 14:16         ` Christoph Hellwig
2017-06-28 10:05   ` [PATCH 2/3] nvme-rdma: remove redundant empty device add callout Sagi Grimberg
2017-06-28 10:05     ` Sagi Grimberg
     [not found]     ` <1498644338-19719-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 12:39       ` Johannes Thumshirn
2017-06-28 12:39         ` Johannes Thumshirn
2017-06-28 14:16       ` Christoph Hellwig
2017-06-28 14:16         ` Christoph Hellwig
2017-06-28 10:05   ` [PATCH 3/3] nvmet-rdma: " Sagi Grimberg
2017-06-28 10:05     ` Sagi Grimberg
     [not found]     ` <1498644338-19719-4-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 12:39       ` Johannes Thumshirn
2017-06-28 12:39         ` Johannes Thumshirn
2017-06-28 14:16       ` Christoph Hellwig
2017-06-28 14:16         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628141623.GB1894@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.