* [PATCH] libata: fix build warning in ata_scsi_var_len_cdb_xlat
@ 2017-06-28 20:04 Arnd Bergmann
2017-06-28 21:25 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-06-28 20:04 UTC (permalink / raw)
To: Tejun Heo
Cc: Bart Van Assche, Arnd Bergmann, Tom Yan, Hannes Reinecke,
Shaun Tancheff, Adam Manzanares, Minwoo Im, linux-ide,
linux-kernel
This new harmless warning just showed up:
drivers/ata/libata-scsi.c: In function 'ata_scsi_var_len_cdb_xlat':
drivers/ata/libata-scsi.c:4194:1: error: label 'unspprt_sa' defined but not used [-Werror=unused-label]
The label is obviously unused and can be removed.
Fixes: b1ffbf854e08 ("libata: Support for an ATA PASS-THROUGH(32) command.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ata/libata-scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 815c6e240aea..9d1b66b4ce7b 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4191,7 +4191,6 @@ static unsigned int ata_scsi_var_len_cdb_xlat(struct ata_queued_cmd *qc)
if (sa == ATA_32)
return ata_scsi_pass_thru(qc);
-unspprt_sa:
/* unsupported service action */
return 1;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: fix build warning in ata_scsi_var_len_cdb_xlat
2017-06-28 20:04 [PATCH] libata: fix build warning in ata_scsi_var_len_cdb_xlat Arnd Bergmann
@ 2017-06-28 21:25 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-06-28 21:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bart Van Assche, Tom Yan, Hannes Reinecke, Shaun Tancheff,
Adam Manzanares, Minwoo Im, linux-ide, linux-kernel
Hello, Arnd.
On Wed, Jun 28, 2017 at 10:04:03PM +0200, Arnd Bergmann wrote:
> This new harmless warning just showed up:
>
> drivers/ata/libata-scsi.c: In function 'ata_scsi_var_len_cdb_xlat':
> drivers/ata/libata-scsi.c:4194:1: error: label 'unspprt_sa' defined but not used [-Werror=unused-label]
>
> The label is obviously unused and can be removed.
>
> Fixes: b1ffbf854e08 ("libata: Support for an ATA PASS-THROUGH(32) command.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Already fixed a couple hours ago. Sorry about the noise.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-28 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 20:04 [PATCH] libata: fix build warning in ata_scsi_var_len_cdb_xlat Arnd Bergmann
2017-06-28 21:25 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.