All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: smc91x: constify dev_pm_ops structures.
@ 2017-06-29  5:51 Arvind Yadav
  2017-06-29 19:49 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-29  5:51 UTC (permalink / raw)
  To: davem, rmk+kernel, jeremy.linton, jarod, nico; +Cc: netdev, linux-kernel

dev_pm_ops are not supposed to change at runtime. All functions
working with dev_pm_ops provided by <linux/device.h> work with const
dev_pm_ops. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  18709	    401	      0	  19110	   4aa6	drivers/net/ethernet/smsc/smc91x.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  18901	    201	      0	  19102	   4a9e	drivers/net/ethernet/smsc/smc91x.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/net/ethernet/smsc/smc91x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 91e9bd7..83cf052 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -2488,7 +2488,7 @@ static int smc_drv_resume(struct device *dev)
 	return 0;
 }
 
-static struct dev_pm_ops smc_drv_pm_ops = {
+static const struct dev_pm_ops smc_drv_pm_ops = {
 	.suspend	= smc_drv_suspend,
 	.resume		= smc_drv_resume,
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: smc91x: constify dev_pm_ops structures.
  2017-06-29  5:51 [PATCH] net: smc91x: constify dev_pm_ops structures Arvind Yadav
@ 2017-06-29 19:49 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-29 19:49 UTC (permalink / raw)
  To: arvind.yadav.cs
  Cc: rmk+kernel, jeremy.linton, jarod, nico, netdev, linux-kernel

From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 29 Jun 2017 11:21:00 +0530

> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   18709	    401	      0	  19110	   4aa6	drivers/net/ethernet/smsc/smc91x.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   18901	    201	      0	  19102	   4a9e	drivers/net/ethernet/smsc/smc91x.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-29 19:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29  5:51 [PATCH] net: smc91x: constify dev_pm_ops structures Arvind Yadav
2017-06-29 19:49 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.