All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dma: fsl_raid: make of_device_ids const.
@ 2017-06-27 12:08 Arvind Yadav
  2017-06-29  3:57 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-27 12:08 UTC (permalink / raw)
  To: dan.j.williams, vinod.koul; +Cc: dmaengine, linux-kernel

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   3981	    608	      0	   4589	   11ed	drivers/dma/fsl_raid.o

File size after constify:
   text	   data	    bss	    dec	    hex	filename
   4381	    192	      0	   4573	   11dd	drivers/dma/fsl_raid.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/dma/fsl_raid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
index 90d29f9..493dc6c 100644
--- a/drivers/dma/fsl_raid.c
+++ b/drivers/dma/fsl_raid.c
@@ -877,7 +877,7 @@ static int fsl_re_remove(struct platform_device *ofdev)
 	return 0;
 }
 
-static struct of_device_id fsl_re_ids[] = {
+static const struct of_device_id fsl_re_ids[] = {
 	{ .compatible = "fsl,raideng-v1.0", },
 	{}
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dma: fsl_raid: make of_device_ids const.
  2017-06-27 12:08 [PATCH] dma: fsl_raid: make of_device_ids const Arvind Yadav
@ 2017-06-29  3:57 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2017-06-29  3:57 UTC (permalink / raw)
  To: Arvind Yadav; +Cc: dan.j.williams, dmaengine, linux-kernel

On Tue, Jun 27, 2017 at 05:38:27PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.

Please ensure you use the right subsystem tags for sending a patch, Git log
for that file or dir should tell you the convention to use, fixed that and
applied now, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-29  3:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 12:08 [PATCH] dma: fsl_raid: make of_device_ids const Arvind Yadav
2017-06-29  3:57 ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.