* [PATCH] nvme: Makefile: remove dead build rule
@ 2017-06-29 6:59 ` Valentin Rothberg
0 siblings, 0 replies; 10+ messages in thread
From: Valentin Rothberg @ 2017-06-29 6:59 UTC (permalink / raw)
Remove dead build rule for drivers/nvme/host/scsi.c which has been
removed by commit ("nvme: Remove SCSI translations").
Signed-off-by: Valentin Rothberg <vrothberg at suse.com>
---
drivers/nvme/host/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/Makefile b/drivers/nvme/host/Makefile
index f1a7d945fbb6..cc0aacb4c8b4 100644
--- a/drivers/nvme/host/Makefile
+++ b/drivers/nvme/host/Makefile
@@ -5,7 +5,6 @@ obj-$(CONFIG_NVME_RDMA) += nvme-rdma.o
obj-$(CONFIG_NVME_FC) += nvme-fc.o
nvme-core-y := core.o
-nvme-core-$(CONFIG_BLK_DEV_NVME_SCSI) += scsi.o
nvme-core-$(CONFIG_NVM) += lightnvm.o
nvme-y += pci.o
--
2.12.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] nvme: Makefile: remove dead build rule
2017-06-29 6:59 ` Valentin Rothberg
@ 2017-06-29 8:33 ` Johannes Thumshirn
-1 siblings, 0 replies; 10+ messages in thread
From: Johannes Thumshirn @ 2017-06-29 8:33 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: keith.busch, axboe, hch, linux-kernel, linux-nvme
On Thu, Jun 29, 2017 at 08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
>
> Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] nvme: Makefile: remove dead build rule
@ 2017-06-29 8:33 ` Johannes Thumshirn
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Thumshirn @ 2017-06-29 8:33 UTC (permalink / raw)
On Thu, Jun 29, 2017@08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
>
> Signed-off-by: Valentin Rothberg <vrothberg at suse.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] nvme: Makefile: remove dead build rule
2017-06-29 6:59 ` Valentin Rothberg
@ 2017-06-29 14:37 ` Christoph Hellwig
-1 siblings, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2017-06-29 14:37 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: keith.busch, axboe, hch, linux-nvme, linux-kernel
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] nvme: Makefile: remove dead build rule
2017-06-29 6:59 ` Valentin Rothberg
@ 2017-06-29 14:57 ` Keith Busch
-1 siblings, 0 replies; 10+ messages in thread
From: Keith Busch @ 2017-06-29 14:57 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: axboe, hch, linux-nvme, linux-kernel
On Thu, Jun 29, 2017 at 08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
>
> Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
Oops, thanks for the fix.
Reviewed-by: Keith Busch <keith.busch@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] nvme: Makefile: remove dead build rule
@ 2017-06-29 14:57 ` Keith Busch
0 siblings, 0 replies; 10+ messages in thread
From: Keith Busch @ 2017-06-29 14:57 UTC (permalink / raw)
On Thu, Jun 29, 2017@08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
>
> Signed-off-by: Valentin Rothberg <vrothberg at suse.com>
Oops, thanks for the fix.
Reviewed-by: Keith Busch <keith.busch at intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] nvme: Makefile: remove dead build rule
2017-06-29 6:59 ` Valentin Rothberg
@ 2017-06-29 15:43 ` Jens Axboe
-1 siblings, 0 replies; 10+ messages in thread
From: Jens Axboe @ 2017-06-29 15:43 UTC (permalink / raw)
To: Valentin Rothberg, keith.busch, hch; +Cc: linux-nvme, linux-kernel
On 06/29/2017 12:59 AM, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
Added, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 10+ messages in thread