All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable
@ 2017-06-29 12:21 Peter Robinson
  2017-06-29 12:23 ` Fabio Estevam
  2017-06-29 17:29 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 6+ messages in thread
From: Peter Robinson @ 2017-06-29 12:21 UTC (permalink / raw)
  To: u-boot

The CONFIG_DEFAULT_FDT_FILE expects just the file not a full path
as that might vary depending on the variant of Linux distro you
might be using.

Cc: Martin Donnelly <martin.donnelly@ge.com>
Cc: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 configs/ge_b450v3_defconfig | 2 +-
 configs/ge_b650v3_defconfig | 2 +-
 configs/ge_b850v3_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configs/ge_b450v3_defconfig b/configs/ge_b450v3_defconfig
index c5d78538b6..aaeb34d7c0 100644
--- a/configs/ge_b450v3_defconfig
+++ b/configs/ge_b450v3_defconfig
@@ -5,7 +5,7 @@ CONFIG_TARGET_GE_B450V3=y
 CONFIG_BOOTDELAY=1
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
-CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b450v3.dtb"
+CONFIG_DEFAULT_FDT_FILE="imx6q-b450v3.dtb"
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
diff --git a/configs/ge_b650v3_defconfig b/configs/ge_b650v3_defconfig
index dd44663dde..78187051eb 100644
--- a/configs/ge_b650v3_defconfig
+++ b/configs/ge_b650v3_defconfig
@@ -5,7 +5,7 @@ CONFIG_TARGET_GE_B650V3=y
 CONFIG_BOOTDELAY=1
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
-CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b650v3.dtb"
+CONFIG_DEFAULT_FDT_FILE="imx6q-b650v3.dtb"
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
diff --git a/configs/ge_b850v3_defconfig b/configs/ge_b850v3_defconfig
index 45e5fb1ff4..967ddba13a 100644
--- a/configs/ge_b850v3_defconfig
+++ b/configs/ge_b850v3_defconfig
@@ -5,7 +5,7 @@ CONFIG_TARGET_GE_B850V3=y
 CONFIG_BOOTDELAY=1
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
-CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b850v3.dtb"
+CONFIG_DEFAULT_FDT_FILE="imx6q-b850v3.dtb"
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable
  2017-06-29 12:21 [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable Peter Robinson
@ 2017-06-29 12:23 ` Fabio Estevam
  2017-06-29 17:29 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-06-29 12:23 UTC (permalink / raw)
  To: u-boot

On Thu, Jun 29, 2017 at 9:21 AM, Peter Robinson <pbrobinson@gmail.com> wrote:
> The CONFIG_DEFAULT_FDT_FILE expects just the file not a full path
> as that might vary depending on the variant of Linux distro you
> might be using.
>
> Cc: Martin Donnelly <martin.donnelly@ge.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Acked-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] GE Bx50v3 boards: fix fdt file variable
  2017-06-29 12:21 [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable Peter Robinson
  2017-06-29 12:23 ` Fabio Estevam
@ 2017-06-29 17:29 ` Tom Rini
  1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2017-06-29 17:29 UTC (permalink / raw)
  To: u-boot

On Thu, Jun 29, 2017 at 01:21:38PM +0100, Peter Robinson wrote:

> The CONFIG_DEFAULT_FDT_FILE expects just the file not a full path
> as that might vary depending on the variant of Linux distro you
> might be using.
> 
> Cc: Martin Donnelly <martin.donnelly@ge.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Acked-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170629/d80330d0/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable
  2017-06-29 11:51 ` Fabio Estevam
@ 2017-06-29 12:09   ` Peter Robinson
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2017-06-29 12:09 UTC (permalink / raw)
  To: u-boot

On Thu, Jun 29, 2017 at 12:51 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Peter,
>
> On Thu, Jun 29, 2017 at 8:44 AM, Peter Robinson <pbrobinson@gmail.com> wrote:
>> The CONFIG_DEFAULT_FDT_FILE expects just the file not a full path
>> as that might vary depending on the variant of Linux distro you
>> might be using.
>>
>> Cc: Martin Donnelly <martin.donnelly@ge.com>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>>  configs/ge_b650v3_defconfig | 2 +-
>>  configs/ge_b850v3_defconfig | 2 +-
>
> Patch looks good, but there is another one too:
>
> configs/ge_b450v3_defconfig:CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b450v3.dtb"
>
> Could you also include the change for configs/ge_b450v3_defconfig and send a v2?

Sure, clearly I was slightly blind in not seeing that :)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable
  2017-06-29 11:44 [U-Boot] [PATCH] " Peter Robinson
@ 2017-06-29 11:51 ` Fabio Estevam
  2017-06-29 12:09   ` Peter Robinson
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-06-29 11:51 UTC (permalink / raw)
  To: u-boot

Hi Peter,

On Thu, Jun 29, 2017 at 8:44 AM, Peter Robinson <pbrobinson@gmail.com> wrote:
> The CONFIG_DEFAULT_FDT_FILE expects just the file not a full path
> as that might vary depending on the variant of Linux distro you
> might be using.
>
> Cc: Martin Donnelly <martin.donnelly@ge.com>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  configs/ge_b650v3_defconfig | 2 +-
>  configs/ge_b850v3_defconfig | 2 +-

Patch looks good, but there is another one too:

configs/ge_b450v3_defconfig:CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b450v3.dtb"

Could you also include the change for configs/ge_b450v3_defconfig and send a v2?

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable
@ 2017-06-29 11:44 Peter Robinson
  2017-06-29 11:51 ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Robinson @ 2017-06-29 11:44 UTC (permalink / raw)
  To: u-boot

The CONFIG_DEFAULT_FDT_FILE expects just the file not a full path
as that might vary depending on the variant of Linux distro you
might be using.

Cc: Martin Donnelly <martin.donnelly@ge.com>
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 configs/ge_b650v3_defconfig | 2 +-
 configs/ge_b850v3_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configs/ge_b650v3_defconfig b/configs/ge_b650v3_defconfig
index dd44663dde..78187051eb 100644
--- a/configs/ge_b650v3_defconfig
+++ b/configs/ge_b650v3_defconfig
@@ -5,7 +5,7 @@ CONFIG_TARGET_GE_B650V3=y
 CONFIG_BOOTDELAY=1
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
-CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b650v3.dtb"
+CONFIG_DEFAULT_FDT_FILE="imx6q-b650v3.dtb"
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
diff --git a/configs/ge_b850v3_defconfig b/configs/ge_b850v3_defconfig
index 45e5fb1ff4..967ddba13a 100644
--- a/configs/ge_b850v3_defconfig
+++ b/configs/ge_b850v3_defconfig
@@ -5,7 +5,7 @@ CONFIG_TARGET_GE_B850V3=y
 CONFIG_BOOTDELAY=1
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
-CONFIG_DEFAULT_FDT_FILE="/boot/imx6q-b850v3.dtb"
+CONFIG_DEFAULT_FDT_FILE="imx6q-b850v3.dtb"
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-06-29 17:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 12:21 [U-Boot] [PATCH] GE Bx50v3 boards: fix fdt file variable Peter Robinson
2017-06-29 12:23 ` Fabio Estevam
2017-06-29 17:29 ` [U-Boot] " Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2017-06-29 11:44 [U-Boot] [PATCH] " Peter Robinson
2017-06-29 11:51 ` Fabio Estevam
2017-06-29 12:09   ` Peter Robinson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.