* [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation
@ 2017-06-27 7:36 Jaya Durga
2017-06-29 14:20 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jaya Durga @ 2017-06-27 7:36 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, florian.c.schilhabel, rvarsha016, julia.lawall,
binoy.jayan, arnd, louie.lu, devel, linux-kernel, Jaya Durga,
Jaya Durga
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
Signed-off-by: Jaya Durga <jayad@cdac.in>
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
*/
static int wifi_test;
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
module_param(wifi_test, int, 0644);
module_param(initmac, charp, 0644);
module_param(video_mode, int, 0644);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation
2017-06-27 7:36 [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga
@ 2017-06-29 14:20 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-06-29 14:20 UTC (permalink / raw)
To: Jaya Durga
Cc: devel, binoy.jayan, Jaya Durga, arnd, florian.c.schilhabel,
rvarsha016, louie.lu, linux-kernel, julia.lawall, Larry.Finger
On Tue, Jun 27, 2017 at 01:06:00PM +0530, Jaya Durga wrote:
> Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
>
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
> drivers/staging/rtl8712/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I have a bizarre series of oddly numbered patches from you, and no where
is a whole, correctly numbered, set of patches that I can sort correctly
and apply to my tree knowing that I did not miss any.
So I've now dropped all of your patches you have sent to me from my
queue. Please redo them all and resend them properly numbered in a
manner that makes it _obvious_ what ones I should review and what order
they should be applied in.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 7:36 [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga
2017-06-29 14:20 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.