Re: [PATCH] perf tools: set no branch type for dummy event in PT

From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "acme@kernel.org" <acme@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH] perf tools: set no branch type for dummy event in PT
Date: Thu, 29 Jun 2017 17:39:32 +0200	[thread overview]
Message-ID: <20170629153932.GA2924@krava> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0775371415B@SHSMSX103.ccr.corp.intel.com>

On Thu, Jun 29, 2017 at 03:31:45PM +0000, Liang, Kan wrote:

SNIP

> > >  static int intel_pt_recording_options(struct auxtrace_record *itr,
> > >  				      struct perf_evlist *evlist,
> > >  				      struct record_opts *opts)
> > > @@ -701,6 +717,8 @@ static int intel_pt_recording_options(struct
> > auxtrace_record *itr,
> > >  				perf_evsel__set_sample_bit(switch_evsel,
> > TIME);
> > >  				perf_evsel__set_sample_bit(switch_evsel,
> > CPU);
> > >
> > > +				add_no_lbr_config_term(&switch_evsel-
> > >config_terms);
> > > +
> > 
> > hum, why can't you change the sample bit directly? with:
> > 
> > 			perf_evsel__reset_sample_bit(switch_evsel,
> > BRANCH_STACK);
> 
> It will be overwrite in perf_evsel__config.
> 

where? you set the evsel->no_aux_samples 

jirka