From: "Liang, Kan" <kan.liang@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "acme@kernel.org" <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: RE: [PATCH] perf tools: set no branch type for dummy event in PT
Date: Fri, 30 Jun 2017 14:01:56 +0000 [thread overview]
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F07753714794@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170630070624.GD6815@krava>
> On Thu, Jun 29, 2017 at 03:50:29PM +0000, Liang, Kan wrote:
> >
> >
> > >
> > > On Thu, Jun 29, 2017 at 03:31:45PM +0000, Liang, Kan wrote:
> > >
> > > SNIP
> > >
> > > > > > static int intel_pt_recording_options(struct auxtrace_record *itr,
> > > > > > struct perf_evlist *evlist,
> > > > > > struct record_opts *opts) @@ -
> 701,6
> > > +717,8 @@ static
> > > > > > int intel_pt_recording_options(struct
> > > > > auxtrace_record *itr,
> > > > > >
> perf_evsel__set_sample_bit(switch_evsel,
> > > > > TIME);
> > > > > >
> perf_evsel__set_sample_bit(switch_evsel,
> > > > > CPU);
> > > > > >
> > > > > > +
> add_no_lbr_config_term(&switch_evsel-
> > > > > >config_terms);
> > > > > > +
> > > > >
> > > > > hum, why can't you change the sample bit directly? with:
> > > > >
> > > > > perf_evsel__reset_sample_bit(switch_evsel,
> > > > > BRANCH_STACK);
> > > >
> > > > It will be overwrite in perf_evsel__config.
> > > >
> > >
> > > where? you set the evsel->no_aux_samples
> >
> > Yes for switch_evsel, but no for tracking_evsel.
> >
> > If it's only for switch_evsel, yes, we can change the sample bit directly.
> > But I think we should use the same method for both of them.
>
>
> we could set the no_aux_samples for the tracking_evsel as well
>
Yes, I will do it in next version.
Thanks,
Kan
prev parent reply other threads:[~2017-06-30 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 14:31 [PATCH] perf tools: set no branch type for dummy event in PT kan.liang
2017-06-29 15:29 ` Jiri Olsa
2017-06-29 15:31 ` Liang, Kan
2017-06-29 15:39 ` Jiri Olsa
2017-06-29 15:50 ` Liang, Kan
2017-06-30 7:06 ` Jiri Olsa
2017-06-30 14:01 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37D7C6CF3E00A74B8858931C1DB2F07753714794@SHSMSX103.ccr.corp.intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.