From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg KH <gregkh@linuxfoundation.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
"mfuzzey@parkeon.com" <mfuzzey@parkeon.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Daniel Wagner <wagi@monom.org>,
David Woodhouse <dwmw2@infradead.org>,
"jewalt@lgsinnovations.com" <jewalt@lgsinnovations.com>,
"rafal@milecki.pl" <rafal@milecki.pl>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Li, Yi" <yi1.li@linux.intel.com>,
"atull@kernel.org" <atull@kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
Petr Mladek <pmladek@suse.com>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
"Coelho, Luciano" <luciano.coelho@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Andrew Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
David Howells <dhowells@redhat.com>,
Peter Jones <pjones@redhat.com>,
Hans de Goede <hdegoede@redhat.com>,
Alan Cox <alan@linux.intel.com>, "Theodore Ts'o" <tytso@mit.edu>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Linux API <linux-api@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"stable # 4 . 6" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/4] swait: add the missing killable swaits
Date: Thu, 29 Jun 2017 19:29:21 +0200 [thread overview]
Message-ID: <20170629172921.GM21846@wotan.suse.de> (raw)
In-Reply-To: <BY2PR21MB00365B4A70BD334F4568A086CBD20@BY2PR21MB0036.namprd21.prod.outlook.com>
On Thu, Jun 29, 2017 at 04:31:08PM +0000, Matthew Wilcox wrote:
> Linus Torvalds wrote:
> > The thing is simply a collection of small hacks and should NOT be used
> > in general.
> >
> > I never want to see a driver use that code, for example. It was
> > designed for RCU and RT, and it should damn well be limited to that.
>
> Maybe put #ifndef MODULE around the entire include file then?
> And definitely remove this line:
>
> * One would recommend using this wait queue where possible.
I'll respin and port away from swait, and add the #ifndef MODULE and special
note on swait.h.
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg KH <gregkh@linuxfoundation.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
"mfuzzey@parkeon.com" <mfuzzey@parkeon.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Daniel Wagner <wagi@monom.org>,
David Woodhouse <dwmw2@infradead.org>,
"jewalt@lgsinnovations.com" <jewalt@lgsinnovations.com>,
"rafal@milecki.pl" <rafal@milecki.pl>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Li, Yi" <yi1.li@linux.intel.com>,
"atull@kernel.org" <atull@kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
Petr Mladek <pmladek@suse.com>,
Johannes Berg <johannes.berg@intel.com>,
Emman
Subject: Re: [PATCH 2/4] swait: add the missing killable swaits
Date: Thu, 29 Jun 2017 19:29:21 +0200 [thread overview]
Message-ID: <20170629172921.GM21846@wotan.suse.de> (raw)
In-Reply-To: <BY2PR21MB00365B4A70BD334F4568A086CBD20@BY2PR21MB0036.namprd21.prod.outlook.com>
On Thu, Jun 29, 2017 at 04:31:08PM +0000, Matthew Wilcox wrote:
> Linus Torvalds wrote:
> > The thing is simply a collection of small hacks and should NOT be used
> > in general.
> >
> > I never want to see a driver use that code, for example. It was
> > designed for RCU and RT, and it should damn well be limited to that.
>
> Maybe put #ifndef MODULE around the entire include file then?
> And definitely remove this line:
>
> * One would recommend using this wait queue where possible.
I'll respin and port away from swait, and add the #ifndef MODULE and special
note on swait.h.
Luis
next prev parent reply other threads:[~2017-06-29 17:29 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 22:20 [PATCH 0/4] firmware: fix fallback mechanism by ignoring SIGCHLD Luis R. Rodriguez
2017-06-14 22:20 ` Luis R. Rodriguez
2017-06-14 22:20 ` [PATCH 1/4] test_firmware: add test case for SIGCHLD on sync fallback Luis R. Rodriguez
2017-06-14 22:20 ` Luis R. Rodriguez
2017-06-14 22:20 ` [PATCH 2/4] swait: add the missing killable swaits Luis R. Rodriguez
2017-06-14 22:20 ` Luis R. Rodriguez
2017-06-29 12:54 ` Greg KH
2017-06-29 12:54 ` Greg KH
2017-06-29 13:05 ` Thomas Gleixner
2017-06-29 13:05 ` Thomas Gleixner
2017-06-29 13:35 ` Greg KH
2017-06-29 13:35 ` Greg KH
2017-06-29 13:46 ` Thomas Gleixner
2017-06-29 13:46 ` Thomas Gleixner
2017-06-29 16:13 ` Linus Torvalds
2017-06-29 16:13 ` Linus Torvalds
2017-06-29 16:31 ` Matthew Wilcox
2017-06-29 16:31 ` Matthew Wilcox
2017-06-29 17:29 ` Luis R. Rodriguez [this message]
2017-06-29 17:29 ` Luis R. Rodriguez
2017-06-29 17:40 ` Davidlohr Bueso
2017-06-29 17:40 ` Davidlohr Bueso
2017-06-29 17:57 ` Linus Torvalds
2017-06-29 17:57 ` Linus Torvalds
2017-06-29 18:33 ` Davidlohr Bueso
2017-06-29 18:33 ` Davidlohr Bueso
2017-06-29 18:59 ` Linus Torvalds
2017-06-29 18:59 ` Linus Torvalds
2017-06-29 19:40 ` Luis R. Rodriguez
2017-06-29 19:40 ` Luis R. Rodriguez
2017-06-29 19:44 ` Luis R. Rodriguez
2017-06-29 19:44 ` Luis R. Rodriguez
2017-06-29 20:58 ` Jakub Kicinski
2017-06-29 20:58 ` Jakub Kicinski
2017-06-29 22:50 ` Luis R. Rodriguez
2017-06-29 22:50 ` Luis R. Rodriguez
2017-06-29 22:53 ` Jakub Kicinski
2017-06-29 22:53 ` Jakub Kicinski
2017-06-29 23:00 ` Luis R. Rodriguez
2017-06-29 23:00 ` Luis R. Rodriguez
2017-06-29 23:06 ` Jakub Kicinski
2017-06-29 23:06 ` Jakub Kicinski
2017-07-12 21:33 ` Luis R. Rodriguez
2017-07-12 21:33 ` Luis R. Rodriguez
2017-06-29 20:57 ` Linus Torvalds
2017-06-29 20:57 ` Linus Torvalds
2017-07-05 2:06 ` Davidlohr Bueso
2017-07-05 2:06 ` Davidlohr Bueso
2017-07-07 19:58 ` Linus Torvalds
2017-07-07 19:58 ` Linus Torvalds
2017-07-07 22:27 ` Davidlohr Bueso
2017-07-07 22:27 ` Davidlohr Bueso
2017-07-07 22:48 ` Linus Torvalds
2017-07-07 22:48 ` Linus Torvalds
2017-06-29 19:15 ` Marcelo Tosatti
2017-06-29 19:15 ` Marcelo Tosatti
2017-06-29 19:15 ` Marcelo Tosatti
2017-06-30 4:03 ` Linus Torvalds
2017-06-30 4:03 ` Linus Torvalds
2017-06-30 11:55 ` Marcelo Tosatti
2017-06-30 11:55 ` Marcelo Tosatti
2017-06-30 11:55 ` Marcelo Tosatti
2017-06-30 11:57 ` Marcelo Tosatti
2017-06-30 11:57 ` Marcelo Tosatti
2017-06-30 17:30 ` Krister Johansen
2017-06-30 17:30 ` Krister Johansen
2017-06-14 22:20 ` [PATCH 3/4] firmware: avoid invalid fallback aborts by using killable swait Luis R. Rodriguez
2017-06-14 22:20 ` Luis R. Rodriguez
2017-06-14 22:20 ` [PATCH 4/4] firmware: send -EINTR on signal abort on fallback mechanism Luis R. Rodriguez
2017-06-14 22:20 ` Luis R. Rodriguez
2017-06-15 7:49 ` [PATCH 0/4] firmware: fix fallback mechanism by ignoring SIGCHLD Martin Fuzzey
2017-06-26 21:19 ` Luis R. Rodriguez
2017-06-26 21:19 ` Luis R. Rodriguez
2017-06-29 15:14 ` Greg KH
2017-06-29 15:14 ` Greg KH
2017-06-29 17:29 ` Luis R. Rodriguez
2017-06-29 17:29 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629172921.GM21846@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jewalt@lgsinnovations.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mfuzzey@parkeon.com \
--cc=moritz.fischer@ettus.com \
--cc=mtk.manpages@gmail.com \
--cc=mtosatti@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.