* [PATCH] clk: si5351: expand compatible strings in documentation
@ 2017-06-29 13:31 ` Brandon Streiff
0 siblings, 0 replies; 7+ messages in thread
From: Brandon Streiff @ 2017-06-29 13:31 UTC (permalink / raw)
Cc: mturquette, sboyd, robh+dt, mark.rutland, linux-clk, devicetree,
linux-kernel, Brandon Streiff
checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
and so generates warnings about si5351-compatible devices appearing to
be un-documented. Resolve this by documenting the compatible options
supported by the clk-si5351 driver individually.
Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
---
Documentation/devicetree/bindings/clock/silabs,si5351.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/silabs,si5351.txt b/Documentation/devicetree/bindings/clock/silabs,si5351.txt
index 28b2830..a6c4ef3 100644
--- a/Documentation/devicetree/bindings/clock/silabs,si5351.txt
+++ b/Documentation/devicetree/bindings/clock/silabs,si5351.txt
@@ -12,7 +12,11 @@ generators can be found in [1].
==I2C device node==
Required properties:
-- compatible: shall be one of "silabs,si5351{a,a-msop,b,c}".
+- compatible: shall be one of the following:
+ "silabs,si5351a" - Si5351a, QFN20 package
+ "silabs,si5351a-msop" - Si5351a, MSOP10 package
+ "silabs,si5351b" - Si5351b, QFN20 package
+ "silabs,si5351c" - Si5351c, QFN20 package
- reg: i2c device address, shall be 0x60 or 0x61.
- #clock-cells: from common clock binding; shall be set to 1.
- clocks: from common clock binding; list of parent clock
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: si5351: expand compatible strings in documentation
@ 2017-06-29 13:31 ` Brandon Streiff
0 siblings, 0 replies; 7+ messages in thread
From: Brandon Streiff @ 2017-06-29 13:31 UTC (permalink / raw)
Cc: mturquette, sboyd, robh+dt, mark.rutland, linux-clk, devicetree,
linux-kernel, Brandon Streiff
checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
and so generates warnings about si5351-compatible devices appearing to
be un-documented. Resolve this by documenting the compatible options
supported by the clk-si5351 driver individually.
Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
---
Documentation/devicetree/bindings/clock/silabs,si5351.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/silabs,si5351.txt b/Documentation/devicetree/bindings/clock/silabs,si5351.txt
index 28b2830..a6c4ef3 100644
--- a/Documentation/devicetree/bindings/clock/silabs,si5351.txt
+++ b/Documentation/devicetree/bindings/clock/silabs,si5351.txt
@@ -12,7 +12,11 @@ generators can be found in [1].
==I2C device node==
Required properties:
-- compatible: shall be one of "silabs,si5351{a,a-msop,b,c}".
+- compatible: shall be one of the following:
+ "silabs,si5351a" - Si5351a, QFN20 package
+ "silabs,si5351a-msop" - Si5351a, MSOP10 package
+ "silabs,si5351b" - Si5351b, QFN20 package
+ "silabs,si5351c" - Si5351c, QFN20 package
- reg: i2c device address, shall be 0x60 or 0x61.
- #clock-cells: from common clock binding; shall be set to 1.
- clocks: from common clock binding; list of parent clock
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] clk: si5351: expand compatible strings in documentation
@ 2017-06-29 13:31 ` Brandon Streiff
0 siblings, 0 replies; 7+ messages in thread
From: Brandon Streiff @ 2017-06-29 13:31 UTC (permalink / raw)
Cc: mturquette, sboyd, robh+dt, mark.rutland, linux-clk, devicetree,
linux-kernel, Brandon Streiff
checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
and so generates warnings about si5351-compatible devices appearing to
be un-documented. Resolve this by documenting the compatible options
supported by the clk-si5351 driver individually.
Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
---
Documentation/devicetree/bindings/clock/silabs,si5351.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/silabs,si5351.txt b/Documentation/devicetree/bindings/clock/silabs,si5351.txt
index 28b2830..a6c4ef3 100644
--- a/Documentation/devicetree/bindings/clock/silabs,si5351.txt
+++ b/Documentation/devicetree/bindings/clock/silabs,si5351.txt
@@ -12,7 +12,11 @@ generators can be found in [1].
==I2C device node==
Required properties:
-- compatible: shall be one of "silabs,si5351{a,a-msop,b,c}".
+- compatible: shall be one of the following:
+ "silabs,si5351a" - Si5351a, QFN20 package
+ "silabs,si5351a-msop" - Si5351a, MSOP10 package
+ "silabs,si5351b" - Si5351b, QFN20 package
+ "silabs,si5351c" - Si5351c, QFN20 package
- reg: i2c device address, shall be 0x60 or 0x61.
- #clock-cells: from common clock binding; shall be set to 1.
- clocks: from common clock binding; list of parent clock
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: si5351: expand compatible strings in documentation
@ 2017-06-30 0:21 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2017-06-30 0:21 UTC (permalink / raw)
To: Brandon Streiff, robh+dt
Cc: mturquette, mark.rutland, linux-clk, devicetree, linux-kernel
To is to nobody? Rob can apply it I suppose.
On 06/29, Brandon Streiff wrote:
> checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
> and so generates warnings about si5351-compatible devices appearing to
> be un-documented. Resolve this by documenting the compatible options
> supported by the clk-si5351 driver individually.
>
> Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
> ---
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: si5351: expand compatible strings in documentation
@ 2017-06-30 0:21 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2017-06-30 0:21 UTC (permalink / raw)
To: Brandon Streiff, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: mturquette-rdvid1DuHRBWk0Htik3J/w, mark.rutland-5wv7dgnIgG8,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
To is to nobody? Rob can apply it I suppose.
On 06/29, Brandon Streiff wrote:
> checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
> and so generates warnings about si5351-compatible devices appearing to
> be un-documented. Resolve this by documenting the compatible options
> supported by the clk-si5351 driver individually.
>
> Signed-off-by: Brandon Streiff <brandon.streiff-acOepvfBmUk@public.gmane.org>
> ---
Acked-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: si5351: expand compatible strings in documentation
2017-06-29 13:31 ` Brandon Streiff
@ 2017-07-10 0:51 ` Rob Herring
-1 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2017-07-10 0:51 UTC (permalink / raw)
To: Brandon Streiff
Cc: mturquette, sboyd, mark.rutland, linux-clk, devicetree, linux-kernel
On Thu, Jun 29, 2017 at 08:31:45AM -0500, Brandon Streiff wrote:
> checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
> and so generates warnings about si5351-compatible devices appearing to
> be un-documented. Resolve this by documenting the compatible options
> supported by the clk-si5351 driver individually.
>
> Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
> ---
> Documentation/devicetree/bindings/clock/silabs,si5351.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: si5351: expand compatible strings in documentation
@ 2017-07-10 0:51 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2017-07-10 0:51 UTC (permalink / raw)
To: Brandon Streiff; +Cc: no To-header on input
On Thu, Jun 29, 2017 at 08:31:45AM -0500, Brandon Streiff wrote:
> checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}"
> and so generates warnings about si5351-compatible devices appearing to
> be un-documented. Resolve this by documenting the compatible options
> supported by the clk-si5351 driver individually.
>
> Signed-off-by: Brandon Streiff <brandon.streiff@ni.com>
> ---
> Documentation/devicetree/bindings/clock/silabs,si5351.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-10 0:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 13:31 [PATCH] clk: si5351: expand compatible strings in documentation Brandon Streiff
2017-06-29 13:31 ` Brandon Streiff
2017-06-29 13:31 ` Brandon Streiff
2017-06-30 0:21 ` Stephen Boyd
2017-06-30 0:21 ` Stephen Boyd
2017-07-10 0:51 ` Rob Herring
2017-07-10 0:51 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.