* [PATCH] PM / sleep: constify attribute_group structures.
@ 2017-06-30 4:52 Arvind Yadav
2017-06-30 6:37 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-30 4:52 UTC (permalink / raw)
To: rjw, len.brown, pavel, rafael.j.wysocki; +Cc: linux-pm, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
3802 624 32 4458 116a kernel/power/main.o
File size After adding 'const':
text data bss dec hex filename
3866 560 32 4458 116a kernel/power/main.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
kernel/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/main.c b/kernel/power/main.c
index d401c21..42bd800 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -705,7 +705,7 @@ static ssize_t pm_freeze_timeout_store(struct kobject *kobj,
NULL,
};
-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
.attrs = g,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / sleep: constify attribute_group structures.
2017-06-30 4:52 [PATCH] PM / sleep: constify attribute_group structures Arvind Yadav
@ 2017-06-30 6:37 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2017-06-30 6:37 UTC (permalink / raw)
To: Arvind Yadav; +Cc: rjw, len.brown, rafael.j.wysocki, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On Fri 2017-06-30 10:22:14, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 3802 624 32 4458 116a kernel/power/main.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 3866 560 32 4458 116a kernel/power/main.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> kernel/power/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index d401c21..42bd800 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -705,7 +705,7 @@ static ssize_t pm_freeze_timeout_store(struct kobject *kobj,
> NULL,
> };
>
> -static struct attribute_group attr_group = {
> +static const struct attribute_group attr_group = {
> .attrs = g,
> };
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-30 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 4:52 [PATCH] PM / sleep: constify attribute_group structures Arvind Yadav
2017-06-30 6:37 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.