All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] gcc-6.3: Fix libgfortran build
@ 2017-06-30  9:25 Ricardo Ribalda Delgado
  2017-06-30  9:25 ` [PATCH v2 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-06-30  9:25 UTC (permalink / raw)
  To: openembedded-core

Without this patch libbacktrace cannot be included/link during
libgfortran build.

libbtool: link: cannot find the library `../libbacktrace/libbacktrace.la'
or unhandled argument `../libbacktrace/libbacktrace.la'

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-6.3.inc              |  1 +
 .../gcc/gcc-6.3/0099-Fix-gfortran-build.patch      | 53 ++++++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch

diff --git a/meta/recipes-devtools/gcc/gcc-6.3.inc b/meta/recipes-devtools/gcc/gcc-6.3.inc
index 86b3e9ff19a4..36a116d48fb4 100644
--- a/meta/recipes-devtools/gcc/gcc-6.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
@@ -74,6 +74,7 @@ SRC_URI = "\
            file://0047-libgcc_s-Use-alias-for-__cpu_indicator_init-instead-.patch \
            file://0048-sync-gcc-stddef.h-with-musl.patch \
            file://0054_all_nopie-all-flags.patch \
+           file://0099-Fix-gfortran-build.patch \
            ${BACKPORTS} \
 "
 BACKPORTS = "\
diff --git a/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch b/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
new file mode 100644
index 000000000000..30b135b9780f
--- /dev/null
+++ b/meta/recipes-devtools/gcc/gcc-6.3/0099-Fix-gfortran-build.patch
@@ -0,0 +1,53 @@
+Without this patch libbacktrace cannot be included/link during
+libgfortran build.
+
+libbtool: link: cannot find the library `../libbacktrace/libbacktrace.la'
+or unhandled argument `../libbacktrace/libbacktrace.la'
+
+Upstream-Status: Inappropriate [OE specific]
+Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
+
+diff --git a/libgfortran/Makefile.am b/libgfortran/Makefile.am
+index 39d3e11d223c..b5efe6dfe195 100644
+--- a/libgfortran/Makefile.am
++++ b/libgfortran/Makefile.am
+@@ -37,7 +37,7 @@ toolexeclib_LTLIBRARIES = libgfortran.la
+ toolexeclib_DATA = libgfortran.spec
+ libgfortran_la_LINK = $(LINK) $(libgfortran_la_LDFLAGS)
+ libgfortran_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
+-	$(LTLDFLAGS) $(LIBQUADLIB) ../libbacktrace/libbacktrace.la \
++	$(LTLDFLAGS) $(LIBQUADLIB) ../../libbacktrace/libbacktrace.la \
+ 	-lm $(extra_ldflags_libgfortran) \
+ 	$(version_arg) -Wc,-shared-libgcc
+ libgfortran_la_DEPENDENCIES = $(version_dep) libgfortran.spec $(LIBQUADLIB_DEP)
+@@ -63,7 +63,7 @@ AM_CPPFLAGS = -iquote$(srcdir)/io -I$(srcdir)/$(MULTISRCTOP)../gcc \
+ 	      -I$(MULTIBUILDTOP)../libgcc \
+ 	      -I$(srcdir)/$(MULTISRCTOP)../libbacktrace \
+ 	      -I$(MULTIBUILDTOP)../libbacktrace \
+-	      -I../libbacktrace
++	      -I../../libbacktrace
+ 
+ # Fortran rules for complex multiplication and division
+ AM_CFLAGS += -fcx-fortran-rules
+diff --git a/libgfortran/Makefile.in b/libgfortran/Makefile.in
+index 7ed080cf7b0d..d197fbd6b683 100644
+--- a/libgfortran/Makefile.in
++++ b/libgfortran/Makefile.in
+@@ -598,7 +598,7 @@ toolexeclib_LTLIBRARIES = libgfortran.la
+ toolexeclib_DATA = libgfortran.spec
+ libgfortran_la_LINK = $(LINK) $(libgfortran_la_LDFLAGS)
+ libgfortran_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version` \
+-	$(LTLDFLAGS) $(LIBQUADLIB) ../libbacktrace/libbacktrace.la \
++	$(LTLDFLAGS) $(LIBQUADLIB) ../../libbacktrace/libbacktrace.la \
+ 	-lm $(extra_ldflags_libgfortran) \
+ 	$(version_arg) -Wc,-shared-libgcc
+ 
+@@ -618,7 +618,7 @@ AM_CPPFLAGS = -iquote$(srcdir)/io -I$(srcdir)/$(MULTISRCTOP)../gcc \
+ 	      -I$(MULTIBUILDTOP)../libgcc \
+ 	      -I$(srcdir)/$(MULTISRCTOP)../libbacktrace \
+ 	      -I$(MULTIBUILDTOP)../libbacktrace \
+-	      -I../libbacktrace
++	      -I../../libbacktrace
+ 
+ gfor_io_src = io/size_from_kind.c $(am__append_2)
+ gfor_io_headers = \
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/3] libgfortran: Add missing dependency gcc-cross
  2017-06-30  9:25 [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
@ 2017-06-30  9:25 ` Ricardo Ribalda Delgado
  2017-06-30  9:25 ` [PATCH v2 3/3] libgfortran: Add missing fincludes Ricardo Ribalda Delgado
  2017-07-03 15:22 ` [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Burton, Ross
  2 siblings, 0 replies; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-06-30  9:25 UTC (permalink / raw)
  To: openembedded-core

Due to the fact that the recipe uses INHIBIT_DEFAULT_DEPS, we need to
manually add the cross compiler as a dependency.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-devtools/gcc/libgfortran.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gcc/libgfortran.inc b/meta/recipes-devtools/gcc/libgfortran.inc
index 4846decbb834..3b94c1b85b70 100644
--- a/meta/recipes-devtools/gcc/libgfortran.inc
+++ b/meta/recipes-devtools/gcc/libgfortran.inc
@@ -37,7 +37,7 @@ do_install () {
 }
 
 INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS = "gcc-runtime"
+DEPENDS = "gcc-runtime gcc-cross-${TARGET_ARCH}"
 
 BBCLASSEXTEND = "nativesdk"
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/3] libgfortran: Add missing fincludes
  2017-06-30  9:25 [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
  2017-06-30  9:25 ` [PATCH v2 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
@ 2017-06-30  9:25 ` Ricardo Ribalda Delgado
  2017-07-03 15:22 ` [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Burton, Ross
  2 siblings, 0 replies; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-06-30  9:25 UTC (permalink / raw)
  To: openembedded-core

ERROR: libgfortran-6.3.0-r0 do_package: QA Issue: libgfortran:
Files/directories were installed but not shipped in any package:
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude/ieee_features.mod
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude/ieee_arithmetic.mod
/usr/lib/gcc/x86_64-poky-linux/6.3.0/finclude/ieee_exceptions.mod

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 meta/recipes-devtools/gcc/libgfortran.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/gcc/libgfortran.inc b/meta/recipes-devtools/gcc/libgfortran.inc
index 3b94c1b85b70..5f5d4af7589d 100644
--- a/meta/recipes-devtools/gcc/libgfortran.inc
+++ b/meta/recipes-devtools/gcc/libgfortran.inc
@@ -54,6 +54,7 @@ FILES_${PN}-dev = "\
     ${libdir}/libgfortran.la \
     ${libdir}/gcc/${TARGET_SYS}/${BINV}/libgfortranbegin.* \
     ${libdir}/gcc/${TARGET_SYS}/${BINV}/libcaf_single* \
+    ${libdir}/gcc/${TARGET_SYS}/${BINV}/finclude/ \
 "
 FILES_${PN}-staticdev = "${libdir}/libgfortran.a"
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/3] gcc-6.3: Fix libgfortran build
  2017-06-30  9:25 [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
  2017-06-30  9:25 ` [PATCH v2 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
  2017-06-30  9:25 ` [PATCH v2 3/3] libgfortran: Add missing fincludes Ricardo Ribalda Delgado
@ 2017-07-03 15:22 ` Burton, Ross
  2017-07-03 15:28   ` Ricardo Ribalda Delgado
  2017-07-03 16:06   ` Khem Raj
  2 siblings, 2 replies; 6+ messages in thread
From: Burton, Ross @ 2017-07-03 15:22 UTC (permalink / raw)
  To: Ricardo Ribalda Delgado; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

On 30 June 2017 at 10:25, Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com
> wrote:

> --- a/meta/recipes-devtools/gcc/gcc-6.3.inc
> +++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
>

Is this fixed in gcc 7 (in which case the upstream-status is backport), or
is gcc 7.1 still broken?

Ross

[-- Attachment #2: Type: text/html, Size: 864 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/3] gcc-6.3: Fix libgfortran build
  2017-07-03 15:22 ` [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Burton, Ross
@ 2017-07-03 15:28   ` Ricardo Ribalda Delgado
  2017-07-03 16:06   ` Khem Raj
  1 sibling, 0 replies; 6+ messages in thread
From: Ricardo Ribalda Delgado @ 2017-07-03 15:28 UTC (permalink / raw)
  To: Ross Burton; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

Hi Ross


On 3 Jul 2017 5:22 pm, "Burton, Ross" <ross.burton@intel.com> wrote:

>
> On 30 June 2017 at 10:25, Ricardo Ribalda Delgado <
> ricardo.ribalda@gmail.com> wrote:
>
>> --- a/meta/recipes-devtools/gcc/gcc-6.3.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
>>
>
> Is this fixed in gcc 7 (in which case the upstream-status is backport), or
> is gcc 7.1 still broken?
>

I do not know, at qtec we are following yocto, and currently it is at
version 6.3.

 I could try to build it with gcc7 during this week. and send another patch
if needed.

Regards!


>
> Ross
>

[-- Attachment #2: Type: text/html, Size: 2286 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/3] gcc-6.3: Fix libgfortran build
  2017-07-03 15:22 ` [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Burton, Ross
  2017-07-03 15:28   ` Ricardo Ribalda Delgado
@ 2017-07-03 16:06   ` Khem Raj
  1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2017-07-03 16:06 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Mon, Jul 3, 2017 at 8:22 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 30 June 2017 at 10:25, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
>>
>> --- a/meta/recipes-devtools/gcc/gcc-6.3.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-6.3.inc
>
>
> Is this fixed in gcc 7 (in which case the upstream-status is backport), or
> is gcc 7.1 still broken?

this in needed on gcc 7.1 as well.

>
> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-07-03 16:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30  9:25 [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Ricardo Ribalda Delgado
2017-06-30  9:25 ` [PATCH v2 2/3] libgfortran: Add missing dependency gcc-cross Ricardo Ribalda Delgado
2017-06-30  9:25 ` [PATCH v2 3/3] libgfortran: Add missing fincludes Ricardo Ribalda Delgado
2017-07-03 15:22 ` [PATCH v2 1/3] gcc-6.3: Fix libgfortran build Burton, Ross
2017-07-03 15:28   ` Ricardo Ribalda Delgado
2017-07-03 16:06   ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.