All of lore.kernel.org
 help / color / mirror / Atom feed
* [memcg:since-4.11 538/546] arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared
@ 2017-06-30 11:45 kbuild test robot
  2017-06-30 11:57 ` Michal Hocko
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-06-30 11:45 UTC (permalink / raw)
  To: Rik van Riel; +Cc: kbuild-all, linux-mm, Michal Hocko, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.11
head:   7398359c52bfc0e6188552bc391c717910db1a22
commit: a76bbabc83c87148e249810efba03a1b7a5952d3 [538/546] x86: ascii armor the x86_64 boot init stack canary
config: x86_64-randconfig-x010-201726 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout a76bbabc83c87148e249810efba03a1b7a5952d3
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/linux/stackprotector.h:9:0,
                    from arch/x86/kernel/process.c:22:
   arch/x86/include/asm/stackprotector.h: In function 'boot_init_stack_canary':
>> arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared (first use in this function)
     canary &= CANARY_MASK;
               ^~~~~~~~~~~
   arch/x86/include/asm/stackprotector.h:77:12: note: each undeclared identifier is reported only once for each function it appears in

vim +/CANARY_MASK +77 arch/x86/include/asm/stackprotector.h

    71		 * there it already has some randomness on most systems. Later
    72		 * on during the bootup the random pool has true entropy too.
    73		 */
    74		get_random_bytes(&canary, sizeof(canary));
    75		tsc = rdtsc();
    76		canary += tsc + (tsc << 32UL);
  > 77		canary &= CANARY_MASK;
    78	
    79		current->stack_canary = canary;
    80	#ifdef CONFIG_X86_64

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31021 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [memcg:since-4.11 538/546] arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared
  2017-06-30 11:45 [memcg:since-4.11 538/546] arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared kbuild test robot
@ 2017-06-30 11:57 ` Michal Hocko
  2017-06-30 12:15   ` Michal Hocko
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2017-06-30 11:57 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Rik van Riel, kbuild-all, linux-mm, Andrew Morton

On Fri 30-06-17 19:45:31, Wu Fengguang wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.11
> head:   7398359c52bfc0e6188552bc391c717910db1a22
> commit: a76bbabc83c87148e249810efba03a1b7a5952d3 [538/546] x86: ascii armor the x86_64 boot init stack canary
> config: x86_64-randconfig-x010-201726 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout a76bbabc83c87148e249810efba03a1b7a5952d3
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/stackprotector.h:9:0,
>                     from arch/x86/kernel/process.c:22:
>    arch/x86/include/asm/stackprotector.h: In function 'boot_init_stack_canary':
> >> arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared (first use in this function)
>      canary &= CANARY_MASK;
>                ^~~~~~~~~~~

My fault. I've screwed applying
randomstackprotect-introduce-get_random_canary-function.patch. Will fix
that up and update my mmotm git tree. Sorry about that!
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [memcg:since-4.11 538/546] arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared
  2017-06-30 11:57 ` Michal Hocko
@ 2017-06-30 12:15   ` Michal Hocko
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2017-06-30 12:15 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Rik van Riel, kbuild-all, linux-mm, Andrew Morton

On Fri 30-06-17 13:57:18, Michal Hocko wrote:
> On Fri 30-06-17 19:45:31, Wu Fengguang wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.11
> > head:   7398359c52bfc0e6188552bc391c717910db1a22
> > commit: a76bbabc83c87148e249810efba03a1b7a5952d3 [538/546] x86: ascii armor the x86_64 boot init stack canary
> > config: x86_64-randconfig-x010-201726 (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         git checkout a76bbabc83c87148e249810efba03a1b7a5952d3
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from include/linux/stackprotector.h:9:0,
> >                     from arch/x86/kernel/process.c:22:
> >    arch/x86/include/asm/stackprotector.h: In function 'boot_init_stack_canary':
> > >> arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared (first use in this function)
> >      canary &= CANARY_MASK;
> >                ^~~~~~~~~~~
> 
> My fault. I've screwed applying
> randomstackprotect-introduce-get_random_canary-function.patch. Will fix
> that up and update my mmotm git tree. Sorry about that!

My build test batter hasn't caught it because all my configs use
CONFIG_CC_STACKPROTECTOR_NONE=y and allyesconfig seems to use the same.
I have added a config which enforces CONFIG_CC_STACKPROTECTOR=y to the
tested configs.

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-30 12:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 11:45 [memcg:since-4.11 538/546] arch/x86/include/asm/stackprotector.h:77:12: error: 'CANARY_MASK' undeclared kbuild test robot
2017-06-30 11:57 ` Michal Hocko
2017-06-30 12:15   ` Michal Hocko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.