[PATCH] mini-os: link to libgcc.a to fix build with gcc7

[PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Olaf Hering]

gcc7 generates a call to __udivmoddi4 ...

stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r':
stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4'
make[2]: *** [Makefile:167: stubdom/mini-os-x86_32-grub/mini-os] Error 1

... which the linker only finds if libgcc.a is provided on the commandline.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index ef8559b..b9c1336 100644
--- a/Makefile
+++ b/Makefile
@@ -162,7 +162,7 @@ $(OBJ_DIR)/arch/x86/minios-x86%.lds:  arch/x86/minios-x86.lds.S
 	$(CPP) $(ASFLAGS) -P $< -o $@
 
 $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/minios-$(MINIOS_TARGET_ARCH).lds
-	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o
+	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) $$(gcc -print-libgcc-file-name $(CFLAGS)) -o $@.o
 	$(OBJCOPY) -w -G $(GLOBAL_PREFIX)* -G _start $@.o $@.o
 	$(LD) $(LDFLAGS) $(LDFLAGS_FINAL) $@.o $(EXTRA_OBJS) -o $@
 	gzip -f -9 -c $@ >$@.gz

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Wei Liu]

CC minios-devel

On Mon, Jun 26, 2017 at 03:28:35PM +0200, Olaf Hering wrote:
> gcc7 generates a call to __udivmoddi4 ...
> 
> stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r':
> stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4'
> make[2]: *** [Makefile:167: stubdom/mini-os-x86_32-grub/mini-os] Error 1
> 
> ... which the linker only finds if libgcc.a is provided on the commandline.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ef8559b..b9c1336 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -162,7 +162,7 @@ $(OBJ_DIR)/arch/x86/minios-x86%.lds:  arch/x86/minios-x86.lds.S
>  	$(CPP) $(ASFLAGS) -P $< -o $@
>  
>  $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/minios-$(MINIOS_TARGET_ARCH).lds
> -	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o
> +	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) $$(gcc -print-libgcc-file-name $(CFLAGS)) -o $@.o

Append it to LDLIBS?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Roger Pau Monné]

On Fri, Jun 30, 2017 at 03:41:04PM +0100, Wei Liu wrote:
> CC minios-devel
> 
> On Mon, Jun 26, 2017 at 03:28:35PM +0200, Olaf Hering wrote:
> > gcc7 generates a call to __udivmoddi4 ...
> > 
> > stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r':
> > stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4'
> > make[2]: *** [Makefile:167: stubdom/mini-os-x86_32-grub/mini-os] Error 1
> > 
> > ... which the linker only finds if libgcc.a is provided on the commandline.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index ef8559b..b9c1336 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -162,7 +162,7 @@ $(OBJ_DIR)/arch/x86/minios-x86%.lds:  arch/x86/minios-x86.lds.S
> >  	$(CPP) $(ASFLAGS) -P $< -o $@
> >  
> >  $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/minios-$(MINIOS_TARGET_ARCH).lds
> > -	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o
> > +	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) $$(gcc -print-libgcc-file-name $(CFLAGS)) -o $@.o
> 
> Append it to LDLIBS?

This will break compilation with non-gcc.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Wei Liu]

On Fri, Jun 30, 2017 at 03:48:41PM +0100, Roger Pau Monné wrote:
> On Fri, Jun 30, 2017 at 03:41:04PM +0100, Wei Liu wrote:
> > CC minios-devel
> > 
> > On Mon, Jun 26, 2017 at 03:28:35PM +0200, Olaf Hering wrote:
> > > gcc7 generates a call to __udivmoddi4 ...
> > > 
> > > stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r':
> > > stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4'
> > > make[2]: *** [Makefile:167: stubdom/mini-os-x86_32-grub/mini-os] Error 1
> > > 
> > > ... which the linker only finds if libgcc.a is provided on the commandline.
> > > 
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > ---
> > >  Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/Makefile b/Makefile
> > > index ef8559b..b9c1336 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -162,7 +162,7 @@ $(OBJ_DIR)/arch/x86/minios-x86%.lds:  arch/x86/minios-x86.lds.S
> > >  	$(CPP) $(ASFLAGS) -P $< -o $@
> > >  
> > >  $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/minios-$(MINIOS_TARGET_ARCH).lds
> > > -	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o
> > > +	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) $$(gcc -print-libgcc-file-name $(CFLAGS)) -o $@.o
> > 
> > Append it to LDLIBS?
> 
> This will break compilation with non-gcc.
> 

I thought about that but mini-os is Linux only? I've tried to build it
on FreeBSD.

If I was wrong, then we should tell gcc to not generate code that relies
on libgcc. That seems impossible by reading the doc...

> Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Roger Pau Monné]

On Fri, Jun 30, 2017 at 03:50:23PM +0100, Wei Liu wrote:
> On Fri, Jun 30, 2017 at 03:48:41PM +0100, Roger Pau Monné wrote:
> > On Fri, Jun 30, 2017 at 03:41:04PM +0100, Wei Liu wrote:
> > > CC minios-devel
> > > 
> > > On Mon, Jun 26, 2017 at 03:28:35PM +0200, Olaf Hering wrote:
> > > > gcc7 generates a call to __udivmoddi4 ...
> > > > 
> > > > stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r':
> > > > stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4'
> > > > make[2]: *** [Makefile:167: stubdom/mini-os-x86_32-grub/mini-os] Error 1
> > > > 
> > > > ... which the linker only finds if libgcc.a is provided on the commandline.
> > > > 
> > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > > ---
> > > >  Makefile | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/Makefile b/Makefile
> > > > index ef8559b..b9c1336 100644
> > > > --- a/Makefile
> > > > +++ b/Makefile
> > > > @@ -162,7 +162,7 @@ $(OBJ_DIR)/arch/x86/minios-x86%.lds:  arch/x86/minios-x86.lds.S
> > > >  	$(CPP) $(ASFLAGS) -P $< -o $@
> > > >  
> > > >  $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/minios-$(MINIOS_TARGET_ARCH).lds
> > > > -	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o
> > > > +	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) $$(gcc -print-libgcc-file-name $(CFLAGS)) -o $@.o
> > > 
> > > Append it to LDLIBS?
> > 
> > This will break compilation with non-gcc.
> > 
> 
> I thought about that but mini-os is Linux only? I've tried to build it
> on FreeBSD.

It is Linux only, but you can also use clang on Linux? FWIW, I've
heard someone managed to compile this on NetBSD.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Wei Liu]

On Fri, Jun 30, 2017 at 03:56:24PM +0100, Roger Pau Monné wrote:
> On Fri, Jun 30, 2017 at 03:50:23PM +0100, Wei Liu wrote:
> > On Fri, Jun 30, 2017 at 03:48:41PM +0100, Roger Pau Monné wrote:
> > > On Fri, Jun 30, 2017 at 03:41:04PM +0100, Wei Liu wrote:
> > > > CC minios-devel
> > > > 
> > > > On Mon, Jun 26, 2017 at 03:28:35PM +0200, Olaf Hering wrote:
> > > > > gcc7 generates a call to __udivmoddi4 ...
> > > > > 
> > > > > stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r':
> > > > > stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4'
> > > > > make[2]: *** [Makefile:167: stubdom/mini-os-x86_32-grub/mini-os] Error 1
> > > > > 
> > > > > ... which the linker only finds if libgcc.a is provided on the commandline.
> > > > > 
> > > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > > > ---
> > > > >  Makefile | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/Makefile b/Makefile
> > > > > index ef8559b..b9c1336 100644
> > > > > --- a/Makefile
> > > > > +++ b/Makefile
> > > > > @@ -162,7 +162,7 @@ $(OBJ_DIR)/arch/x86/minios-x86%.lds:  arch/x86/minios-x86.lds.S
> > > > >  	$(CPP) $(ASFLAGS) -P $< -o $@
> > > > >  
> > > > >  $(OBJ_DIR)/$(TARGET): $(OBJS) $(APP_O) arch_lib $(OBJ_DIR)/$(TARGET_ARCH_DIR)/minios-$(MINIOS_TARGET_ARCH).lds
> > > > > -	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) -o $@.o
> > > > > +	$(LD) -r $(LDFLAGS) $(HEAD_OBJ) $(APP_O) $(OBJS) $(LDARCHLIB) $(LDLIBS) $$(gcc -print-libgcc-file-name $(CFLAGS)) -o $@.o
> > > > 
> > > > Append it to LDLIBS?
> > > 
> > > This will break compilation with non-gcc.
> > > 
> > 
> > I thought about that but mini-os is Linux only? I've tried to build it
> > on FreeBSD.
> 
> It is Linux only, but you can also use clang on Linux? FWIW, I've
> heard someone managed to compile this on NetBSD.

On second thought I don't think we want to make this worse. So the
change in this patch should be conditional on gcc.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 326 bytes --]

On Fri, Jun 30, Wei Liu wrote:

> On second thought I don't think we want to make this worse. So the
> change in this patch should be conditional on gcc.

How whould I check for gcc in the Makefile?
In xen.git I see a conditional for clang. I dont have a clang at hand,
perhaps it knows about "-print-libgcc-file-name"?

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] mini-os: link to libgcc.a to fix build with gcc7

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]

On Fri, Jun 30, Olaf Hering wrote:

> On Fri, Jun 30, Wei Liu wrote:
> 
> > On second thought I don't think we want to make this worse. So the
> > change in this patch should be conditional on gcc.
> 
> How whould I check for gcc in the Makefile?
> In xen.git I see a conditional for clang. I dont have a clang at hand,
> perhaps it knows about "-print-libgcc-file-name"?

Mine works fine:

 $  gcc -print-libgcc-file-name
/usr/lib64/gcc/x86_64-suse-linux/7/libgcc.a
 $  clang-3.8 -print-libgcc-file-name
/usr/bin/../lib64/gcc/x86_64-suse-linux/7/libgcc.a


Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel