* [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
@ 2017-06-30 22:34 Gustavo A. R. Silva
2017-07-01 6:06 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-30 22:34 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel, Gustavo A. R. Silva
platform_get_irq() returns an error code, but the ac97c
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.
Print and propagate the return value of platform_get_irq on failure.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
sound/atmel/ac97c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 65e6948..9d2c9d9 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_dbg(&pdev->dev, "could not get irq\n");
- return -ENXIO;
+ dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
+ return irq;
}
pclk = clk_get(&pdev->dev, "ac97_clk");
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
2017-06-30 22:34 [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe() Gustavo A. R. Silva
@ 2017-07-01 6:06 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2017-07-01 6:06 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
On Sat, 01 Jul 2017 00:34:23 +0200,
Gustavo A. R. Silva wrote:
>
> platform_get_irq() returns an error code, but the ac97c
> driver ignores it and always returns -ENXIO. This is not correct,
> and prevents -EPROBE_DEFER from being propagated properly.
> Notice that platform_get_irq() no longer returns 0 on error.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
@ 2017-07-01 6:06 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2017-07-01 6:06 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: alsa-devel, linux-kernel
On Sat, 01 Jul 2017 00:34:23 +0200,
Gustavo A. R. Silva wrote:
>
> platform_get_irq() returns an error code, but the ac97c
> driver ignores it and always returns -ENXIO. This is not correct,
> and prevents -EPROBE_DEFER from being propagated properly.
> Notice that platform_get_irq() no longer returns 0 on error.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-01 6:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 22:34 [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe() Gustavo A. R. Silva
2017-07-01 6:06 ` Takashi Iwai
2017-07-01 6:06 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.