* [PATCH] libnvdimm, btt: convert some info messages to warn/err
@ 2017-07-01 0:32 Vishal Verma
2017-07-01 0:32 ` [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes Vishal Verma
2017-07-01 2:20 ` [PATCH] libnvdimm, btt: convert some info messages to warn/err Dan Williams
0 siblings, 2 replies; 5+ messages in thread
From: Vishal Verma @ 2017-07-01 0:32 UTC (permalink / raw)
To: linux-nvdimm
Some critical messages such as IO errors, metadata failures were printed
with dev_info. Make them louder by upgrading them to dev_warn or
dev_error.
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
drivers/nvdimm/btt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index 4e56e72..2af329d 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -323,7 +323,7 @@ static int btt_log_read(struct arena_info *arena, u32 lane,
old_ent = btt_log_get_old(log);
if (old_ent < 0 || old_ent > 1) {
- dev_info(to_dev(arena),
+ dev_err(to_dev(arena),
"log corruption (%d): lane %d seq [%d, %d]\n",
old_ent, lane, log[0].seq, log[1].seq);
/* TODO set error state? */
@@ -684,7 +684,7 @@ static int discover_arenas(struct btt *btt)
dev_info(to_dev(arena), "No existing arenas\n");
goto out;
} else {
- dev_info(to_dev(arena),
+ dev_err(to_dev(arena),
"Found corrupted metadata!\n");
ret = -ENODEV;
goto out;
@@ -1227,7 +1227,7 @@ static blk_qc_t btt_make_request(struct request_queue *q, struct bio *bio)
err = btt_do_bvec(btt, bip, bvec.bv_page, len, bvec.bv_offset,
op_is_write(bio_op(bio)), iter.bi_sector);
if (err) {
- dev_info(&btt->nd_btt->dev,
+ dev_err(&btt->nd_btt->dev,
"io error in %s sector %lld, len %d,\n",
(op_is_write(bio_op(bio))) ? "WRITE" :
"READ",
@@ -1373,7 +1373,7 @@ static struct btt *btt_init(struct nd_btt *nd_btt, unsigned long long rawsize,
}
if (btt->init_state != INIT_READY && nd_region->ro) {
- dev_info(dev, "%s is read-only, unable to init btt metadata\n",
+ dev_warn(dev, "%s is read-only, unable to init btt metadata\n",
dev_name(&nd_region->dev));
return NULL;
} else if (btt->init_state != INIT_READY) {
--
2.9.3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes
2017-07-01 0:32 [PATCH] libnvdimm, btt: convert some info messages to warn/err Vishal Verma
@ 2017-07-01 0:32 ` Vishal Verma
2017-07-01 1:39 ` Dan Williams
2017-07-01 2:20 ` [PATCH] libnvdimm, btt: convert some info messages to warn/err Dan Williams
1 sibling, 1 reply; 5+ messages in thread
From: Vishal Verma @ 2017-07-01 0:32 UTC (permalink / raw)
To: linux-nvdimm
A leftover from the 'bandaid' fix that disabled BTT error clearing in
rw_bytes resulted in an incorrect check. After we converted these checks
over to use the NVDIMM_IO_ATOMIC flag, the ndns->claim check was both
redundant, and incorrect. Remove it.
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
drivers/nvdimm/claim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
index 8d23f68..f8ad92b 100644
--- a/drivers/nvdimm/claim.c
+++ b/drivers/nvdimm/claim.c
@@ -289,8 +289,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *ndns,
* work around this collision.
*/
if (IS_ALIGNED(offset, 512) && IS_ALIGNED(size, 512)
- && !(flags & NVDIMM_IO_ATOMIC)
- && !ndns->claim) {
+ && !(flags & NVDIMM_IO_ATOMIC)) {
long cleared;
cleared = nvdimm_clear_poison(&ndns->dev,
--
2.9.3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes
2017-07-01 0:32 ` [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes Vishal Verma
@ 2017-07-01 1:39 ` Dan Williams
2017-07-02 5:22 ` Vishal Verma
0 siblings, 1 reply; 5+ messages in thread
From: Dan Williams @ 2017-07-01 1:39 UTC (permalink / raw)
To: Vishal Verma; +Cc: linux-nvdimm
On Fri, Jun 30, 2017 at 5:32 PM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> A leftover from the 'bandaid' fix that disabled BTT error clearing in
> rw_bytes resulted in an incorrect check. After we converted these checks
> over to use the NVDIMM_IO_ATOMIC flag, the ndns->claim check was both
> redundant, and incorrect. Remove it.
>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> drivers/nvdimm/claim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
> index 8d23f68..f8ad92b 100644
> --- a/drivers/nvdimm/claim.c
> +++ b/drivers/nvdimm/claim.c
> @@ -289,8 +289,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *ndns,
> * work around this collision.
> */
> if (IS_ALIGNED(offset, 512) && IS_ALIGNED(size, 512)
> - && !(flags & NVDIMM_IO_ATOMIC)
> - && !ndns->claim) {
> + && !(flags & NVDIMM_IO_ATOMIC)) {
Should this also go to -stable otherwise we won't clear errors on pmem
devices claimed by 'pfn' instances, right?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes
2017-07-01 1:39 ` Dan Williams
@ 2017-07-02 5:22 ` Vishal Verma
0 siblings, 0 replies; 5+ messages in thread
From: Vishal Verma @ 2017-07-02 5:22 UTC (permalink / raw)
To: Dan Williams, Vishal Verma; +Cc: linux-nvdimm
On Fri, 2017-06-30 at 18:39 -0700, Dan Williams wrote:
> On Fri, Jun 30, 2017 at 5:32 PM, Vishal Verma <vishal.l.verma@intel.c
> om> wrote:
> > A leftover from the 'bandaid' fix that disabled BTT error clearing
> > in
> > rw_bytes resulted in an incorrect check. After we converted these
> > checks
> > over to use the NVDIMM_IO_ATOMIC flag, the ndns->claim check was
> > both
> > redundant, and incorrect. Remove it.
> >
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> > ---
> > drivers/nvdimm/claim.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
> > index 8d23f68..f8ad92b 100644
> > --- a/drivers/nvdimm/claim.c
> > +++ b/drivers/nvdimm/claim.c
> > @@ -289,8 +289,7 @@ static int nsio_rw_bytes(struct
> > nd_namespace_common *ndns,
> > * work around this collision.
> > */
> > if (IS_ALIGNED(offset, 512) && IS_ALIGNED(size,
> > 512)
> > - && !(flags & NVDIMM_IO_ATOMIC)
> > - && !ndns->claim) {
> > + && !(flags & NVDIMM_IO_ATOMIC)) {
>
> Should this also go to -stable otherwise we won't clear errors on
> pmem
> devices claimed by 'pfn' instances, right?
Yes I think it should..
Should I just resend with stable CC'd?
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libnvdimm, btt: convert some info messages to warn/err
2017-07-01 0:32 [PATCH] libnvdimm, btt: convert some info messages to warn/err Vishal Verma
2017-07-01 0:32 ` [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes Vishal Verma
@ 2017-07-01 2:20 ` Dan Williams
1 sibling, 0 replies; 5+ messages in thread
From: Dan Williams @ 2017-07-01 2:20 UTC (permalink / raw)
To: Vishal Verma; +Cc: linux-nvdimm
On Fri, Jun 30, 2017 at 5:32 PM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> Some critical messages such as IO errors, metadata failures were printed
> with dev_info. Make them louder by upgrading them to dev_warn or
> dev_error.
>
Ok, applied.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-02 5:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-01 0:32 [PATCH] libnvdimm, btt: convert some info messages to warn/err Vishal Verma
2017-07-01 0:32 ` [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes Vishal Verma
2017-07-01 1:39 ` Dan Williams
2017-07-02 5:22 ` Vishal Verma
2017-07-01 2:20 ` [PATCH] libnvdimm, btt: convert some info messages to warn/err Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.