All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] pixz: new package
@ 2017-07-02 16:11 Vincent Stehle
  2017-07-02 17:08 ` Arnout Vandecappelle
  0 siblings, 1 reply; 8+ messages in thread
From: Vincent Stehle @ 2017-07-02 16:11 UTC (permalink / raw)
  To: buildroot

From: Vincent Stehl? <vincent.stehle@laposte.net>

Add a package for pixz (pronounced pixie), a parallel, indexing version of
xz.

See https://github.com/vasi/pixz

Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
---
 DEVELOPERS             |  1 +
 package/Config.in      |  1 +
 package/pixz/Config.in | 12 ++++++++++++
 package/pixz/pixz.hash |  2 ++
 package/pixz/pixz.mk   | 18 ++++++++++++++++++
 5 files changed, 34 insertions(+)
 create mode 100644 package/pixz/Config.in
 create mode 100644 package/pixz/pixz.hash
 create mode 100644 package/pixz/pixz.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index f9e617ba3..3aaf29bfb 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1715,6 +1715,7 @@ F:	package/trinity/
 N:	Vincent Stehl? <vincent.stehle@laposte.net>
 F:	package/i7z/
 F:	package/msr-tools/
+F:	package/pixz/
 F:	package/uftrace/
 
 N:	Vinicius Tinti <viniciustinti@gmail.com>
diff --git a/package/Config.in b/package/Config.in
index 84e23ea63..3c7719278 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -64,6 +64,7 @@ menu "Compressors and decompressors"
 	source "package/lzip/Config.in"
 	source "package/lzop/Config.in"
 	source "package/p7zip/Config.in"
+	source "package/pixz/Config.in"
 	source "package/unrar/Config.in"
 	source "package/unzip/Config.in"
 	source "package/xz/Config.in"
diff --git a/package/pixz/Config.in b/package/pixz/Config.in
new file mode 100644
index 000000000..e5b1b095e
--- /dev/null
+++ b/package/pixz/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PIXZ
+	bool "pixz"
+	depends on BR2_PACKAGE_LIBARCHIVE
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_XZ
+	help
+	  Pixz (pronounced pixie) is a parallel, indexing version of xz.
+
+	  https://github.com/vasi/pixz
+
+comment "pixz needs a toolchain w/ threads, and libarchive"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_LIBARCHIVE
diff --git a/package/pixz/pixz.hash b/package/pixz/pixz.hash
new file mode 100644
index 000000000..3089bcd90
--- /dev/null
+++ b/package/pixz/pixz.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
diff --git a/package/pixz/pixz.mk b/package/pixz/pixz.mk
new file mode 100644
index 000000000..04dba2985
--- /dev/null
+++ b/package/pixz/pixz.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# pixz
+#
+################################################################################
+
+PIXZ_VERSION = 1.0.6
+PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION)
+PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz
+PIXZ_DEPENDENCIES = host-pkgconf libarchive xz
+PIXZ_LICENSE = BSD-2-Clause
+PIXZ_LICENSE_FILES = LICENSE
+
+# The configure script does not know how to test for the manpage presence when
+# cross-compiling; help it a bit.
+PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes
+
+$(eval $(autotools-package))
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] pixz: new package
  2017-07-02 16:11 [Buildroot] [PATCH] pixz: new package Vincent Stehle
@ 2017-07-02 17:08 ` Arnout Vandecappelle
  2017-07-02 20:31   ` Vincent Stehlé
  2017-07-02 21:27   ` [Buildroot] [PATCH v2] " Vincent Stehle
  0 siblings, 2 replies; 8+ messages in thread
From: Arnout Vandecappelle @ 2017-07-02 17:08 UTC (permalink / raw)
  To: buildroot

 Hi Vincent,

On 02-07-17 18:11, Vincent Stehle wrote:
> From: Vincent Stehl? <vincent.stehle@laposte.net>
> 
> Add a package for pixz (pronounced pixie), a parallel, indexing version of
> xz.

 Would this package be able to replace host-xz on systems that need to build
host-xz?

> 
> See https://github.com/vasi/pixz
> 
> Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
> ---
>  DEVELOPERS             |  1 +
>  package/Config.in      |  1 +
>  package/pixz/Config.in | 12 ++++++++++++
>  package/pixz/pixz.hash |  2 ++
>  package/pixz/pixz.mk   | 18 ++++++++++++++++++
>  5 files changed, 34 insertions(+)
>  create mode 100644 package/pixz/Config.in
>  create mode 100644 package/pixz/pixz.hash
>  create mode 100644 package/pixz/pixz.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index f9e617ba3..3aaf29bfb 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1715,6 +1715,7 @@ F:	package/trinity/
>  N:	Vincent Stehl? <vincent.stehle@laposte.net>
>  F:	package/i7z/
>  F:	package/msr-tools/
> +F:	package/pixz/
>  F:	package/uftrace/
>  
>  N:	Vinicius Tinti <viniciustinti@gmail.com>
> diff --git a/package/Config.in b/package/Config.in
> index 84e23ea63..3c7719278 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -64,6 +64,7 @@ menu "Compressors and decompressors"
>  	source "package/lzip/Config.in"
>  	source "package/lzop/Config.in"
>  	source "package/p7zip/Config.in"
> +	source "package/pixz/Config.in"
>  	source "package/unrar/Config.in"
>  	source "package/unzip/Config.in"
>  	source "package/xz/Config.in"
> diff --git a/package/pixz/Config.in b/package/pixz/Config.in
> new file mode 100644
> index 000000000..e5b1b095e
> --- /dev/null
> +++ b/package/pixz/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PIXZ
> +	bool "pixz"
> +	depends on BR2_PACKAGE_LIBARCHIVE

 Why depends on and not select?

	depends on BR2_TOOLCHAIN_HAS_THREADS
	depends on BR2_USE_WCHAR # libarchive
	select BR2_PACKAGE_LIBARCHIVE

> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_XZ
> +	help
> +	  Pixz (pronounced pixie) is a parallel, indexing version of xz.
> +
> +	  https://github.com/vasi/pixz
> +
> +comment "pixz needs a toolchain w/ threads, and libarchive"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_LIBARCHIVE
> diff --git a/package/pixz/pixz.hash b/package/pixz/pixz.hash
> new file mode 100644
> index 000000000..3089bcd90
> --- /dev/null
> +++ b/package/pixz/pixz.hash
> @@ -0,0 +1,2 @@
> +# Locally computed:
> +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
> diff --git a/package/pixz/pixz.mk b/package/pixz/pixz.mk
> new file mode 100644
> index 000000000..04dba2985
> --- /dev/null
> +++ b/package/pixz/pixz.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# pixz
> +#
> +################################################################################
> +
> +PIXZ_VERSION = 1.0.6
> +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION)
> +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz
> +PIXZ_DEPENDENCIES = host-pkgconf libarchive xz

 Does it really depend on xz? Ah yes, for liblzma. Then you should also select it.

> +PIXZ_LICENSE = BSD-2-Clause
> +PIXZ_LICENSE_FILES = LICENSE
> +
> +# The configure script does not know how to test for the manpage presence when
> +# cross-compiling; help it a bit.
> +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes

 The comment sounds like putting this to "yes" would actually build the manpage,
but the reverse is true... How about:

# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when
# cross-compiling, which causes configure to try to regenerate it. So
# give it a hint to say that it actually is present.

 Regards,
 Arnout

> +
> +$(eval $(autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] pixz: new package
  2017-07-02 17:08 ` Arnout Vandecappelle
@ 2017-07-02 20:31   ` Vincent Stehlé
  2017-07-02 21:27   ` [Buildroot] [PATCH v2] " Vincent Stehle
  1 sibling, 0 replies; 8+ messages in thread
From: Vincent Stehlé @ 2017-07-02 20:31 UTC (permalink / raw)
  To: buildroot

On 07/02/2017 07:08 PM, Arnout Vandecappelle wrote:
>  Hi Vincent,
> 
> On 02-07-17 18:11, Vincent Stehle wrote:
>> From: Vincent Stehl? <vincent.stehle@laposte.net>
>>
>> Add a package for pixz (pronounced pixie), a parallel, indexing version of
>> xz.
> 
>  Would this package be able to replace host-xz on systems that need to build
> host-xz?

Hi Arnout,

Thanks for the review!

Actually I use a version of this package just slightly modified to build
host-pixz and it works fine. I guess you are right, this would be useful
to offer it as an alternative to host-xz.

Although I suspect we cannot just replace xz by pixz by default, as I
needed once in a while to reduce the number of threads manually, just to
avoid using too much memory.

If we want to propose pixz as an alternative to xz, shall we go for a
virtual package for host-xz?

> 
>>
>> See https://github.com/vasi/pixz
>>
>> Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
>> ---
>>  DEVELOPERS             |  1 +
>>  package/Config.in      |  1 +
>>  package/pixz/Config.in | 12 ++++++++++++
>>  package/pixz/pixz.hash |  2 ++
>>  package/pixz/pixz.mk   | 18 ++++++++++++++++++
>>  5 files changed, 34 insertions(+)
>>  create mode 100644 package/pixz/Config.in
>>  create mode 100644 package/pixz/pixz.hash
>>  create mode 100644 package/pixz/pixz.mk
>>
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index f9e617ba3..3aaf29bfb 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1715,6 +1715,7 @@ F:	package/trinity/
>>  N:	Vincent Stehl? <vincent.stehle@laposte.net>
>>  F:	package/i7z/
>>  F:	package/msr-tools/
>> +F:	package/pixz/
>>  F:	package/uftrace/
>>  
>>  N:	Vinicius Tinti <viniciustinti@gmail.com>
>> diff --git a/package/Config.in b/package/Config.in
>> index 84e23ea63..3c7719278 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -64,6 +64,7 @@ menu "Compressors and decompressors"
>>  	source "package/lzip/Config.in"
>>  	source "package/lzop/Config.in"
>>  	source "package/p7zip/Config.in"
>> +	source "package/pixz/Config.in"
>>  	source "package/unrar/Config.in"
>>  	source "package/unzip/Config.in"
>>  	source "package/xz/Config.in"
>> diff --git a/package/pixz/Config.in b/package/pixz/Config.in
>> new file mode 100644
>> index 000000000..e5b1b095e
>> --- /dev/null
>> +++ b/package/pixz/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_PIXZ
>> +	bool "pixz"
>> +	depends on BR2_PACKAGE_LIBARCHIVE
> 
>  Why depends on and not select?
> 
> 	depends on BR2_TOOLCHAIN_HAS_THREADS
> 	depends on BR2_USE_WCHAR # libarchive
> 	select BR2_PACKAGE_LIBARCHIVE
> 

I hesitated for this one. As libarchive needs wchar and has sub-options,
I thought we might let the user do the selection after all. But I like
your solution of adding wchar at pixz level better, thanks.

>> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>> +	select BR2_PACKAGE_XZ
>> +	help
>> +	  Pixz (pronounced pixie) is a parallel, indexing version of xz.
>> +
>> +	  https://github.com/vasi/pixz
>> +
>> +comment "pixz needs a toolchain w/ threads, and libarchive"
>> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_LIBARCHIVE
>> diff --git a/package/pixz/pixz.hash b/package/pixz/pixz.hash
>> new file mode 100644
>> index 000000000..3089bcd90
>> --- /dev/null
>> +++ b/package/pixz/pixz.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed:
>> +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
>> diff --git a/package/pixz/pixz.mk b/package/pixz/pixz.mk
>> new file mode 100644
>> index 000000000..04dba2985
>> --- /dev/null
>> +++ b/package/pixz/pixz.mk
>> @@ -0,0 +1,18 @@
>> +################################################################################
>> +#
>> +# pixz
>> +#
>> +################################################################################
>> +
>> +PIXZ_VERSION = 1.0.6
>> +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION)
>> +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz
>> +PIXZ_DEPENDENCIES = host-pkgconf libarchive xz
> 
>  Does it really depend on xz? Ah yes, for liblzma. Then you should also select it.
> 
>> +PIXZ_LICENSE = BSD-2-Clause
>> +PIXZ_LICENSE_FILES = LICENSE
>> +
>> +# The configure script does not know how to test for the manpage presence when
>> +# cross-compiling; help it a bit.
>> +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes
> 
>  The comment sounds like putting this to "yes" would actually build the manpage,
> but the reverse is true... How about:
> 
> # pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when
> # cross-compiling, which causes configure to try to regenerate it. So
> # give it a hint to say that it actually is present.

Sure, this is more explicit, thanks.

I'll resubmit a v2.

Best regards,

Vincent.

> 
>  Regards,
>  Arnout
> 
>> +
>> +$(eval $(autotools-package))
>>
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] pixz: new package
  2017-07-02 17:08 ` Arnout Vandecappelle
  2017-07-02 20:31   ` Vincent Stehlé
@ 2017-07-02 21:27   ` Vincent Stehle
  2017-07-03 13:06     ` Arnout Vandecappelle
  1 sibling, 1 reply; 8+ messages in thread
From: Vincent Stehle @ 2017-07-02 21:27 UTC (permalink / raw)
  To: buildroot

From: Vincent Stehl? <vincent.stehle@laposte.net>

Add a package for pixz (pronounced pixie), a parallel, indexing version of
xz.

See https://github.com/vasi/pixz

Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
Cc: Arnout Vandecappelle <arnout@mind.be>
---


Changes since v1:
-----------------
- Select libarchive and depend on wchar, as suggested by Arnout
- Rework comment on conf_env, as suggested by Arnout
- Make pixz a host package, too. This to prepare making it a selectable
  alternative to host-xz, as suggested by Arnout
- Change my e-mail address in DEVELOPERS


 DEVELOPERS             |  3 ++-
 package/Config.in      |  1 +
 package/pixz/Config.in | 13 +++++++++++++
 package/pixz/pixz.hash |  2 ++
 package/pixz/pixz.mk   | 21 +++++++++++++++++++++
 5 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 package/pixz/Config.in
 create mode 100644 package/pixz/pixz.hash
 create mode 100644 package/pixz/pixz.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index c0e0d40a9..d176d554f 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1712,9 +1712,10 @@ F:	package/openmpi/
 F:	package/pinentry/
 F:	package/trinity/
 
-N:	Vincent Stehl? <vincent.stehle@intel.com>
+N:	Vincent Stehl? <vincent.stehle@laposte.net>
 F:	package/i7z/
 F:	package/msr-tools/
+F:	package/pixz/
 
 N:	Vinicius Tinti <viniciustinti@gmail.com>
 F:	package/python-thrift/
diff --git a/package/Config.in b/package/Config.in
index fdfcd02df..b3f4f28fa 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -64,6 +64,7 @@ menu "Compressors and decompressors"
 	source "package/lzip/Config.in"
 	source "package/lzop/Config.in"
 	source "package/p7zip/Config.in"
+	source "package/pixz/Config.in"
 	source "package/unrar/Config.in"
 	source "package/unzip/Config.in"
 	source "package/xz/Config.in"
diff --git a/package/pixz/Config.in b/package/pixz/Config.in
new file mode 100644
index 000000000..f7ca01572
--- /dev/null
+++ b/package/pixz/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_PIXZ
+	bool "pixz"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_WCHAR # libarchive
+	select BR2_PACKAGE_LIBARCHIVE
+	select BR2_PACKAGE_XZ
+	help
+	  Pixz (pronounced pixie) is a parallel, indexing version of xz.
+
+	  https://github.com/vasi/pixz
+
+comment "pixz needs a toolchain w/ threads, wchar"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
diff --git a/package/pixz/pixz.hash b/package/pixz/pixz.hash
new file mode 100644
index 000000000..3089bcd90
--- /dev/null
+++ b/package/pixz/pixz.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
diff --git a/package/pixz/pixz.mk b/package/pixz/pixz.mk
new file mode 100644
index 000000000..a23f49d35
--- /dev/null
+++ b/package/pixz/pixz.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# pixz
+#
+################################################################################
+
+PIXZ_VERSION = 1.0.6
+PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION)
+PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz
+PIXZ_DEPENDENCIES = host-pkgconf libarchive xz
+HOST_PIXZ_DEPENDENCIES = host-pkgconf host-libarchive host-xz
+PIXZ_LICENSE = BSD-2-Clause
+PIXZ_LICENSE_FILES = LICENSE
+
+# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when
+# cross-compiling, which causes configure to try to regenerate it. So give it a
+# hint to say that it actually is present.
+PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] pixz: new package
  2017-07-02 21:27   ` [Buildroot] [PATCH v2] " Vincent Stehle
@ 2017-07-03 13:06     ` Arnout Vandecappelle
  2017-07-03 20:09       ` [Buildroot] [PATCH v3] " Vincent Stehle
  0 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2017-07-03 13:06 UTC (permalink / raw)
  To: buildroot

 Hi Vincent,

On 02-07-17 23:27, Vincent Stehle wrote:
> From: Vincent Stehl? <vincent.stehle@laposte.net>
> 
> Add a package for pixz (pronounced pixie), a parallel, indexing version of
> xz.
> 
> See https://github.com/vasi/pixz
> 
> Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
> 
> 
> Changes since v1:
> -----------------
> - Select libarchive and depend on wchar, as suggested by Arnout
> - Rework comment on conf_env, as suggested by Arnout
> - Make pixz a host package, too. This to prepare making it a selectable
>   alternative to host-xz, as suggested by Arnout

 Since pixz in fact uses xz, it seems like a bad idea to use it as a replacement
for host-xz. It's not as if the xz tarball extraction is such an important part
of build time... So the host package can be removed I guess.

 Sorry for changing my mind.

 Otherwise the patch looks good, so after removing the two lines referring to
the host package you can add my

 Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout


> - Change my e-mail address in DEVELOPERS
> 
> 
>  DEVELOPERS             |  3 ++-
>  package/Config.in      |  1 +
>  package/pixz/Config.in | 13 +++++++++++++
>  package/pixz/pixz.hash |  2 ++
>  package/pixz/pixz.mk   | 21 +++++++++++++++++++++
>  5 files changed, 39 insertions(+), 1 deletion(-)
>  create mode 100644 package/pixz/Config.in
>  create mode 100644 package/pixz/pixz.hash
>  create mode 100644 package/pixz/pixz.mk
> 

[snip]


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] pixz: new package
  2017-07-03 13:06     ` Arnout Vandecappelle
@ 2017-07-03 20:09       ` Vincent Stehle
  2017-07-03 20:37         ` Arnout Vandecappelle
  2017-07-04  7:06         ` Thomas Petazzoni
  0 siblings, 2 replies; 8+ messages in thread
From: Vincent Stehle @ 2017-07-03 20:09 UTC (permalink / raw)
  To: buildroot

From: Vincent Stehl? <vincent.stehle@laposte.net>

Add a package for pixz (pronounced pixie), a parallel, indexing version of
xz.

See https://github.com/vasi/pixz

Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---


Hi Arnout,

Here is the patch with the host package removal.

I agree that if we do not plan to use pixz as a host package right now it
is cleaner not to add the host package lines. And I think this is no big
deal anyway as this is straightforward to add later if needed.

Also I wanted to ask you if you are ok that I update the DEVELOPERS file in
this same patch, please? Romain suggested for uftrace that I rather
separate it. This is up to you really; do you want a v4 with the DEVELOPERS
change moved out of the way?

Thank you for your review.

Best regards,

Vincent.

Changes since v2:
-----------------
- Remove the two lines of host package

Changes since v1:
-----------------
- Select libarchive and depend on wchar, as suggested by Arnout
- Rework comment on conf_env, as suggested by Arnout

- Make pixz a host package, too. This to prepare making it a selectable
  alternative to host-xz, as suggested by Arnout

- Change my e-mail address in DEVELOPERS


 DEVELOPERS             |  3 ++-
 package/Config.in      |  1 +
 package/pixz/Config.in | 13 +++++++++++++
 package/pixz/pixz.hash |  2 ++
 package/pixz/pixz.mk   | 19 +++++++++++++++++++
 5 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 package/pixz/Config.in
 create mode 100644 package/pixz/pixz.hash
 create mode 100644 package/pixz/pixz.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index d121bd816..9f07259b7 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1716,9 +1716,10 @@ F:	package/openmpi/
 F:	package/pinentry/
 F:	package/trinity/
 
-N:	Vincent Stehl? <vincent.stehle@intel.com>
+N:	Vincent Stehl? <vincent.stehle@laposte.net>
 F:	package/i7z/
 F:	package/msr-tools/
+F:	package/pixz/
 
 N:	Vinicius Tinti <viniciustinti@gmail.com>
 F:	package/python-thrift/
diff --git a/package/Config.in b/package/Config.in
index 355aa5201..302bb30b1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -64,6 +64,7 @@ menu "Compressors and decompressors"
 	source "package/lzip/Config.in"
 	source "package/lzop/Config.in"
 	source "package/p7zip/Config.in"
+	source "package/pixz/Config.in"
 	source "package/unrar/Config.in"
 	source "package/unzip/Config.in"
 	source "package/xz/Config.in"
diff --git a/package/pixz/Config.in b/package/pixz/Config.in
new file mode 100644
index 000000000..f7ca01572
--- /dev/null
+++ b/package/pixz/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_PIXZ
+	bool "pixz"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_WCHAR # libarchive
+	select BR2_PACKAGE_LIBARCHIVE
+	select BR2_PACKAGE_XZ
+	help
+	  Pixz (pronounced pixie) is a parallel, indexing version of xz.
+
+	  https://github.com/vasi/pixz
+
+comment "pixz needs a toolchain w/ threads, wchar"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
diff --git a/package/pixz/pixz.hash b/package/pixz/pixz.hash
new file mode 100644
index 000000000..3089bcd90
--- /dev/null
+++ b/package/pixz/pixz.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
diff --git a/package/pixz/pixz.mk b/package/pixz/pixz.mk
new file mode 100644
index 000000000..8d80f7861
--- /dev/null
+++ b/package/pixz/pixz.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# pixz
+#
+################################################################################
+
+PIXZ_VERSION = 1.0.6
+PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION)
+PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz
+PIXZ_DEPENDENCIES = host-pkgconf libarchive xz
+PIXZ_LICENSE = BSD-2-Clause
+PIXZ_LICENSE_FILES = LICENSE
+
+# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when
+# cross-compiling, which causes configure to try to regenerate it. So give it a
+# hint to say that it actually is present.
+PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes
+
+$(eval $(autotools-package))
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] pixz: new package
  2017-07-03 20:09       ` [Buildroot] [PATCH v3] " Vincent Stehle
@ 2017-07-03 20:37         ` Arnout Vandecappelle
  2017-07-04  7:06         ` Thomas Petazzoni
  1 sibling, 0 replies; 8+ messages in thread
From: Arnout Vandecappelle @ 2017-07-03 20:37 UTC (permalink / raw)
  To: buildroot



On 03-07-17 22:09, Vincent Stehle wrote:
> Also I wanted to ask you if you are ok that I update the DEVELOPERS file in
> this same patch, please? Romain suggested for uftrace that I rather
> separate it. This is up to you really; do you want a v4 with the DEVELOPERS
> change moved out of the way?

 Romain said that because now you have two patches (uftrace and this one) that
make the same change to the developer file, which will obviously create a
conflict when applying...

 This one is OK now since Peter will apply it right away I think.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] pixz: new package
  2017-07-03 20:09       ` [Buildroot] [PATCH v3] " Vincent Stehle
  2017-07-03 20:37         ` Arnout Vandecappelle
@ 2017-07-04  7:06         ` Thomas Petazzoni
  1 sibling, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2017-07-04  7:06 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  3 Jul 2017 22:09:23 +0200, Vincent Stehle wrote:
> From: Vincent Stehl? <vincent.stehle@laposte.net>
> 
> Add a package for pixz (pronounced pixie), a parallel, indexing version of
> xz.
> 
> See https://github.com/vasi/pixz
> 
> Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-04  7:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-02 16:11 [Buildroot] [PATCH] pixz: new package Vincent Stehle
2017-07-02 17:08 ` Arnout Vandecappelle
2017-07-02 20:31   ` Vincent Stehlé
2017-07-02 21:27   ` [Buildroot] [PATCH v2] " Vincent Stehle
2017-07-03 13:06     ` Arnout Vandecappelle
2017-07-03 20:09       ` [Buildroot] [PATCH v3] " Vincent Stehle
2017-07-03 20:37         ` Arnout Vandecappelle
2017-07-04  7:06         ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.