* [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
@ 2017-07-04 15:21 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2017-07-04 15:21 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
Currently the non-error path where val is greater than zero falls through
to the default case that sets the error return to -EINVAL. Add in
the missing break.
Detected by CoverityScan, CID#1449376 ("Missing break in switch")
Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/core/filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/filter.c b/net/core/filter.c
index 94169572d002..c7f737058d89 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
tp->snd_cwnd_clamp = val;
tp->snd_ssthresh = val;
}
+ break;
default:
ret = -EINVAL;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
@ 2017-07-04 15:21 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2017-07-04 15:21 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
Currently the non-error path where val is greater than zero falls through
to the default case that sets the error return to -EINVAL. Add in
the missing break.
Detected by CoverityScan, CID#1449376 ("Missing break in switch")
Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/core/filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/filter.c b/net/core/filter.c
index 94169572d002..c7f737058d89 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
tp->snd_cwnd_clamp = val;
tp->snd_ssthresh = val;
}
+ break;
default:
ret = -EINVAL;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
2017-07-04 15:21 ` Colin King
@ 2017-07-04 15:26 ` Daniel Borkmann
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Borkmann @ 2017-07-04 15:26 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel, Lawrence Brakmo
[ +Lawrence ]
On 07/04/2017 05:21 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> net/core/filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 94169572d002..c7f737058d89 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
> tp->snd_cwnd_clamp = val;
> tp->snd_ssthresh = val;
> }
> + break;
> default:
> ret = -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
@ 2017-07-04 15:26 ` Daniel Borkmann
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Borkmann @ 2017-07-04 15:26 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel, Lawrence Brakmo
[ +Lawrence ]
On 07/04/2017 05:21 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> net/core/filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 94169572d002..c7f737058d89 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
> tp->snd_cwnd_clamp = val;
> tp->snd_ssthresh = val;
> }
> + break;
> default:
> ret = -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
2017-07-04 15:26 ` Daniel Borkmann
@ 2017-07-04 18:26 ` Lawrence Brakmo
-1 siblings, 0 replies; 8+ messages in thread
From: Lawrence Brakmo @ 2017-07-04 18:26 UTC (permalink / raw)
To: Daniel Borkmann, Colin King, Alexei Starovoitov,
David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
On 7/4/17, 8:26 AM, "netdev-owner@vger.kernel.org on behalf of Daniel Borkmann" <netdev-owner@vger.kernel.org on behalf of daniel@iogearbox.net> wrote:
[ +Lawrence ]
On 07/04/2017 05:21 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Daniel Borkmann daniel@iogearbox.net
Acked-by: Lawrence Brakmo <brakmo@fb.com>
> ---
> net/core/filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 94169572d002..c7f737058d89 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
> tp->snd_cwnd_clamp = val;
> tp->snd_ssthresh = val;
> }
> + break;
> default:
> ret = -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
@ 2017-07-04 18:26 ` Lawrence Brakmo
0 siblings, 0 replies; 8+ messages in thread
From: Lawrence Brakmo @ 2017-07-04 18:26 UTC (permalink / raw)
To: Daniel Borkmann, Colin King, Alexei Starovoitov,
David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
DQoNCk9uIDcvNC8xNywgODoyNiBBTSwgIm5ldGRldi1vd25lckB2Z2VyLmtlcm5lbC5vcmcgb24g
YmVoYWxmIG9mIERhbmllbCBCb3JrbWFubiIgPG5ldGRldi1vd25lckB2Z2VyLmtlcm5lbC5vcmcg
b24gYmVoYWxmIG9mIGRhbmllbEBpb2dlYXJib3gubmV0PiB3cm90ZToNCg0KICAgIFsgK0xhd3Jl
bmNlIF0NCiAgICANCiAgICBPbiAwNy8wNC8yMDE3IDA1OjIxIFBNLCBDb2xpbiBLaW5nIHdyb3Rl
Og0KICAgID4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4N
CiAgICA+DQogICAgPiBUaGVyZSBhcHBlYXJzIHRvIGJlIGEgbWlzc2luZyBicmVhayBpbiB0aGUg
VENQX0JQRl9TTkRDV05EX0NMQU1QIGNhc2UuDQogICAgPiBDdXJyZW50bHkgdGhlIG5vbi1lcnJv
ciBwYXRoIHdoZXJlIHZhbCBpcyBncmVhdGVyIHRoYW4gemVybyBmYWxscyB0aHJvdWdoDQogICAg
PiB0byB0aGUgZGVmYXVsdCBjYXNlIHRoYXQgc2V0cyB0aGUgZXJyb3IgcmV0dXJuIHRvIC1FSU5W
QUwuIEFkZCBpbg0KICAgID4gdGhlIG1pc3NpbmcgYnJlYWsuDQogICAgPg0KICAgID4gRGV0ZWN0
ZWQgYnkgQ292ZXJpdHlTY2FuLCBDSUQjMTQ0OTM3NiAoIk1pc3NpbmcgYnJlYWsgaW4gc3dpdGNo
IikNCiAgICA+DQogICAgPiBGaXhlczogMTNiZjk2NDExYWQyICgiYnBmOiBBZGRzIHN1cHBvcnQg
Zm9yIHNldHRpbmcgc25kY3duZCBjbGFtcCIpDQogICAgPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJ
YW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KICAgIA0KICAgIEFja2VkLWJ5OiBE
YW5pZWwgQm9ya21hbm4gZGFuaWVsQGlvZ2VhcmJveC5uZXQNCkFja2VkLWJ5OiBMYXdyZW5jZSBC
cmFrbW8gPGJyYWttb0BmYi5jb20+DQogICAgDQogICAgPiAtLS0NCiAgICA+ICAgbmV0L2NvcmUv
ZmlsdGVyLmMgfCAxICsNCiAgICA+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspDQog
ICAgPg0KICAgID4gZGlmZiAtLWdpdCBhL25ldC9jb3JlL2ZpbHRlci5jIGIvbmV0L2NvcmUvZmls
dGVyLmMNCiAgICA+IGluZGV4IDk0MTY5NTcyZDAwMi4uYzdmNzM3MDU4ZDg5IDEwMDY0NA0KICAg
ID4gLS0tIGEvbmV0L2NvcmUvZmlsdGVyLmMNCiAgICA+ICsrKyBiL25ldC9jb3JlL2ZpbHRlci5j
DQogICAgPiBAQCAtMjg2Nyw2ICsyODY3LDcgQEAgQlBGX0NBTExfNShicGZfc2V0c29ja29wdCwg
c3RydWN0IGJwZl9zb2NrX29wc19rZXJuICosIGJwZl9zb2NrLA0KICAgID4gICAJCQkJCXRwLT5z
bmRfY3duZF9jbGFtcCA9IHZhbDsNCiAgICA+ICAgCQkJCQl0cC0+c25kX3NzdGhyZXNoID0gdmFs
Ow0KICAgID4gICAJCQkJfQ0KICAgID4gKwkJCQlicmVhazsNCiAgICA+ICAgCQkJZGVmYXVsdDoN
CiAgICA+ICAgCQkJCXJldCA9IC1FSU5WQUw7DQogICAgPiAgIAkJCX0NCiAgICA+DQogICAgDQog
ICAgDQoNCg=
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
2017-07-04 15:21 ` Colin King
@ 2017-07-05 8:09 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2017-07-05 8:09 UTC (permalink / raw)
To: colin.king; +Cc: ast, daniel, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 4 Jul 2017 16:21:12 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
@ 2017-07-05 8:09 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2017-07-05 8:09 UTC (permalink / raw)
To: colin.king; +Cc: ast, daniel, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 4 Jul 2017 16:21:12 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-05 8:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-04 15:21 [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case Colin King
2017-07-04 15:21 ` Colin King
2017-07-04 15:26 ` Daniel Borkmann
2017-07-04 15:26 ` Daniel Borkmann
2017-07-04 18:26 ` Lawrence Brakmo
2017-07-04 18:26 ` Lawrence Brakmo
2017-07-05 8:09 ` David Miller
2017-07-05 8:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.