All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined
Date: Wed, 05 Jul 2017 09:09:58 +0100 (WEST)	[thread overview]
Message-ID: <20170705.090958.2221041161435076999.davem@davemloft.net> (raw)
In-Reply-To: <20170704150959.18315-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Tue,  4 Jul 2017 16:09:59 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> When macro MACB_EXT_DESC is defined we end up with two identical
> return statements and just one is sufficient. Remove the extra
> return.
> 
> Detected by CoverityScan, CID#1449361 ("Structurally dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined
Date: Wed, 05 Jul 2017 08:09:58 +0000	[thread overview]
Message-ID: <20170705.090958.2221041161435076999.davem@davemloft.net> (raw)
In-Reply-To: <20170704150959.18315-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Tue,  4 Jul 2017 16:09:59 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> When macro MACB_EXT_DESC is defined we end up with two identical
> return statements and just one is sufficient. Remove the extra
> return.
> 
> Detected by CoverityScan, CID#1449361 ("Structurally dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

  parent reply	other threads:[~2017-07-05  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 15:09 [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined Colin King
2017-07-04 15:09 ` Colin King
2017-07-05  8:03 ` Nicolas Ferre
2017-07-05  8:03   ` Nicolas Ferre
2017-07-05  8:09 ` David Miller [this message]
2017-07-05  8:09   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705.090958.2221041161435076999.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.