* Re: valgrind support for xen4.7+
2017-04-12 5:04 valgrind support for xen4.7+ Glenn Enright
@ 2017-04-12 9:25 ` Wei Liu
2017-07-05 6:59 ` Olaf Hering
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-04-12 9:25 UTC (permalink / raw)
To: Glenn Enright; +Cc: Wei Liu, xen-devel
On Wed, Apr 12, 2017 at 05:04:41PM +1200, Glenn Enright wrote:
> Hi there
>
> Has anyone seen or been working on patches for valgrind for recent versions
> of xen?
>
> I was trying 3.13 from SVN against xen 4.7.2 and see that support for that
> version is not present. Per https://blog.xenproject.org/2013/01/18/using-valgrind-to-debug-xen-toolstacks/
>
> A starter patch is below, but its probably wrong or incomplete. It does let
> me run
>
> If valgrind is not the way any more, can anyone suggest any alternatives on
> testing for memory leaks?
>
It should still be useful.
> Regards, Glenn
> http://rimuhosting.com
>
> Index: coregrind/m_syswrap/syswrap-xen.c
> ===================================================================
> --- coregrind/m_syswrap/syswrap-xen.c (revision 16301)
> +++ coregrind/m_syswrap/syswrap-xen.c (working copy)
> @@ -584,6 +584,7 @@
> case 0x00000009:
> case 0x0000000a:
> case 0x0000000b:
> + case 0x0000000d:
This is the version number of Xen sysctl. Sysctl is not a stable
interface. It's version number gets bumped from time to time.
It is currently at 0x0000000F. I suppose 0x0000000d is the version
number for 4.7.
> break;
> default:
> bad_intf_version(tid, layout, arrghs, status, flags,
> @@ -626,6 +627,7 @@
> break;
> case 0x0000000a:
> case 0x0000000b:
> + case 0x0000000d:
Here you need to check if getdomaininfolist has changed between 0xb and
0xd. I suppose if you don't see anything unusual it should be OK.
> PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, first_domain);
> PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, max_domains);
> PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, buffer);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: valgrind support for xen4.7+
2017-04-12 5:04 valgrind support for xen4.7+ Glenn Enright
2017-04-12 9:25 ` Wei Liu
@ 2017-07-05 6:59 ` Olaf Hering
1 sibling, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2017-07-05 6:59 UTC (permalink / raw)
To: Glenn Enright; +Cc: xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1658 bytes --]
On Wed, Apr 12, Glenn Enright wrote:
> Has anyone seen or been working on patches for valgrind for recent versions
> of xen?
Upstream requires paperwork, via kde.org bugzilla. This is my variant,
which is enough to run 'xl create' with valgrind.
Olaf
--- coregrind/m_syswrap/syswrap-xen.c.orig
+++ coregrind/m_syswrap/syswrap-xen.c
@@ -584,6 +584,8 @@ PRE(sysctl) {
case 0x00000009:
case 0x0000000a:
case 0x0000000b:
+ case 0x0000000c:
+ case 0x0000000d:
break;
default:
bad_intf_version(tid, layout, arrghs, status, flags,
@@ -626,6 +628,8 @@ PRE(sysctl) {
break;
case 0x0000000a:
case 0x0000000b:
+ case 0x0000000c:
+ case 0x0000000d:
PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, first_domain);
PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, max_domains);
PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, buffer);
@@ -728,6 +732,9 @@ PRE(domctl)
case 0x00000008:
case 0x00000009:
case 0x0000000a:
+ case 0x0000000b:
+ case 0x0000000c:
+ case 0x0000000d:
break;
default:
bad_intf_version(tid, layout, arrghs, status, flags,
@@ -1534,6 +1541,8 @@ POST(sysctl)
case 0x00000009:
case 0x0000000a:
case 0x0000000b:
+ case 0x0000000c:
+ case 0x0000000d:
break;
default:
return;
@@ -1568,6 +1577,8 @@ POST(sysctl)
break;
case 0x0000000a:
case 0x0000000b:
+ case 0x0000000c:
+ case 0x0000000d:
POST_XEN_SYSCTL_WRITE(getdomaininfolist_0000000a, num_domains);
POST_MEM_WRITE((Addr)sysctl->u.getdomaininfolist_0000000a.buffer.p,
sizeof(*sysctl->u.getdomaininfolist_0000000a.buffer.p)
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread