* [PATCH 390/390] staging:rtl8723bs:core:rtw_btcoex: Fixed checkpatch.pl warning on 'Comparisons should place the constant on the right side of the test'.
@ 2017-07-05 8:40 Shreeya Patel
2017-07-18 5:01 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Shreeya Patel @ 2017-07-05 8:40 UTC (permalink / raw)
To: kernelnewbies
Fixed a coding style issue.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 3c5cb78..01f78d1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -55,7 +55,7 @@ void rtw_btcoex_ConnectNotify(struct adapter *padapter, u8 action)
void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
{
- if ((RT_MEDIA_CONNECT == mediaStatus)
+ if ((mediaStatus == RT_MEDIA_CONNECT)
&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 390/390] staging:rtl8723bs:core:rtw_btcoex: Fixed checkpatch.pl warning on 'Comparisons should place the constant on the right side of the test'.
2017-07-05 8:40 [PATCH 390/390] staging:rtl8723bs:core:rtw_btcoex: Fixed checkpatch.pl warning on 'Comparisons should place the constant on the right side of the test' Shreeya Patel
@ 2017-07-18 5:01 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-07-18 5:01 UTC (permalink / raw)
To: kernelnewbies
On Wed, Jul 05, 2017 at 02:10:17PM +0530, Shreeya Patel wrote:
> Fixed a coding style issue.
Why is your subject longer than your changelog text?
And where are the other 389 patches in this series?
And finally, why are you sending this to kernelnewbies and not the
people and mailing list that scripts/get_maintainers.pl shows you when
you run this patch on it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 390/390] staging:rtl8723bs:core:rtw_btcoex: Fixed checkpatch.pl warning on 'Comparisons should place the constant on the right side of the test'.
2017-07-05 7:19 Shreeya Patel
@ 2017-07-11 17:10 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-07-11 17:10 UTC (permalink / raw)
To: Shreeya Patel; +Cc: devel, hdegoede, linux-kernel
On Wed, Jul 05, 2017 at 12:49:52PM +0530, Shreeya Patel wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Where are the 329 other patches in this series? I can't take just one
of them, right?
And your subject is _very_ long :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 390/390] staging:rtl8723bs:core:rtw_btcoex: Fixed checkpatch.pl warning on 'Comparisons should place the constant on the right side of the test'.
@ 2017-07-05 7:19 Shreeya Patel
2017-07-11 17:10 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Shreeya Patel @ 2017-07-05 7:19 UTC (permalink / raw)
To: gregkh; +Cc: hdegoede, devel, linux-kernel, shreeya.patel23498
Fixed a coding style issue.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 3c5cb78..01f78d1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -55,7 +55,7 @@ void rtw_btcoex_ConnectNotify(struct adapter *padapter, u8 action)
void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
{
- if ((RT_MEDIA_CONNECT == mediaStatus)
+ if ((mediaStatus == RT_MEDIA_CONNECT)
&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-18 5:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 8:40 [PATCH 390/390] staging:rtl8723bs:core:rtw_btcoex: Fixed checkpatch.pl warning on 'Comparisons should place the constant on the right side of the test' Shreeya Patel
2017-07-18 5:01 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-07-05 7:19 Shreeya Patel
2017-07-11 17:10 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.