* [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations
@ 2017-07-05 10:25 Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 1/5] arch/arm: fix -mcpu default values for AArch64 Yann E. MORIN
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 10:25 UTC (permalink / raw)
To: buildroot
Hello All!
This series adds four new CPU variants to the arm choice, to enable
optimising for big.LITTLE CPUs.
We first fix the current values inthe first two patches, then introduce
the actual new variants, and then make use of the sole packages that
needs to know of them.
This has been only slightly tested by simply building the toolchains for
the six possibilities:
- the four variants in arm mode (32-bit),
- the two armv8 variants in aarch64 mode (64-bit).
The variants were introduced in various versions of gcc, so we protect
the internal gcc as well as the external toolchains accordingly.
Regards,
Yann E. MORIN.
The following changes since commit 644c024edeb7e20bd96ce4426aeca2cbcd74d9b9
syslinux: drop patch 0003, not needed after gnu-efi update (2017-07-04 18:45:26 +0200)
are available in the git repository at:
git://git.buildroot.org/~ymorin/git/buildroot.git
for you to fetch changes up to cdc5ada0fd19765aff9779fc109a26284c9320b6
package/kvm-unit-test: available for big.LITTLE arm cores too (2017-07-05 12:07:49 +0200)
----------------------------------------------------------------
Yann E. MORIN (5):
arch/arm: fix -mcpu default values for AArch64
arch/arm: fix defaults for AArch64 in 64-bit mode
package/kvm-unit-tests: introduce _ARCH_SUPPORTS
arch/arm: add big.LITTLE cpu variants
package/kvm-unit-test: available for big.LITTLE arm cores too
arch/Config.in.arm | 50 ++++++++++++++++++----
package/gcc/Config.in.host | 5 ++-
package/kvm-unit-tests/Config.in | 19 ++++----
.../Config.in | 2 +
.../toolchain-external-codesourcery-arm/Config.in | 4 ++
5 files changed, 62 insertions(+), 18 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/5] arch/arm: fix -mcpu default values for AArch64
2017-07-05 10:25 [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
@ 2017-07-05 10:25 ` Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode Yann E. MORIN
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 10:25 UTC (permalink / raw)
To: buildroot
For AArch64, +fp and +simd are the default, so they are totally useless.
Remove them.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
arch/Config.in.arm | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index b1817ed568..aaf4506d7f 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -535,14 +535,8 @@ config BR2_GCC_TARGET_CPU
default "xscale" if BR2_xscale
default "iwmmxt" if BR2_iwmmxt
default "cortex-a53" if (BR2_cortex_a53 && !BR2_ARCH_IS_64)
- default "cortex-a53+fp" if (BR2_cortex_a53 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8)
- default "cortex-a53+fp+simd" if (BR2_cortex_a53 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8)
default "cortex-a57" if (BR2_cortex_a57 && !BR2_ARCH_IS_64)
- default "cortex-a57+fp" if (BR2_cortex_a57 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8)
- default "cortex-a57+fp+simd" if (BR2_cortex_a57 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8)
default "cortex-a72" if (BR2_cortex_a72 && !BR2_ARCH_IS_64)
- default "cortex-a72+fp" if (BR2_cortex_a72 && BR2_ARCH_IS_64 && BR2_ARM_FPU_FP_ARMV8)
- default "cortex-a72+fp+simd" if (BR2_cortex_a72 && BR2_ARCH_IS_64 && BR2_ARM_FPU_NEON_FP_ARMV8)
config BR2_GCC_TARGET_ABI
default "aapcs-linux" if BR2_arm || BR2_armeb
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode
2017-07-05 10:25 [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 1/5] arch/arm: fix -mcpu default values for AArch64 Yann E. MORIN
@ 2017-07-05 10:25 ` Yann E. MORIN
2017-07-05 10:55 ` Baruch Siach
2017-07-05 10:25 ` [Buildroot] [PATCH 3/5] package/kvm-unit-tests: introduce _ARCH_SUPPORTS Yann E. MORIN
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 10:25 UTC (permalink / raw)
To: buildroot
Even in 64-bit mode we have to specify the -mcpu value.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
arch/Config.in.arm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index aaf4506d7f..e6beacf3d8 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -534,9 +534,9 @@ config BR2_GCC_TARGET_CPU
default "strongarm" if BR2_strongarm
default "xscale" if BR2_xscale
default "iwmmxt" if BR2_iwmmxt
- default "cortex-a53" if (BR2_cortex_a53 && !BR2_ARCH_IS_64)
- default "cortex-a57" if (BR2_cortex_a57 && !BR2_ARCH_IS_64)
- default "cortex-a72" if (BR2_cortex_a72 && !BR2_ARCH_IS_64)
+ default "cortex-a53" if (BR2_cortex_a53)
+ default "cortex-a57" if (BR2_cortex_a57)
+ default "cortex-a72" if (BR2_cortex_a72)
config BR2_GCC_TARGET_ABI
default "aapcs-linux" if BR2_arm || BR2_armeb
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 3/5] package/kvm-unit-tests: introduce _ARCH_SUPPORTS
2017-07-05 10:25 [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 1/5] arch/arm: fix -mcpu default values for AArch64 Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode Yann E. MORIN
@ 2017-07-05 10:25 ` Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 4/5] arch/arm: add big.LITTLE cpu variants Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 5/5] package/kvm-unit-test: available for big.LITTLE arm cores too Yann E. MORIN
4 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 10:25 UTC (permalink / raw)
To: buildroot
Move all architecture options to their own symbol, so that it is easier
to add more variants in the future.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Cyril Bur <cyrilbur@gmail.com>
---
package/kvm-unit-tests/Config.in | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in
index 7eab0c25d6..0283e97dfc 100644
--- a/package/kvm-unit-tests/Config.in
+++ b/package/kvm-unit-tests/Config.in
@@ -1,15 +1,17 @@
-config BR2_PACKAGE_KVM_UNIT_TESTS
- bool "kvm-unit-tests"
+config BR2_PACKAGE_KVM_UNIT_TESTS_ARCH_SUPPORTS
+ bool
+ default y if BR2_cortex_a7 || BR2_cortex_a12 || \
+ BR2_cortex_a15 || BR2_cortex_a17
+ default y if BR2_powerpc64 || BR2_powerpc64le
# on i386 and x86-64, __builtin_reachable is used, so we need
# gcc 4.5 at least. on i386, we use the target gcc, while on
# x86-64 we use the host gcc (see .mk file for details)
# On ARM, it uses virtualization extensions
- depends on BR2_cortex_a7 || BR2_cortex_a12 || \
- BR2_cortex_a15 || BR2_cortex_a17 || \
- (BR2_i386 && BR2_TOOLCHAIN_GCC_AT_LEAST_4_5) || \
- BR2_powerpc64 || \
- BR2_powerpc64le || \
- (BR2_x86_64 && BR2_HOST_GCC_AT_LEAST_4_5)
+ default y if (BR2_i386 || BR2_x86_64) && BR2_TOOLCHAIN_GCC_AT_LEAST_4_5
+
+config BR2_PACKAGE_KVM_UNIT_TESTS
+ bool "kvm-unit-tests"
+ depends on BR2_PACKAGE_KVM_UNIT_TESTS_ARCH_SUPPORTS
select BR2_HOSTARCH_NEEDS_IA32_COMPILER if BR2_x86_64=y
help
kvm-unit-tests is a project as old as KVM. As its name
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 4/5] arch/arm: add big.LITTLE cpu variants
2017-07-05 10:25 [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
` (2 preceding siblings ...)
2017-07-05 10:25 ` [Buildroot] [PATCH 3/5] package/kvm-unit-tests: introduce _ARCH_SUPPORTS Yann E. MORIN
@ 2017-07-05 10:25 ` Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 5/5] package/kvm-unit-test: available for big.LITTLE arm cores too Yann E. MORIN
4 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 10:25 UTC (permalink / raw)
To: buildroot
The big.LITTLE configurations can be optimised for by gcc, and a few
users wonder what they should choose when they have such CPUs.
Add new entries for those big.LITTLE configurations.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
arch/Config.in.arm | 38 ++++++++++++++++++++++
package/gcc/Config.in.host | 5 ++-
.../Config.in | 2 ++
.../toolchain-external-codesourcery-arm/Config.in | 4 +++
4 files changed, 48 insertions(+), 1 deletion(-)
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index e6beacf3d8..5ca536684f 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -182,6 +182,15 @@ config BR2_cortex_a15
select BR2_ARM_CPU_ARMV7A
select BR2_ARCH_HAS_MMU_OPTIONAL
depends on !BR2_ARCH_IS_64
+config BR2_cortex_a15_a7
+ bool "cortex-A15/A7 big.LITTLE"
+ select BR2_ARM_CPU_HAS_ARM
+ select BR2_ARM_CPU_HAS_NEON
+ select BR2_ARM_CPU_HAS_VFPV4
+ select BR2_ARM_CPU_HAS_THUMB2
+ select BR2_ARM_CPU_ARMV7A
+ select BR2_ARCH_HAS_MMU_OPTIONAL
+ depends on !BR2_ARCH_IS_64
config BR2_cortex_a17
bool "cortex-A17"
select BR2_ARM_CPU_HAS_ARM
@@ -191,6 +200,15 @@ config BR2_cortex_a17
select BR2_ARM_CPU_ARMV7A
select BR2_ARCH_HAS_MMU_OPTIONAL
depends on !BR2_ARCH_IS_64
+config BR2_cortex_a17_a7
+ bool "cortex-A17/A7 big.LITTLE"
+ select BR2_ARM_CPU_HAS_ARM
+ select BR2_ARM_CPU_HAS_NEON
+ select BR2_ARM_CPU_HAS_VFPV4
+ select BR2_ARM_CPU_HAS_THUMB2
+ select BR2_ARM_CPU_ARMV7A
+ select BR2_ARCH_HAS_MMU_OPTIONAL
+ depends on !BR2_ARCH_IS_64
config BR2_cortex_a53
bool "cortex-A53"
select BR2_ARM_CPU_HAS_ARM if !BR2_ARCH_IS_64
@@ -207,6 +225,14 @@ config BR2_cortex_a57
select BR2_ARM_CPU_HAS_FP_ARMV8
select BR2_ARM_CPU_ARMV8
select BR2_ARCH_HAS_MMU_OPTIONAL
+config BR2_cortex_a57_a53
+ bool "cortex-A57/A53 big.LITTLE"
+ select BR2_ARM_CPU_HAS_ARM if !BR2_ARCH_IS_64
+ select BR2_ARM_CPU_HAS_NEON if !BR2_ARCH_IS_64
+ select BR2_ARM_CPU_HAS_THUMB2 if !BR2_ARCH_IS_64
+ select BR2_ARM_CPU_HAS_FP_ARMV8
+ select BR2_ARM_CPU_ARMV8
+ select BR2_ARCH_HAS_MMU_OPTIONAL
config BR2_cortex_a72
bool "cortex-A72"
select BR2_ARM_CPU_HAS_ARM if !BR2_ARCH_IS_64
@@ -215,6 +241,14 @@ config BR2_cortex_a72
select BR2_ARM_CPU_HAS_FP_ARMV8
select BR2_ARM_CPU_ARMV8
select BR2_ARCH_HAS_MMU_OPTIONAL
+config BR2_cortex_a72_a53
+ bool "cortex-A72/A53 big.LITTLE"
+ select BR2_ARM_CPU_HAS_ARM if !BR2_ARCH_IS_64
+ select BR2_ARM_CPU_HAS_NEON if !BR2_ARCH_IS_64
+ select BR2_ARM_CPU_HAS_THUMB2 if !BR2_ARCH_IS_64
+ select BR2_ARM_CPU_HAS_FP_ARMV8
+ select BR2_ARM_CPU_ARMV8
+ select BR2_ARCH_HAS_MMU_OPTIONAL
config BR2_cortex_m3
bool "cortex-M3"
select BR2_ARM_CPU_HAS_THUMB2
@@ -526,7 +560,9 @@ config BR2_GCC_TARGET_CPU
default "cortex-a9" if BR2_cortex_a9
default "cortex-a12" if BR2_cortex_a12
default "cortex-a15" if BR2_cortex_a15
+ default "cortex-a15.cortex-a7" if BR2_cortex_a15_a7
default "cortex-a17" if BR2_cortex_a17
+ default "cortex-a17.cortex-a7" if BR2_cortex_a17_a7
default "cortex-m3" if BR2_cortex_m3
default "cortex-m4" if BR2_cortex_m4
default "fa526" if BR2_fa526
@@ -536,7 +572,9 @@ config BR2_GCC_TARGET_CPU
default "iwmmxt" if BR2_iwmmxt
default "cortex-a53" if (BR2_cortex_a53)
default "cortex-a57" if (BR2_cortex_a57)
+ default "cortex-a57.cortex-a53" if (BR2_cortex_a57_a53)
default "cortex-a72" if (BR2_cortex_a72)
+ default "cortex-a72.cortex-a53" if (BR2_cortex_a72_a53)
config BR2_GCC_TARGET_ABI
default "aapcs-linux" if BR2_arm || BR2_armeb
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index 5dcaa03ff0..c072b78ae5 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -25,7 +25,8 @@ config BR2_GCC_VERSION_4_9_X
# Broken or unsupported architectures
depends on !BR2_arc && !BR2_bfin && !BR2_or1k
# Broken or unsupported ARM cores
- depends on !BR2_cortex_a17 && !BR2_cortex_a72
+ depends on !BR2_cortex_a17 && !BR2_cortex_a17_a7
+ depends on !BR2_cortex_a72 && !BR2_cortex_a72_a53
# Unsupported MIPS cores
depends on !BR2_mips_interaptiv
# Unsupported for MIPS R5
@@ -45,6 +46,8 @@ config BR2_GCC_VERSION_5_X
bool "gcc 5.x"
# Broken or unsupported architectures
depends on !BR2_arc && !BR2_bfin && !BR2_or1k
+ # Broken or unsupported ARM cores
+ depends on !BR2_cortex_a57_a53 && !BR2_cortex_a72_a53
# musl ppc64 unsupported
depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))
# Unsupported MIPS cores
diff --git a/toolchain/toolchain-external/toolchain-external-codesourcery-aarch64/Config.in b/toolchain/toolchain-external/toolchain-external-codesourcery-aarch64/Config.in
index 2fbb218ecc..66a032e9ac 100644
--- a/toolchain/toolchain-external/toolchain-external-codesourcery-aarch64/Config.in
+++ b/toolchain/toolchain-external/toolchain-external-codesourcery-aarch64/Config.in
@@ -1,6 +1,8 @@
config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_AARCH64
bool "CodeSourcery AArch64 2014.11"
depends on BR2_aarch64
+ # a57/a53 and a72/a53 appeared in gcc-6 or were broken before
+ depends on !BR2_cortex_a57_a53 && !BR2_cortex_a72_a53
depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
depends on !BR2_STATIC_LIBS
select BR2_TOOLCHAIN_EXTERNAL_GLIBC
diff --git a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
index 6331873dbd..70c488d327 100644
--- a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
+++ b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
@@ -1,6 +1,10 @@
config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
bool "Sourcery CodeBench ARM 2014.05"
depends on BR2_arm
+ # a15/a7 appeared in gcc-4.9, a17/a7 in gcc-5, a57/a53 and a72/a53
+ # in gcc-6, or they were broken earlier than that.
+ depends on !BR2_cortex_a15_a7 && !BR2_cortex_a17_a7
+ depends on !BR2_cortex_a57_53 && !BR2_cortex_a72_53
depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
depends on BR2_ARM_EABI
# Unsupported ARM cores
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 5/5] package/kvm-unit-test: available for big.LITTLE arm cores too
2017-07-05 10:25 [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
` (3 preceding siblings ...)
2017-07-05 10:25 ` [Buildroot] [PATCH 4/5] arch/arm: add big.LITTLE cpu variants Yann E. MORIN
@ 2017-07-05 10:25 ` Yann E. MORIN
4 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 10:25 UTC (permalink / raw)
To: buildroot
Since it supports each variants individually, it should also supports
the big.LITTLE configurations.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Cyril Bur <cyrilbur@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/kvm-unit-tests/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in
index 0283e97dfc..ec1826b2da 100644
--- a/package/kvm-unit-tests/Config.in
+++ b/package/kvm-unit-tests/Config.in
@@ -1,7 +1,8 @@
config BR2_PACKAGE_KVM_UNIT_TESTS_ARCH_SUPPORTS
bool
default y if BR2_cortex_a7 || BR2_cortex_a12 || \
- BR2_cortex_a15 || BR2_cortex_a17
+ BR2_cortex_a15 || BR2_cortex_a17 || \
+ BR2_cortex_a15_a7 || BR2_cortex_a17_a7
default y if BR2_powerpc64 || BR2_powerpc64le
# on i386 and x86-64, __builtin_reachable is used, so we need
# gcc 4.5 at least. on i386, we use the target gcc, while on
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode
2017-07-05 10:25 ` [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode Yann E. MORIN
@ 2017-07-05 10:55 ` Baruch Siach
2017-07-05 11:01 ` Yann E. MORIN
0 siblings, 1 reply; 8+ messages in thread
From: Baruch Siach @ 2017-07-05 10:55 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Wed, Jul 05, 2017 at 12:25:34PM +0200, Yann E. MORIN wrote:
> Even in 64-bit mode we have to specify the -mcpu value.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/Config.in.arm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/Config.in.arm b/arch/Config.in.arm
> index aaf4506d7f..e6beacf3d8 100644
> --- a/arch/Config.in.arm
> +++ b/arch/Config.in.arm
> @@ -534,9 +534,9 @@ config BR2_GCC_TARGET_CPU
> default "strongarm" if BR2_strongarm
> default "xscale" if BR2_xscale
> default "iwmmxt" if BR2_iwmmxt
> - default "cortex-a53" if (BR2_cortex_a53 && !BR2_ARCH_IS_64)
> - default "cortex-a57" if (BR2_cortex_a57 && !BR2_ARCH_IS_64)
> - default "cortex-a72" if (BR2_cortex_a72 && !BR2_ARCH_IS_64)
> + default "cortex-a53" if (BR2_cortex_a53)
> + default "cortex-a57" if (BR2_cortex_a57)
> + default "cortex-a72" if (BR2_cortex_a72)
What are the parentheses good for?
baruch
>
> config BR2_GCC_TARGET_ABI
> default "aapcs-linux" if BR2_arm || BR2_armeb
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode
2017-07-05 10:55 ` Baruch Siach
@ 2017-07-05 11:01 ` Yann E. MORIN
0 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2017-07-05 11:01 UTC (permalink / raw)
To: buildroot
Baruch, All,
On 2017-07-05 13:55 +0300, Baruch Siach spake thusly:
> On Wed, Jul 05, 2017 at 12:25:34PM +0200, Yann E. MORIN wrote:
> > Even in 64-bit mode we have to specify the -mcpu value.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---
> > arch/Config.in.arm | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/Config.in.arm b/arch/Config.in.arm
> > index aaf4506d7f..e6beacf3d8 100644
> > --- a/arch/Config.in.arm
> > +++ b/arch/Config.in.arm
> > @@ -534,9 +534,9 @@ config BR2_GCC_TARGET_CPU
> > default "strongarm" if BR2_strongarm
> > default "xscale" if BR2_xscale
> > default "iwmmxt" if BR2_iwmmxt
> > - default "cortex-a53" if (BR2_cortex_a53 && !BR2_ARCH_IS_64)
> > - default "cortex-a57" if (BR2_cortex_a57 && !BR2_ARCH_IS_64)
> > - default "cortex-a72" if (BR2_cortex_a72 && !BR2_ARCH_IS_64)
> > + default "cortex-a53" if (BR2_cortex_a53)
> > + default "cortex-a57" if (BR2_cortex_a57)
> > + default "cortex-a72" if (BR2_cortex_a72)
>
> What are the parentheses good for?
They are just so that the series is not applied on the first go. ;-)
Regards,
Yann E. MORIN.
> baruch
>
> >
> > config BR2_GCC_TARGET_ABI
> > default "aapcs-linux" if BR2_arm || BR2_armeb
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-07-05 11:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 10:25 [Buildroot] [PATCH 0/5] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 1/5] arch/arm: fix -mcpu default values for AArch64 Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 2/5] arch/arm: fix defaults for AArch64 in 64-bit mode Yann E. MORIN
2017-07-05 10:55 ` Baruch Siach
2017-07-05 11:01 ` Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 3/5] package/kvm-unit-tests: introduce _ARCH_SUPPORTS Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 4/5] arch/arm: add big.LITTLE cpu variants Yann E. MORIN
2017-07-05 10:25 ` [Buildroot] [PATCH 5/5] package/kvm-unit-test: available for big.LITTLE arm cores too Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.