All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] drm/i915/perf: Add support for loadable OA configs
@ 2017-07-07 17:08 Lionel Landwerlin
  2017-07-07 17:08 ` [PATCH 1/2] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface Lionel Landwerlin
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2017-07-07 17:08 UTC (permalink / raw)
  To: intel-gfx

Hi,

This series adds support for loadable OA configurations. It is based
off Matthew's initial work. This idea is to let userspace mostly hold
these configurations, so they can be tweaked from userspace without
patching the kernel, which is quite useful for debug purposes.

I've made sent IGT tests for it :

   https://patchwork.freedesktop.org/series/27010/

Though this series depends on a bunch of commits not fully reviewed
yet. You can find the branch here :

   https://github.com/djdeath/intel-gpu-tools/tree/wip/djdeath/oa-next

I've also tested this with GPUTop :

https://github.com/rib/gputop/commits/for-master

Eventually I'll produce the patches for Mesa and we'll be able to
remove most of the config from kernel space. I think it's best to
leave the test configs which are quite useful to verify stuff works as
expected, but if people feel they should go too, I'm okay with that.

Cheers,

Lionel Landwerlin (1):
  drm/i915/perf: prune OA configs

Matthew Auld (1):
  drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

 drivers/gpu/drm/i915/i915_drv.c       |    2 +
 drivers/gpu/drm/i915/i915_drv.h       |   30 +
 drivers/gpu/drm/i915/i915_oa_bdw.c    | 5351 +--------------------------------
 drivers/gpu/drm/i915/i915_oa_bxt.c    | 2566 +---------------
 drivers/gpu/drm/i915/i915_oa_chv.c    | 2763 +----------------
 drivers/gpu/drm/i915/i915_oa_glk.c    | 2478 +--------------
 drivers/gpu/drm/i915/i915_oa_hsw.c    |  649 +---
 drivers/gpu/drm/i915/i915_oa_kblgt2.c | 2876 +-----------------
 drivers/gpu/drm/i915/i915_oa_kblgt3.c | 2925 +-----------------
 drivers/gpu/drm/i915/i915_oa_sklgt2.c | 3363 +--------------------
 drivers/gpu/drm/i915/i915_oa_sklgt3.c | 2924 +-----------------
 drivers/gpu/drm/i915/i915_oa_sklgt4.c | 2978 +-----------------
 drivers/gpu/drm/i915/i915_perf.c      |  391 ++-
 drivers/gpu/drm/i915/i915_reg.h       |    2 +
 include/uapi/drm/i915_drm.h           |   21 +
 15 files changed, 811 insertions(+), 28508 deletions(-)

--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [drm-intel:for-linux-next 2/3] drivers/gpu/drm/i915/i915_gem_execbuffer.c:300:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
@ 2017-06-15 15:23 kbuild test robot
  2017-06-15 15:23 ` [PATCH] drm/i915: fix ifnullfree.cocci warnings kbuild test robot
  0 siblings, 1 reply; 15+ messages in thread
From: kbuild test robot @ 2017-06-15 15:23 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx, kbuild-all, dri-devel

tree:   git://anongit.freedesktop.org/drm-intel for-linux-next
head:   8c45cec48e5871f93e56650f7e476d4ea7174a0e
commit: d55495b4dcce2efb4656edfe211eb0bfb27c3387 [2/3] drm/i915: Use vma->exec_entry as our double-entry placeholder


coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/i915/i915_gem_execbuffer.c:300:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2017-07-13 12:46 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 17:08 [PATCH 0/2] drm/i915/perf: Add support for loadable OA configs Lionel Landwerlin
2017-07-07 17:08 ` [PATCH 1/2] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface Lionel Landwerlin
2017-07-07 17:31   ` Chris Wilson
2017-07-13 12:46     ` Lionel Landwerlin
2017-07-07 23:53   ` Matthew Auld
2017-07-13 11:25     ` Lionel Landwerlin
2017-07-09  9:05   ` kbuild test robot
2017-07-09  9:05   ` [PATCH] drm/i915: fix ifnullfree.cocci warnings kbuild test robot
2017-07-10 10:48   ` [PATCH 1/2] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface Matthew Auld
2017-07-13 11:25     ` Lionel Landwerlin
2017-07-07 17:08 ` [PATCH 2/2] drm/i915/perf: prune OA configs Lionel Landwerlin
2017-07-10 10:00   ` Matthew Auld
2017-07-07 18:00 ` ✓ Fi.CI.BAT: success for drm/i915/perf: Add support for loadable " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2017-06-15 15:23 [drm-intel:for-linux-next 2/3] drivers/gpu/drm/i915/i915_gem_execbuffer.c:300:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values kbuild test robot
2017-06-15 15:23 ` [PATCH] drm/i915: fix ifnullfree.cocci warnings kbuild test robot
2017-06-15 16:07   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.