* [PATCH] cryptodev: fix icc build
@ 2017-07-10 2:59 Pablo de Lara
2017-07-12 10:09 ` Declan Doherty
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2017-07-10 2:59 UTC (permalink / raw)
To: declan.doherty; +Cc: dev, Pablo de Lara
Removed unnecessary macro RTE_STD_C11, which is used
for unnamed structs.
Since there is no longer an unnamed structure in
rte_cryptodev_sym_session, this is not needed and
it is actually breaking compilation on icc:
lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration
__extension__ void *sess_private_data[0];
^
Fixes: 7c110ce7aa4e ("cryptodev: remove mempool from session")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_cryptodev/rte_cryptodev.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index ca7cbdd..1d975e5 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -883,7 +883,6 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,
/** Cryptodev symmetric crypto session */
struct rte_cryptodev_sym_session {
- RTE_STD_C11
__extension__ void *sess_private_data[0];
/**< Private session material */
};
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cryptodev: fix icc build
2017-07-10 2:59 [PATCH] cryptodev: fix icc build Pablo de Lara
@ 2017-07-12 10:09 ` Declan Doherty
2017-07-12 12:42 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Declan Doherty @ 2017-07-12 10:09 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev
On 10/07/17 03:59, Pablo de Lara wrote:
> Removed unnecessary macro RTE_STD_C11, which is used
> for unnamed structs.
> Since there is no longer an unnamed structure in
> rte_cryptodev_sym_session, this is not needed and
> it is actually breaking compilation on icc:
>
> lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration
> __extension__ void *sess_private_data[0];
> ^
> Fixes: 7c110ce7aa4e ("cryptodev: remove mempool from session")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cryptodev: fix icc build
2017-07-12 10:09 ` Declan Doherty
@ 2017-07-12 12:42 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-07-12 12:42 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, Declan Doherty
12/07/2017 12:09, Declan Doherty:
> On 10/07/17 03:59, Pablo de Lara wrote:
> > Removed unnecessary macro RTE_STD_C11, which is used
> > for unnamed structs.
> > Since there is no longer an unnamed structure in
> > rte_cryptodev_sym_session, this is not needed and
> > it is actually breaking compilation on icc:
> >
> > lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration
> > __extension__ void *sess_private_data[0];
> > ^
> > Fixes: 7c110ce7aa4e ("cryptodev: remove mempool from session")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-12 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 2:59 [PATCH] cryptodev: fix icc build Pablo de Lara
2017-07-12 10:09 ` Declan Doherty
2017-07-12 12:42 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.