From: Richard Cochran <richardcochran@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ganesh Goudar <ganeshgr@chelsio.com>,
Atul Gupta <atul.gupta@chelsio.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register()
Date: Mon, 10 Jul 2017 13:02:46 +0200 [thread overview]
Message-ID: <20170710110246.inwp2frouj7gvqzf@localhost.localdomain> (raw)
In-Reply-To: <20170710102920.gav646pmteijfxfl@mwanda>
On Mon, Jul 10, 2017 at 01:29:20PM +0300, Dan Carpenter wrote:
> The "goto no_pps" was a bug you introduced.
I took a second look, and yes, the original commit should not have
returned NULL, and the original callers did not expect NULL either.
> But I feel like you're being rude, so I'm not going to resend these
> patches. Please fix them yourself.
Sorry you feel that way. Your first patch, although now more or less
cosmetic, would be okay. The second patch is still wrong.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ganesh Goudar <ganeshgr@chelsio.com>,
Atul Gupta <atul.gupta@chelsio.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register()
Date: Mon, 10 Jul 2017 11:02:46 +0000 [thread overview]
Message-ID: <20170710110246.inwp2frouj7gvqzf@localhost.localdomain> (raw)
In-Reply-To: <20170710102920.gav646pmteijfxfl@mwanda>
On Mon, Jul 10, 2017 at 01:29:20PM +0300, Dan Carpenter wrote:
> The "goto no_pps" was a bug you introduced.
I took a second look, and yes, the original commit should not have
returned NULL, and the original callers did not expect NULL either.
> But I feel like you're being rude, so I'm not going to resend these
> patches. Please fix them yourself.
Sorry you feel that way. Your first patch, although now more or less
cosmetic, would be okay. The second patch is still wrong.
Thanks,
Richard
next prev parent reply other threads:[~2017-07-10 11:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 7:11 [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register() Dan Carpenter
2017-07-10 7:11 ` Dan Carpenter
2017-07-10 7:16 ` [PATCH 2/2 net] cxgb4: ptp_clock_register() returns error pointers Dan Carpenter
2017-07-10 7:16 ` Dan Carpenter
2017-07-10 9:56 ` Richard Cochran
2017-07-10 9:56 ` Richard Cochran
2017-07-10 9:21 ` [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register() Richard Cochran
2017-07-10 9:21 ` Richard Cochran
2017-07-10 9:38 ` Dan Carpenter
2017-07-10 9:38 ` Dan Carpenter
2017-07-10 9:48 ` Richard Cochran
2017-07-10 9:48 ` Richard Cochran
2017-07-10 10:29 ` Dan Carpenter
2017-07-10 10:29 ` Dan Carpenter
2017-07-10 11:02 ` Richard Cochran [this message]
2017-07-10 11:02 ` Richard Cochran
2017-07-10 9:34 ` Richard Cochran
2017-07-10 9:34 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710110246.inwp2frouj7gvqzf@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=atul.gupta@chelsio.com \
--cc=dan.carpenter@oracle.com \
--cc=ganeshgr@chelsio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.