All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] x86: fix norandmaps
@ 2017-07-10 11:14 Oleg Nesterov
  2017-07-10 11:14 ` [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top() Oleg Nesterov
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Oleg Nesterov @ 2017-07-10 11:14 UTC (permalink / raw)
  To: Dmitry Safonov, Thomas Gleixner
  Cc: Andy Lutomirski, Borislav Petkov, Cyrill Gorcunov, linux-kernel

Documentation/admin-guide/kernel-parameters.txt says:

    norandmaps  Don't use address space randomization. Equivalent
                to echo 0 > /proc/sys/kernel/randomize_va_space

but it doesn't work because arch_rnd() which is used to randomize
mm->mmap_base returns a random value unconditionally.

Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().

Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 arch/x86/mm/mmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
index 19ad095..6369d04 100644
--- a/arch/x86/mm/mmap.c
+++ b/arch/x86/mm/mmap.c
@@ -82,13 +82,13 @@ static int mmap_is_legacy(void)
 
 static unsigned long arch_rnd(unsigned int rndbits)
 {
+	if (!(current->flags & PF_RANDOMIZE))
+		return 0;
 	return (get_random_long() & ((1UL << rndbits) - 1)) << PAGE_SHIFT;
 }
 
 unsigned long arch_mmap_rnd(void)
 {
-	if (!(current->flags & PF_RANDOMIZE))
-		return 0;
 	return arch_rnd(mmap_is_ia32() ? mmap32_rnd_bits : mmap64_rnd_bits);
 }
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top()
  2017-07-10 11:14 [PATCH 1/2] x86: fix norandmaps Oleg Nesterov
@ 2017-07-10 11:14 ` Oleg Nesterov
  2017-07-10 11:58   ` Dmitry Safonov
  2017-07-10 11:56 ` [PATCH 1/2] x86: fix norandmaps Dmitry Safonov
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Oleg Nesterov @ 2017-07-10 11:14 UTC (permalink / raw)
  To: Dmitry Safonov, Thomas Gleixner
  Cc: Andy Lutomirski, Borislav Petkov, Cyrill Gorcunov, linux-kernel

PF_RANDOMIZE is set by load_elf_binary() only if ADDR_NO_RANDOMIZE is not
set, no need to re-check after that.that.that.that.that.that.that.that.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 arch/x86/mm/mmap.c | 3 +--
 fs/binfmt_elf.c    | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
index 6369d04..81db3e9 100644
--- a/arch/x86/mm/mmap.c
+++ b/arch/x86/mm/mmap.c
@@ -50,8 +50,7 @@ unsigned long tasksize_64bit(void)
 static unsigned long stack_maxrandom_size(unsigned long task_size)
 {
 	unsigned long max = 0;
-	if ((current->flags & PF_RANDOMIZE) &&
-		!(current->personality & ADDR_NO_RANDOMIZE)) {
+	if (current->flags & PF_RANDOMIZE) {
 		max = (-1UL) & __STACK_RND_MASK(task_size == tasksize_32bit());
 		max <<= PAGE_SHIFT;
 	}
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 5075fd5..569c82e 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -666,8 +666,7 @@ static unsigned long randomize_stack_top(unsigned long stack_top)
 {
 	unsigned long random_variable = 0;
 
-	if ((current->flags & PF_RANDOMIZE) &&
-		!(current->personality & ADDR_NO_RANDOMIZE)) {
+	if (current->flags & PF_RANDOMIZE) {
 		random_variable = get_random_long();
 		random_variable &= STACK_RND_MASK;
 		random_variable <<= PAGE_SHIFT;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] x86: fix norandmaps
  2017-07-10 11:14 [PATCH 1/2] x86: fix norandmaps Oleg Nesterov
  2017-07-10 11:14 ` [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top() Oleg Nesterov
@ 2017-07-10 11:56 ` Dmitry Safonov
  2017-07-20 16:42 ` Oleg Nesterov
  2017-08-14 16:24 ` Kirill A. Shutemov
  3 siblings, 0 replies; 8+ messages in thread
From: Dmitry Safonov @ 2017-07-10 11:56 UTC (permalink / raw)
  To: Oleg Nesterov, Thomas Gleixner
  Cc: Andy Lutomirski, Borislav Petkov, Cyrill Gorcunov, linux-kernel

On 07/10/2017 02:14 PM, Oleg Nesterov wrote:
> Documentation/admin-guide/kernel-parameters.txt says:
> 
>      norandmaps  Don't use address space randomization. Equivalent
>                  to echo 0 > /proc/sys/kernel/randomize_va_space
> 
> but it doesn't work because arch_rnd() which is used to randomize
> mm->mmap_base returns a random value unconditionally.
> 
> Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> 
> Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Thanks, Oleg,
Reviewed-by: Dmitry Safonov <dsafonov@virtuozzo.com>

> ---
>   arch/x86/mm/mmap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
> index 19ad095..6369d04 100644
> --- a/arch/x86/mm/mmap.c
> +++ b/arch/x86/mm/mmap.c
> @@ -82,13 +82,13 @@ static int mmap_is_legacy(void)
>   
>   static unsigned long arch_rnd(unsigned int rndbits)
>   {
> +	if (!(current->flags & PF_RANDOMIZE))
> +		return 0;
>   	return (get_random_long() & ((1UL << rndbits) - 1)) << PAGE_SHIFT;
>   }
>   
>   unsigned long arch_mmap_rnd(void)
>   {
> -	if (!(current->flags & PF_RANDOMIZE))
> -		return 0;
>   	return arch_rnd(mmap_is_ia32() ? mmap32_rnd_bits : mmap64_rnd_bits);
>   }
>   
> 


-- 
              Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top()
  2017-07-10 11:14 ` [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top() Oleg Nesterov
@ 2017-07-10 11:58   ` Dmitry Safonov
  0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Safonov @ 2017-07-10 11:58 UTC (permalink / raw)
  To: Oleg Nesterov, Thomas Gleixner
  Cc: Andy Lutomirski, Borislav Petkov, Cyrill Gorcunov, linux-kernel

On 07/10/2017 02:14 PM, Oleg Nesterov wrote:
> PF_RANDOMIZE is set by load_elf_binary() only if ADDR_NO_RANDOMIZE is not
> set, no need to re-check after that.that.that.that.that.that.that.that.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Reviewed-by: Dmitry Safonov <dsafonov@virtuozzo.com>

> ---
>   arch/x86/mm/mmap.c | 3 +--
>   fs/binfmt_elf.c    | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
> index 6369d04..81db3e9 100644
> --- a/arch/x86/mm/mmap.c
> +++ b/arch/x86/mm/mmap.c
> @@ -50,8 +50,7 @@ unsigned long tasksize_64bit(void)
>   static unsigned long stack_maxrandom_size(unsigned long task_size)
>   {
>   	unsigned long max = 0;
> -	if ((current->flags & PF_RANDOMIZE) &&
> -		!(current->personality & ADDR_NO_RANDOMIZE)) {
> +	if (current->flags & PF_RANDOMIZE) {
>   		max = (-1UL) & __STACK_RND_MASK(task_size == tasksize_32bit());
>   		max <<= PAGE_SHIFT;
>   	}
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index 5075fd5..569c82e 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -666,8 +666,7 @@ static unsigned long randomize_stack_top(unsigned long stack_top)
>   {
>   	unsigned long random_variable = 0;
>   
> -	if ((current->flags & PF_RANDOMIZE) &&
> -		!(current->personality & ADDR_NO_RANDOMIZE)) {
> +	if (current->flags & PF_RANDOMIZE) {
>   		random_variable = get_random_long();
>   		random_variable &= STACK_RND_MASK;
>   		random_variable <<= PAGE_SHIFT;
> 


-- 
              Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] x86: fix norandmaps
  2017-07-10 11:14 [PATCH 1/2] x86: fix norandmaps Oleg Nesterov
  2017-07-10 11:14 ` [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top() Oleg Nesterov
  2017-07-10 11:56 ` [PATCH 1/2] x86: fix norandmaps Dmitry Safonov
@ 2017-07-20 16:42 ` Oleg Nesterov
  2017-08-14 16:24 ` Kirill A. Shutemov
  3 siblings, 0 replies; 8+ messages in thread
From: Oleg Nesterov @ 2017-07-20 16:42 UTC (permalink / raw)
  To: Dmitry Safonov, Thomas Gleixner, Andrew Morton
  Cc: Andy Lutomirski, Borislav Petkov, Cyrill Gorcunov, linux-kernel

ping ;)

On 07/10, Oleg Nesterov wrote:
>
> Documentation/admin-guide/kernel-parameters.txt says:
> 
>     norandmaps  Don't use address space randomization. Equivalent
>                 to echo 0 > /proc/sys/kernel/randomize_va_space
> 
> but it doesn't work because arch_rnd() which is used to randomize
> mm->mmap_base returns a random value unconditionally.
> 
> Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> 
> Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
>  arch/x86/mm/mmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
> index 19ad095..6369d04 100644
> --- a/arch/x86/mm/mmap.c
> +++ b/arch/x86/mm/mmap.c
> @@ -82,13 +82,13 @@ static int mmap_is_legacy(void)
>  
>  static unsigned long arch_rnd(unsigned int rndbits)
>  {
> +	if (!(current->flags & PF_RANDOMIZE))
> +		return 0;
>  	return (get_random_long() & ((1UL << rndbits) - 1)) << PAGE_SHIFT;
>  }
>  
>  unsigned long arch_mmap_rnd(void)
>  {
> -	if (!(current->flags & PF_RANDOMIZE))
> -		return 0;
>  	return arch_rnd(mmap_is_ia32() ? mmap32_rnd_bits : mmap64_rnd_bits);
>  }
>  
> -- 
> 2.5.0
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] x86: fix norandmaps
  2017-07-10 11:14 [PATCH 1/2] x86: fix norandmaps Oleg Nesterov
                   ` (2 preceding siblings ...)
  2017-07-20 16:42 ` Oleg Nesterov
@ 2017-08-14 16:24 ` Kirill A. Shutemov
  2017-08-14 16:43   ` Oleg Nesterov
  3 siblings, 1 reply; 8+ messages in thread
From: Kirill A. Shutemov @ 2017-08-14 16:24 UTC (permalink / raw)
  To: Oleg Nesterov
  Cc: Dmitry Safonov, Thomas Gleixner, Andy Lutomirski,
	Borislav Petkov, Cyrill Gorcunov, linux-kernel

On Mon, Jul 10, 2017 at 01:14:29PM +0200, Oleg Nesterov wrote:
> Documentation/admin-guide/kernel-parameters.txt says:
> 
>     norandmaps  Don't use address space randomization. Equivalent
>                 to echo 0 > /proc/sys/kernel/randomize_va_space
> 
> but it doesn't work because arch_rnd() which is used to randomize
> mm->mmap_base returns a random value unconditionally.
> 
> Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> 
> Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

It also fixes personality(ADDR_NO_RANDOMIZE).

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] x86: fix norandmaps
  2017-08-14 16:24 ` Kirill A. Shutemov
@ 2017-08-14 16:43   ` Oleg Nesterov
  2017-08-14 16:44     ` Cyrill Gorcunov
  0 siblings, 1 reply; 8+ messages in thread
From: Oleg Nesterov @ 2017-08-14 16:43 UTC (permalink / raw)
  To: Kirill A. Shutemov
  Cc: Dmitry Safonov, Thomas Gleixner, Andy Lutomirski,
	Borislav Petkov, Cyrill Gorcunov, linux-kernel

On 08/14, Kirill A. Shutemov wrote:
>
> On Mon, Jul 10, 2017 at 01:14:29PM +0200, Oleg Nesterov wrote:
> > Documentation/admin-guide/kernel-parameters.txt says:
> > 
> >     norandmaps  Don't use address space randomization. Equivalent
> >                 to echo 0 > /proc/sys/kernel/randomize_va_space
> > 
> > but it doesn't work because arch_rnd() which is used to randomize
> > mm->mmap_base returns a random value unconditionally.
> > 
> > Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> > 
> > Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> 
> It also fixes personality(ADDR_NO_RANDOMIZE).

Yes, good point.

> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

OK, thanks Kirill and Cyrill, I'll resend tomorrow with all acks I got.

Oleg.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] x86: fix norandmaps
  2017-08-14 16:43   ` Oleg Nesterov
@ 2017-08-14 16:44     ` Cyrill Gorcunov
  0 siblings, 0 replies; 8+ messages in thread
From: Cyrill Gorcunov @ 2017-08-14 16:44 UTC (permalink / raw)
  To: Oleg Nesterov
  Cc: Kirill A. Shutemov, Dmitry Safonov, Thomas Gleixner,
	Andy Lutomirski, Borislav Petkov, linux-kernel

On Mon, Aug 14, 2017 at 06:43:10PM +0200, Oleg Nesterov wrote:
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> OK, thanks Kirill and Cyrill, I'll resend tomorrow with all acks I got.

I don't think you need my ack but if any
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-08-14 16:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 11:14 [PATCH 1/2] x86: fix norandmaps Oleg Nesterov
2017-07-10 11:14 ` [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE checks in stack_maxrandom_size() and randomize_stack_top() Oleg Nesterov
2017-07-10 11:58   ` Dmitry Safonov
2017-07-10 11:56 ` [PATCH 1/2] x86: fix norandmaps Dmitry Safonov
2017-07-20 16:42 ` Oleg Nesterov
2017-08-14 16:24 ` Kirill A. Shutemov
2017-08-14 16:43   ` Oleg Nesterov
2017-08-14 16:44     ` Cyrill Gorcunov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.