* [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example
@ 2017-07-10 12:12 ` Heiko Stuebner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-10 12:12 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Heiko Stuebner
The binding rightfully only specifies compatibles for actual implementations
and not for the whole family. In the example an arm,mali-midgard slipped
through from downstream devicetrees though. So drop that to not confuse
people reading (or copying) that example.
Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
---
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index d3b6e1a4713a..5aa5926029ee 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -40,7 +40,7 @@ Optional properties:
Example for a Mali-T760:
gpu@ffa30000 {
- compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
+ compatible = "rockchip,rk3288-mali", "arm,mali-t760";
reg = <0xffa30000 0x10000>;
interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example
@ 2017-07-10 12:12 ` Heiko Stuebner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-10 12:12 UTC (permalink / raw)
To: linux-arm-kernel
The binding rightfully only specifies compatibles for actual implementations
and not for the whole family. In the example an arm,mali-midgard slipped
through from downstream devicetrees though. So drop that to not confuse
people reading (or copying) that example.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index d3b6e1a4713a..5aa5926029ee 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -40,7 +40,7 @@ Optional properties:
Example for a Mali-T760:
gpu at ffa30000 {
- compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
+ compatible = "rockchip,rk3288-mali", "arm,mali-t760";
reg = <0xffa30000 0x10000>;
interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
--
2.11.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard compatible from rk3288
2017-07-10 12:12 ` Heiko Stuebner
@ 2017-07-10 12:12 ` Heiko Stuebner
-1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-10 12:12 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Heiko Stuebner
The binding specifies the actual implementations only (mali-t760
for example) but not the arm,mali-midgard used in some vendor kernels.
So drop that compatible property from the rk3288 where it had slipped in.
Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
---
arch/arm/boot/dts/rk3288.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index cb1d415d1201..e99d7ff4c939 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1135,7 +1135,7 @@
};
gpu: mali@ffa30000 {
- compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
+ compatible = "rockchip,rk3288-mali", "arm,mali-t760";
reg = <0xffa30000 0x10000>;
interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
@ 2017-07-10 12:12 ` Heiko Stuebner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-10 12:12 UTC (permalink / raw)
To: linux-arm-kernel
The binding specifies the actual implementations only (mali-t760
for example) but not the arm,mali-midgard used in some vendor kernels.
So drop that compatible property from the rk3288 where it had slipped in.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index cb1d415d1201..e99d7ff4c939 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1135,7 +1135,7 @@
};
gpu: mali at ffa30000 {
- compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
+ compatible = "rockchip,rk3288-mali", "arm,mali-t760";
reg = <0xffa30000 0x10000>;
interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
--
2.11.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard compatible from rk3288
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
@ 2017-07-11 3:00 ` Rob Herring
-1 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2017-07-11 3:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Jul 10, 2017 at 02:12:27PM +0200, Heiko Stuebner wrote:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index cb1d415d1201..e99d7ff4c939 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1135,7 +1135,7 @@
> };
>
> gpu: mali@ffa30000 {
This should also be gpu@..., not mali.
> - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
> reg = <0xffa30000 0x10000>;
> interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.11.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard compatible from rk3288
@ 2017-07-11 3:00 ` Rob Herring
0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2017-07-11 3:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 02:12:27PM +0200, Heiko Stuebner wrote:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index cb1d415d1201..e99d7ff4c939 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1135,7 +1135,7 @@
> };
>
> gpu: mali at ffa30000 {
This should also be gpu at ..., not mali.
> - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
> reg = <0xffa30000 0x10000>;
> interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example
2017-07-10 12:12 ` Heiko Stuebner
@ 2017-07-11 3:03 ` Rob Herring
-1 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2017-07-11 3:03 UTC (permalink / raw)
To: Heiko Stuebner
Cc: guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Jul 10, 2017 at 02:12:26PM +0200, Heiko Stuebner wrote:
> The binding rightfully only specifies compatibles for actual implementations
> and not for the whole family. In the example an arm,mali-midgard slipped
> through from downstream devicetrees though. So drop that to not confuse
> people reading (or copying) that example.
>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
I'm assuming this will go thru same route arm,mali-midgard.txt got
added.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example
@ 2017-07-11 3:03 ` Rob Herring
0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2017-07-11 3:03 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 02:12:26PM +0200, Heiko Stuebner wrote:
> The binding rightfully only specifies compatibles for actual implementations
> and not for the whole family. In the example an arm,mali-midgard slipped
> through from downstream devicetrees though. So drop that to not confuse
> people reading (or copying) that example.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
I'm assuming this will go thru same route arm,mali-midgard.txt got
added.
Rob
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
@ 2017-07-11 8:04 ` Caesar Wang
-1 siblings, 0 replies; 16+ messages in thread
From: Caesar Wang @ 2017-07-11 8:04 UTC (permalink / raw)
To: Heiko Stuebner, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Heiko,
在 2017年07月10日 20:12, Heiko Stuebner 写道:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index cb1d415d1201..e99d7ff4c939 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1135,7 +1135,7 @@
> };
>
> gpu: mali@ffa30000 {
> - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
If we remove the "arm,mali-midgard", the mali driver maybe need update
first.
From the lastest MALI driver on ARM supply, the compatible only two
property.
mali_kbase_core_linux.c
4163: { .compatible = "arm,malit6xx" },
4164: { .compatible = "arm,mali-midgard" },
That's odd with the two compatible, the driver should support the more.
-Caesar
> reg = <0xffa30000 0x10000>;
> interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
@ 2017-07-11 8:04 ` Caesar Wang
0 siblings, 0 replies; 16+ messages in thread
From: Caesar Wang @ 2017-07-11 8:04 UTC (permalink / raw)
To: linux-arm-kernel
Heiko,
? 2017?07?10? 20:12, Heiko Stuebner ??:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index cb1d415d1201..e99d7ff4c939 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1135,7 +1135,7 @@
> };
>
> gpu: mali at ffa30000 {
> - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
If we remove the "arm,mali-midgard", the mali driver maybe need update
first.
From the lastest MALI driver on ARM supply, the compatible only two
property.
mali_kbase_core_linux.c
4163: { .compatible = "arm,malit6xx" },
4164: { .compatible = "arm,mali-midgard" },
That's odd with the two compatible, the driver should support the more.
-Caesar
> reg = <0xffa30000 0x10000>;
> interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
2017-07-11 8:04 ` Caesar Wang
@ 2017-07-11 11:47 ` Heiko Stuebner
-1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-11 11:47 UTC (permalink / raw)
To: Caesar Wang
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Caesar,
Am Dienstag, 11. Juli 2017, 16:04:38 CEST schrieb Caesar Wang:
> Heiko,
>
> 在 2017年07月10日 20:12, Heiko Stuebner 写道:
> > The binding specifies the actual implementations only (mali-t760
> > for example) but not the arm,mali-midgard used in some vendor kernels.
> > So drop that compatible property from the rk3288 where it had slipped in.
> >
> > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> > ---
> > arch/arm/boot/dts/rk3288.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index cb1d415d1201..e99d7ff4c939 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -1135,7 +1135,7 @@
> > };
> >
> > gpu: mali@ffa30000 {
> > - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> > + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
>
> If we remove the "arm,mali-midgard", the mali driver maybe need update
> first.
>
> From the lastest MALI driver on ARM supply, the compatible only two
> property.
> mali_kbase_core_linux.c
> 4163: { .compatible = "arm,malit6xx" },
> 4164: { .compatible = "arm,mali-midgard" },
>
> That's odd with the two compatible, the driver should support the more.
Correct, the driver should be updated anyway. In general the official
dt-binding (the one in the linux kernel) should be followed, not the random
out-of-tree one distributed by vendor drivers :-) .
If you look for example at utgard (mali400 for example), the sane binding
used in the kernel, differs a lot from the binding used by the vendor-driver
as well (io-areas, irq-names etc).
In any case, as you use the mali vendor-driver with you vendor-tree,
it should be possible to do both in sync (dt-change from mainline; driver
change to use better compatibles).
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
@ 2017-07-11 11:47 ` Heiko Stuebner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-11 11:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Caesar,
Am Dienstag, 11. Juli 2017, 16:04:38 CEST schrieb Caesar Wang:
> Heiko,
>
> ? 2017?07?10? 20:12, Heiko Stuebner ??:
> > The binding specifies the actual implementations only (mali-t760
> > for example) but not the arm,mali-midgard used in some vendor kernels.
> > So drop that compatible property from the rk3288 where it had slipped in.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > arch/arm/boot/dts/rk3288.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index cb1d415d1201..e99d7ff4c939 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -1135,7 +1135,7 @@
> > };
> >
> > gpu: mali at ffa30000 {
> > - compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard";
> > + compatible = "rockchip,rk3288-mali", "arm,mali-t760";
>
> If we remove the "arm,mali-midgard", the mali driver maybe need update
> first.
>
> From the lastest MALI driver on ARM supply, the compatible only two
> property.
> mali_kbase_core_linux.c
> 4163: { .compatible = "arm,malit6xx" },
> 4164: { .compatible = "arm,mali-midgard" },
>
> That's odd with the two compatible, the driver should support the more.
Correct, the driver should be updated anyway. In general the official
dt-binding (the one in the linux kernel) should be followed, not the random
out-of-tree one distributed by vendor drivers :-) .
If you look for example at utgard (mali400 for example), the sane binding
used in the kernel, differs a lot from the binding used by the vendor-driver
as well (io-areas, irq-names etc).
In any case, as you use the mali vendor-driver with you vendor-tree,
it should be possible to do both in sync (dt-change from mainline; driver
change to use better compatibles).
Heiko
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example
2017-07-10 12:12 ` Heiko Stuebner
@ 2017-07-13 17:11 ` Heiko Stuebner
-1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-13 17:11 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Montag, 10. Juli 2017, 14:12:26 CEST schrieb Heiko Stuebner:
> The binding rightfully only specifies compatibles for actual implementations
> and not for the whole family. In the example an arm,mali-midgard slipped
> through from downstream devicetrees though. So drop that to not confuse
> people reading (or copying) that example.
>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
applied as fix for 4.13 with Robs Ack
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example
@ 2017-07-13 17:11 ` Heiko Stuebner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-13 17:11 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, 10. Juli 2017, 14:12:26 CEST schrieb Heiko Stuebner:
> The binding rightfully only specifies compatibles for actual implementations
> and not for the whole family. In the example an arm,mali-midgard slipped
> through from downstream devicetrees though. So drop that to not confuse
> people reading (or copying) that example.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
applied as fix for 4.13 with Robs Ack
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard compatible from rk3288
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
@ 2017-07-13 17:13 ` Heiko Stuebner
-1 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-13 17:13 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Cc: guillaume.tucker-ZGY8ohtN/8qB+jHODAdFcQ,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Montag, 10. Juli 2017, 14:12:27 CEST schrieb Heiko Stuebner:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
applied as fix for 4.13 after also fixing the node name to gpu@...
as spotted by Rob.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard compatible from rk3288
@ 2017-07-13 17:13 ` Heiko Stuebner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2017-07-13 17:13 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, 10. Juli 2017, 14:12:27 CEST schrieb Heiko Stuebner:
> The binding specifies the actual implementations only (mali-t760
> for example) but not the arm,mali-midgard used in some vendor kernels.
> So drop that compatible property from the rk3288 where it had slipped in.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
applied as fix for 4.13 after also fixing the node name to gpu at ...
as spotted by Rob.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-07-13 17:13 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 12:12 [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example Heiko Stuebner
2017-07-10 12:12 ` Heiko Stuebner
[not found] ` <20170710121227.14264-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard compatible from rk3288 Heiko Stuebner
2017-07-10 12:12 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
[not found] ` <20170710121227.14264-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-07-11 3:00 ` [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard " Rob Herring
2017-07-11 3:00 ` Rob Herring
2017-07-11 8:04 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Caesar Wang
2017-07-11 8:04 ` Caesar Wang
[not found] ` <972bed58-76c2-04e3-f2ab-d5b8065a92dd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-11 11:47 ` Heiko Stuebner
2017-07-11 11:47 ` Heiko Stuebner
2017-07-13 17:13 ` [PATCH 2/2] ARM: dts: rockchip: remove arm,mali-midgard " Heiko Stuebner
2017-07-13 17:13 ` [PATCH 2/2] ARM: dts: rockchip: remove arm, mali-midgard " Heiko Stuebner
2017-07-11 3:03 ` [PATCH 1/2] dt-bindings: gpu: drop wrong compatible from midgard binding example Rob Herring
2017-07-11 3:03 ` Rob Herring
2017-07-13 17:11 ` Heiko Stuebner
2017-07-13 17:11 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.