* [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
Hi Arnd, Kevin, Magnus, Olof, Simon,
This patch series updates shmobile_defconfig and multi_v7_defconfig to
(re-)enable some features:
- Re-enable R-Car PCIe (shmobile_defconfig),
- Re-enable R-Car XHCI (shmobile_defconfig),
- Re-enable R-Car sound (both),
- Update DRM bridge (both),
- Enable serial port DMA (both).
There also a patch included to refresh shmobile_defconfig.
To avoid conflicts, I didn't refresh multi_v7_defconfig (although it could
definitely use a refresh), and only made "simple" changes to it.
Thanks!
Geert Uytterhoeven (9):
ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency
ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM
ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by
SND_SIMPLE_SCU_CARD
ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge
options
ARM: shmobile: defconfig: Enable DMA for serial ports
ARM: shmobile: defconfig: Refresh
ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by
SND_SIMPLE_SCU_CARD
ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge
options
ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
arch/arm/configs/multi_v7_defconfig | 5 +++--
arch/arm/configs/shmobile_defconfig | 16 +++++++++-------
2 files changed, 12 insertions(+), 9 deletions(-)
--
2.7.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd, Kevin, Magnus, Olof, Simon,
This patch series updates shmobile_defconfig and multi_v7_defconfig to
(re-)enable some features:
- Re-enable R-Car PCIe (shmobile_defconfig),
- Re-enable R-Car XHCI (shmobile_defconfig),
- Re-enable R-Car sound (both),
- Update DRM bridge (both),
- Enable serial port DMA (both).
There also a patch included to refresh shmobile_defconfig.
To avoid conflicts, I didn't refresh multi_v7_defconfig (although it could
definitely use a refresh), and only made "simple" changes to it.
Thanks!
Geert Uytterhoeven (9):
ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency
ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM
ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by
SND_SIMPLE_SCU_CARD
ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge
options
ARM: shmobile: defconfig: Enable DMA for serial ports
ARM: shmobile: defconfig: Refresh
ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by
SND_SIMPLE_SCU_CARD
ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge
options
ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
arch/arm/configs/multi_v7_defconfig | 5 +++--
arch/arm/configs/shmobile_defconfig | 16 +++++++++-------
2 files changed, 12 insertions(+), 9 deletions(-)
--
2.7.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 1/9] ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
PCIE_RCAR is no longer enabled, as it now has a dependency on
PCI_MSI_IRQ_DOMAIN instead of selecting PCI_MSI and PCI_MSI_IRQ_DOMAIN.
Fix this by explicitly enabling PCIE_RCAR in shmobile_defconfig.
Fixes: 3ee803641e76bea7 ("PCI/MSI: irqchip: Fix PCI_MSI dependencies")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a422fb4df567..04cd18424016eba5 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -27,6 +27,7 @@ CONFIG_ARCH_SH73A0=y
CONFIG_PL310_ERRATA_588369=y
CONFIG_ARM_ERRATA_754322=y
CONFIG_PCI=y
+CONFIG_PCI_MSI=y
CONFIG_PCI_RCAR_GEN2=y
CONFIG_PCIE_RCAR=y
CONFIG_SMP=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 1/9] ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
PCIE_RCAR is no longer enabled, as it now has a dependency on
PCI_MSI_IRQ_DOMAIN instead of selecting PCI_MSI and PCI_MSI_IRQ_DOMAIN.
Fix this by explicitly enabling PCIE_RCAR in shmobile_defconfig.
Fixes: 3ee803641e76bea7 ("PCI/MSI: irqchip: Fix PCI_MSI dependencies")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3c66a422fb4df567..04cd18424016eba5 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -27,6 +27,7 @@ CONFIG_ARCH_SH73A0=y
CONFIG_PL310_ERRATA_588369=y
CONFIG_ARM_ERRATA_754322=y
CONFIG_PCI=y
+CONFIG_PCI_MSI=y
CONFIG_PCI_RCAR_GEN2=y
CONFIG_PCIE_RCAR=y
CONFIG_SMP=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 2/9] ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
USB_XHCI_RCAR is no longer enabled, as it now has a dependency on
USB_XHCI_PLATFORM, instead of selecting USB_XHCI_PLATFORM.
As the latter selects the former if ARCH_RENESAS, fix this by replacing
USB_XHCI_RCAR by USB_XHCI_PLATFORM in shmobile_defconfig.
Fixes: f879fc32aa0c96fb ("usb: host: xhci-rcar: Avoid long wait in xhci_reset()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 04cd18424016eba5..bfbeae3f6a884987 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -175,7 +175,7 @@ CONFIG_SND_SOC_AK4642=y
CONFIG_SND_SOC_WM8978=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
-CONFIG_USB_XHCI_RCAR=y
+CONFIG_USB_XHCI_PLATFORM=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_OHCI_HCD=y
CONFIG_USB_R8A66597_HCD=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 2/9] ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
USB_XHCI_RCAR is no longer enabled, as it now has a dependency on
USB_XHCI_PLATFORM, instead of selecting USB_XHCI_PLATFORM.
As the latter selects the former if ARCH_RENESAS, fix this by replacing
USB_XHCI_RCAR by USB_XHCI_PLATFORM in shmobile_defconfig.
Fixes: f879fc32aa0c96fb ("usb: host: xhci-rcar: Avoid long wait in xhci_reset()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 04cd18424016eba5..bfbeae3f6a884987 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -175,7 +175,7 @@ CONFIG_SND_SOC_AK4642=y
CONFIG_SND_SOC_WM8978=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
-CONFIG_USB_XHCI_RCAR=y
+CONFIG_USB_XHCI_PLATFORM=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_OHCI_HCD=y
CONFIG_USB_R8A66597_HCD=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 3/9] ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
SND_SOC_RSRC_CARD was renamed SND_SIMPLE_SCU_CARD, hence update
shmobile_defconfig.
Fixes: d12c6216c4a58f9f ("ASoC: rsrc-card: rename rsrc-card to simple-scu-card phase3")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index bfbeae3f6a884987..ab9a45938c3cd34f 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -170,9 +170,9 @@ CONFIG_SND=y
CONFIG_SND_SOC=y
CONFIG_SND_SOC_SH4_FSI=y
CONFIG_SND_SOC_RCAR=y
-CONFIG_SND_SOC_RSRC_CARD=y
CONFIG_SND_SOC_AK4642=y
CONFIG_SND_SOC_WM8978=y
+CONFIG_SND_SIMPLE_SCU_CARD=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_XHCI_PLATFORM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 3/9] ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
SND_SOC_RSRC_CARD was renamed SND_SIMPLE_SCU_CARD, hence update
shmobile_defconfig.
Fixes: d12c6216c4a58f9f ("ASoC: rsrc-card: rename rsrc-card to simple-scu-card phase3")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index bfbeae3f6a884987..ab9a45938c3cd34f 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -170,9 +170,9 @@ CONFIG_SND=y
CONFIG_SND_SOC=y
CONFIG_SND_SOC_SH4_FSI=y
CONFIG_SND_SOC_RCAR=y
-CONFIG_SND_SOC_RSRC_CARD=y
CONFIG_SND_SOC_AK4642=y
CONFIG_SND_SOC_WM8978=y
+CONFIG_SND_SIMPLE_SCU_CARD=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_XHCI_PLATFORM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 4/9] ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge options
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
The manual bridge implementation was removed in favor of the generic
one, so now we need to enable standard bridge drivers like
DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
DRM_I2C_ADV7511 was already enabled, but the (newer) audio part wasn't.
Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation with DRM bridge")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index ab9a45938c3cd34f..b8d2dcbc9cc745b6 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -154,10 +154,11 @@ CONFIG_VIDEO_ADV7180=y
CONFIG_VIDEO_ADV7604=y
CONFIG_VIDEO_ML86V7667=y
CONFIG_DRM=y
-CONFIG_DRM_I2C_ADV7511=y
CONFIG_DRM_RCAR_DU=y
-CONFIG_DRM_RCAR_HDMI=y
CONFIG_DRM_RCAR_LVDS=y
+CONFIG_DRM_DUMB_VGA_DAC=y
+CONFIG_DRM_I2C_ADV7511=y
+CONFIG_DRM_I2C_ADV7511_AUDIO=y
CONFIG_FB_SH_MOBILE_LCDC=y
CONFIG_FB_SH_MOBILE_MERAM=y
# CONFIG_LCD_CLASS_DEVICE is not set
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 4/9] ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge options
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
The manual bridge implementation was removed in favor of the generic
one, so now we need to enable standard bridge drivers like
DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
DRM_I2C_ADV7511 was already enabled, but the (newer) audio part wasn't.
Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation with DRM bridge")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index ab9a45938c3cd34f..b8d2dcbc9cc745b6 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -154,10 +154,11 @@ CONFIG_VIDEO_ADV7180=y
CONFIG_VIDEO_ADV7604=y
CONFIG_VIDEO_ML86V7667=y
CONFIG_DRM=y
-CONFIG_DRM_I2C_ADV7511=y
CONFIG_DRM_RCAR_DU=y
-CONFIG_DRM_RCAR_HDMI=y
CONFIG_DRM_RCAR_LVDS=y
+CONFIG_DRM_DUMB_VGA_DAC=y
+CONFIG_DRM_I2C_ADV7511=y
+CONFIG_DRM_I2C_ADV7511_AUDIO=y
CONFIG_FB_SH_MOBILE_LCDC=y
CONFIG_FB_SH_MOBILE_MERAM=y
# CONFIG_LCD_CLASS_DEVICE is not set
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 5/9] ARM: shmobile: defconfig: Enable DMA for serial ports
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
DMA for (H)SCIF(A|B) serial ports on R-Car Gen2 and RZ/G1 SoCs is
considered stable, hence enable it by default.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index b8d2dcbc9cc745b6..dd9d1f9ede6e7f34 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -106,6 +106,7 @@ CONFIG_SERIAL_8250_EM=y
CONFIG_SERIAL_SH_SCI=y
CONFIG_SERIAL_SH_SCI_NR_UARTS=20
CONFIG_SERIAL_SH_SCI_CONSOLE=y
+CONFIG_SERIAL_SH_SCI_DMA=y
CONFIG_I2C_CHARDEV=y
CONFIG_I2C_MUX=y
CONFIG_I2C_DEMUX_PINCTRL=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 5/9] ARM: shmobile: defconfig: Enable DMA for serial ports
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
DMA for (H)SCIF(A|B) serial ports on R-Car Gen2 and RZ/G1 SoCs is
considered stable, hence enable it by default.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index b8d2dcbc9cc745b6..dd9d1f9ede6e7f34 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -106,6 +106,7 @@ CONFIG_SERIAL_8250_EM=y
CONFIG_SERIAL_SH_SCI=y
CONFIG_SERIAL_SH_SCI_NR_UARTS=20
CONFIG_SERIAL_SH_SCI_CONSOLE=y
+CONFIG_SERIAL_SH_SCI_DMA=y
CONFIG_I2C_CHARDEV=y
CONFIG_I2C_MUX=y
CONFIG_I2C_DEMUX_PINCTRL=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 6/9] ARM: shmobile: defconfig: Refresh
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
- Several options were moved,
- INPUT_MOUSEDEV_PSAUX is no longer enabled by default since commit
73d8ef76006b649f ("Input: mousedev - stop offering PS/2 to userspace
by default").
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index dd9d1f9ede6e7f34..1cad253c030f4b25 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -89,9 +89,8 @@ CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
# CONFIG_NET_VENDOR_VIA is not set
# CONFIG_NET_VENDOR_WIZNET is not set
-CONFIG_SMSC_PHY=y
CONFIG_MICREL_PHY=y
-# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
+CONFIG_SMSC_PHY=y
CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_GPIO=y
# CONFIG_INPUT_MOUSE is not set
@@ -123,9 +122,9 @@ CONFIG_SPI_SH_HSPI=y
CONFIG_GPIO_EM=y
CONFIG_GPIO_RCAR=y
CONFIG_GPIO_PCF857X=y
-CONFIG_POWER_SUPPLY=y
CONFIG_POWER_RESET=y
CONFIG_POWER_RESET_RMOBILE=y
+CONFIG_POWER_SUPPLY=y
# CONFIG_HWMON is not set
CONFIG_THERMAL=y
CONFIG_CPU_THERMAL=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 6/9] ARM: shmobile: defconfig: Refresh
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
- Several options were moved,
- INPUT_MOUSEDEV_PSAUX is no longer enabled by default since commit
73d8ef76006b649f ("Input: mousedev - stop offering PS/2 to userspace
by default").
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/shmobile_defconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index dd9d1f9ede6e7f34..1cad253c030f4b25 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -89,9 +89,8 @@ CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
# CONFIG_NET_VENDOR_VIA is not set
# CONFIG_NET_VENDOR_WIZNET is not set
-CONFIG_SMSC_PHY=y
CONFIG_MICREL_PHY=y
-# CONFIG_INPUT_MOUSEDEV_PSAUX is not set
+CONFIG_SMSC_PHY=y
CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_GPIO=y
# CONFIG_INPUT_MOUSE is not set
@@ -123,9 +122,9 @@ CONFIG_SPI_SH_HSPI=y
CONFIG_GPIO_EM=y
CONFIG_GPIO_RCAR=y
CONFIG_GPIO_PCF857X=y
-CONFIG_POWER_SUPPLY=y
CONFIG_POWER_RESET=y
CONFIG_POWER_RESET_RMOBILE=y
+CONFIG_POWER_SUPPLY=y
# CONFIG_HWMON is not set
CONFIG_THERMAL=y
CONFIG_CPU_THERMAL=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 7/9] ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
SND_SOC_RSRC_CARD was renamed SND_SIMPLE_SCU_CARD, hence update
multi_v7_defconfig.
Fixes: d12c6216c4a58f9f ("ASoC: rsrc-card: rename rsrc-card to simple-scu-card phase3")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
multi_v7_defconfig is in desperate need of a refresh.
Again, I just replaced the symbols, and ignored any other churn.
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4d19c1b4b8e7c1e8..7fa1746970ecc531 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -650,7 +650,7 @@ CONFIG_SND_SOC_SMDK_WM8994_PCM=m
CONFIG_SND_SOC_SNOW=m
CONFIG_SND_SOC_SH4_FSI=m
CONFIG_SND_SOC_RCAR=m
-CONFIG_SND_SOC_RSRC_CARD=m
+CONFIG_SND_SIMPLE_SCU_CARD=m
CONFIG_SND_SUN4I_CODEC=m
CONFIG_SND_SOC_TEGRA=m
CONFIG_SND_SOC_TEGRA_RT5640=m
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 7/9] ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
SND_SOC_RSRC_CARD was renamed SND_SIMPLE_SCU_CARD, hence update
multi_v7_defconfig.
Fixes: d12c6216c4a58f9f ("ASoC: rsrc-card: rename rsrc-card to simple-scu-card phase3")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
multi_v7_defconfig is in desperate need of a refresh.
Again, I just replaced the symbols, and ignored any other churn.
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4d19c1b4b8e7c1e8..7fa1746970ecc531 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -650,7 +650,7 @@ CONFIG_SND_SOC_SMDK_WM8994_PCM=m
CONFIG_SND_SOC_SNOW=m
CONFIG_SND_SOC_SH4_FSI=m
CONFIG_SND_SOC_RCAR=m
-CONFIG_SND_SOC_RSRC_CARD=m
+CONFIG_SND_SIMPLE_SCU_CARD=m
CONFIG_SND_SUN4I_CODEC=m
CONFIG_SND_SOC_TEGRA=m
CONFIG_SND_SOC_TEGRA_RT5640=m
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
The manual bridge implementation was removed in favor of the generic
one, so now we need to enable standard bridge drivers like
DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
Both were already enabled, but the (newer) ADV7511 audio part wasn't.
Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation with DRM bridge")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
multi_v7_defconfig is in desperate need of a refresh.
To reduce conflicts, I went for the simple option of adding
CONFIG_DRM_I2C_ADV7511_AUDIO below CONFIG_DRM_I2C_ADV7511, instead of
moving CONFIG_DRM_I2C_ADV7511 and CONFIG_DRM_DUMB_VGA_DAC around.
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7fa1746970ecc531..ea2075d8e185f7aa 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -584,6 +584,7 @@ CONFIG_VIDEO_ADV7180=m
CONFIG_VIDEO_ML86V7667=m
CONFIG_DRM=y
CONFIG_DRM_I2C_ADV7511=m
+CONFIG_DRM_I2C_ADV7511_AUDIO=y
# CONFIG_DRM_I2C_CH7006 is not set
# CONFIG_DRM_I2C_SIL164 is not set
CONFIG_DRM_DUMB_VGA_DAC=m
@@ -603,7 +604,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
CONFIG_ROCKCHIP_INNO_HDMI=y
CONFIG_DRM_ATMEL_HLCDC=m
CONFIG_DRM_RCAR_DU=m
-CONFIG_DRM_RCAR_HDMI=y
CONFIG_DRM_RCAR_LVDS=y
CONFIG_DRM_SUN4I=m
CONFIG_DRM_TEGRA=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
The manual bridge implementation was removed in favor of the generic
one, so now we need to enable standard bridge drivers like
DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
Both were already enabled, but the (newer) ADV7511 audio part wasn't.
Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation with DRM bridge")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
multi_v7_defconfig is in desperate need of a refresh.
To reduce conflicts, I went for the simple option of adding
CONFIG_DRM_I2C_ADV7511_AUDIO below CONFIG_DRM_I2C_ADV7511, instead of
moving CONFIG_DRM_I2C_ADV7511 and CONFIG_DRM_DUMB_VGA_DAC around.
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7fa1746970ecc531..ea2075d8e185f7aa 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -584,6 +584,7 @@ CONFIG_VIDEO_ADV7180=m
CONFIG_VIDEO_ML86V7667=m
CONFIG_DRM=y
CONFIG_DRM_I2C_ADV7511=m
+CONFIG_DRM_I2C_ADV7511_AUDIO=y
# CONFIG_DRM_I2C_CH7006 is not set
# CONFIG_DRM_I2C_SIL164 is not set
CONFIG_DRM_DUMB_VGA_DAC=m
@@ -603,7 +604,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
CONFIG_ROCKCHIP_INNO_HDMI=y
CONFIG_DRM_ATMEL_HLCDC=m
CONFIG_DRM_RCAR_DU=m
-CONFIG_DRM_RCAR_HDMI=y
CONFIG_DRM_RCAR_LVDS=y
CONFIG_DRM_SUN4I=m
CONFIG_DRM_TEGRA=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:28 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson, Simon Horman
Cc: Laurent Pinchart, linux-arm-kernel, linux-renesas-soc,
Geert Uytterhoeven
DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
is considered stable, hence enable it by default.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index ea2075d8e185f7aa..072a455008df9751 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
CONFIG_SERIAL_SH_SCI=y
CONFIG_SERIAL_SH_SCI_NR_UARTS=20
CONFIG_SERIAL_SH_SCI_CONSOLE=y
+CONFIG_SERIAL_SH_SCI_DMA=y
CONFIG_SERIAL_MSM=y
CONFIG_SERIAL_MSM_CONSOLE=y
CONFIG_SERIAL_VT8500=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-10 13:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 13:28 UTC (permalink / raw)
To: linux-arm-kernel
DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
is considered stable, hence enable it by default.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index ea2075d8e185f7aa..072a455008df9751 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
CONFIG_SERIAL_SH_SCI=y
CONFIG_SERIAL_SH_SCI_NR_UARTS=20
CONFIG_SERIAL_SH_SCI_CONSOLE=y
+CONFIG_SERIAL_SH_SCI_DMA=y
CONFIG_SERIAL_MSM=y
CONFIG_SERIAL_MSM_CONSOLE=y
CONFIG_SERIAL_VT8500=y
--
2.7.4
^ permalink raw reply related [flat|nested] 52+ messages in thread
* Re: [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-10 13:41 ` Laurent Pinchart
-1 siblings, 0 replies; 52+ messages in thread
From: Laurent Pinchart @ 2017-07-10 13:41 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson,
Simon Horman, linux-arm-kernel, linux-renesas-soc
Hi Geert,
Thank you for the patch.
On Monday 10 Jul 2017 15:28:21 Geert Uytterhoeven wrote:
> The manual bridge implementation was removed in favor of the generic
> one, so now we need to enable standard bridge drivers like
> DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
> Both were already enabled, but the (newer) ADV7511 audio part wasn't.
>
> Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation
> with DRM bridge")
I wonder if this patch really needs a Fixes tag. All it does is removing a now
deleted kernel option, and adding a new unrelated one. The former is related
to 5c602531feb3db39, but I'm not sure it should be considered as a bug.
The content of this patch looks good to me though.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> multi_v7_defconfig is in desperate need of a refresh.
>
> To reduce conflicts, I went for the simple option of adding
> CONFIG_DRM_I2C_ADV7511_AUDIO below CONFIG_DRM_I2C_ADV7511, instead of
> moving CONFIG_DRM_I2C_ADV7511 and CONFIG_DRM_DUMB_VGA_DAC around.
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index
> 7fa1746970ecc531..ea2075d8e185f7aa 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -584,6 +584,7 @@ CONFIG_VIDEO_ADV7180=m
> CONFIG_VIDEO_ML86V7667=m
> CONFIG_DRM=y
> CONFIG_DRM_I2C_ADV7511=m
> +CONFIG_DRM_I2C_ADV7511_AUDIO=y
> # CONFIG_DRM_I2C_CH7006 is not set
> # CONFIG_DRM_I2C_SIL164 is not set
> CONFIG_DRM_DUMB_VGA_DAC=m
> @@ -603,7 +604,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
> CONFIG_ROCKCHIP_INNO_HDMI=y
> CONFIG_DRM_ATMEL_HLCDC=m
> CONFIG_DRM_RCAR_DU=m
> -CONFIG_DRM_RCAR_HDMI=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_SUN4I=m
> CONFIG_DRM_TEGRA=y
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
@ 2017-07-10 13:41 ` Laurent Pinchart
0 siblings, 0 replies; 52+ messages in thread
From: Laurent Pinchart @ 2017-07-10 13:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
Thank you for the patch.
On Monday 10 Jul 2017 15:28:21 Geert Uytterhoeven wrote:
> The manual bridge implementation was removed in favor of the generic
> one, so now we need to enable standard bridge drivers like
> DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
> Both were already enabled, but the (newer) ADV7511 audio part wasn't.
>
> Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation
> with DRM bridge")
I wonder if this patch really needs a Fixes tag. All it does is removing a now
deleted kernel option, and adding a new unrelated one. The former is related
to 5c602531feb3db39, but I'm not sure it should be considered as a bug.
The content of this patch looks good to me though.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> multi_v7_defconfig is in desperate need of a refresh.
>
> To reduce conflicts, I went for the simple option of adding
> CONFIG_DRM_I2C_ADV7511_AUDIO below CONFIG_DRM_I2C_ADV7511, instead of
> moving CONFIG_DRM_I2C_ADV7511 and CONFIG_DRM_DUMB_VGA_DAC around.
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index
> 7fa1746970ecc531..ea2075d8e185f7aa 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -584,6 +584,7 @@ CONFIG_VIDEO_ADV7180=m
> CONFIG_VIDEO_ML86V7667=m
> CONFIG_DRM=y
> CONFIG_DRM_I2C_ADV7511=m
> +CONFIG_DRM_I2C_ADV7511_AUDIO=y
> # CONFIG_DRM_I2C_CH7006 is not set
> # CONFIG_DRM_I2C_SIL164 is not set
> CONFIG_DRM_DUMB_VGA_DAC=m
> @@ -603,7 +604,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
> CONFIG_ROCKCHIP_INNO_HDMI=y
> CONFIG_DRM_ATMEL_HLCDC=m
> CONFIG_DRM_RCAR_DU=m
> -CONFIG_DRM_RCAR_HDMI=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_SUN4I=m
> CONFIG_DRM_TEGRA=y
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
2017-07-10 13:41 ` Laurent Pinchart
@ 2017-07-10 14:05 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 14:05 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Geert Uytterhoeven, Arnd Bergmann, Kevin Hilman, Magnus Damm,
Olof Johansson, Simon Horman, linux-arm-kernel, Linux-Renesas
Hi Laurent,
On Mon, Jul 10, 2017 at 3:41 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 10 Jul 2017 15:28:21 Geert Uytterhoeven wrote:
>> The manual bridge implementation was removed in favor of the generic
>> one, so now we need to enable standard bridge drivers like
>> DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
>> Both were already enabled, but the (newer) ADV7511 audio part wasn't.
>>
>> Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation
>> with DRM bridge")
>
> I wonder if this patch really needs a Fixes tag. All it does is removing a now
> deleted kernel option, and adding a new unrelated one. The former is related
> to 5c602531feb3db39, but I'm not sure it should be considered as a bug.
I added a Fixes tag because it aids backporting: if 5c602531feb3db39
is backported, the defconfig update should be backported, too.
> The content of this patch looks good to me though.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
@ 2017-07-10 14:05 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 14:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Laurent,
On Mon, Jul 10, 2017 at 3:41 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 10 Jul 2017 15:28:21 Geert Uytterhoeven wrote:
>> The manual bridge implementation was removed in favor of the generic
>> one, so now we need to enable standard bridge drivers like
>> DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
>> Both were already enabled, but the (newer) ADV7511 audio part wasn't.
>>
>> Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation
>> with DRM bridge")
>
> I wonder if this patch really needs a Fixes tag. All it does is removing a now
> deleted kernel option, and adding a new unrelated one. The former is related
> to 5c602531feb3db39, but I'm not sure it should be considered as a bug.
I added a Fixes tag because it aids backporting: if 5c602531feb3db39
is backported, the defconfig update should be backported, too.
> The content of this patch looks good to me though.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-11 3:38 ` Magnus Damm
-1 siblings, 0 replies; 52+ messages in thread
From: Magnus Damm @ 2017-07-11 3:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arnd Bergmann, Kevin Hilman, Olof Johansson, Simon Horman,
Laurent Pinchart, linux-arm-kernel, Linux-Renesas
Hi Geert,
On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
> is considered stable, hence enable it by default.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index ea2075d8e185f7aa..072a455008df9751 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
> CONFIG_SERIAL_SH_SCI=y
> CONFIG_SERIAL_SH_SCI_NR_UARTS=20
> CONFIG_SERIAL_SH_SCI_CONSOLE=y
> +CONFIG_SERIAL_SH_SCI_DMA=y
> CONFIG_SERIAL_MSM=y
> CONFIG_SERIAL_MSM_CONSOLE=y
> CONFIG_SERIAL_VT8500=y
Thanks, FWIW I'm very happy to see DMA enabled for the SCIF driver in mainline.
Since enabling DMA Engine still keeps PIO support around I wonder why
we need this Kconfig at all - other drivers seem to get by without
this kind of thing?
So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
completely and reducing the number of special per-driver Kconfig
entries.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 3:38 ` Magnus Damm
0 siblings, 0 replies; 52+ messages in thread
From: Magnus Damm @ 2017-07-11 3:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
> is considered stable, hence enable it by default.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index ea2075d8e185f7aa..072a455008df9751 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
> CONFIG_SERIAL_SH_SCI=y
> CONFIG_SERIAL_SH_SCI_NR_UARTS=20
> CONFIG_SERIAL_SH_SCI_CONSOLE=y
> +CONFIG_SERIAL_SH_SCI_DMA=y
> CONFIG_SERIAL_MSM=y
> CONFIG_SERIAL_MSM_CONSOLE=y
> CONFIG_SERIAL_VT8500=y
Thanks, FWIW I'm very happy to see DMA enabled for the SCIF driver in mainline.
Since enabling DMA Engine still keeps PIO support around I wonder why
we need this Kconfig at all - other drivers seem to get by without
this kind of thing?
So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
completely and reducing the number of special per-driver Kconfig
entries.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 3:38 ` Magnus Damm
(?)
@ 2017-07-11 6:59 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 6:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Magnus,
On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
>> is considered stable, hence enable it by default.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> arch/arm/configs/multi_v7_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index ea2075d8e185f7aa..072a455008df9751 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
>> CONFIG_SERIAL_SH_SCI=y
>> CONFIG_SERIAL_SH_SCI_NR_UARTS
>> CONFIG_SERIAL_SH_SCI_CONSOLE=y
>> +CONFIG_SERIAL_SH_SCI_DMA=y
>> CONFIG_SERIAL_MSM=y
>> CONFIG_SERIAL_MSM_CONSOLE=y
>> CONFIG_SERIAL_VT8500=y
>
> Thanks, FWIW I'm very happy to see DMA enabled for the SCIF driver in mainline.
>
> Since enabling DMA Engine still keeps PIO support around I wonder why
> we need this Kconfig at all - other drivers seem to get by without
> this kind of thing?
> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
> completely and reducing the number of special per-driver Kconfig
> entries.
In general, I would agree, and remove the option at the blimp of an eye.
However, this driver is shared with H8/300 and SuperH. While both could use
DMA (but it's not supported by Linux yet), I don't know if they are willing to
live with the increased static and dynamic memory footprint of SH_SCI DMA
support.
Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
ARM) is another question. Note that that wouldn't reduce code maintainability,
as the #ifdefs would be kept, and it would prevent building and testing
with/without DMA on ARM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 6:59 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 6:59 UTC (permalink / raw)
To: Magnus Damm
Cc: Geert Uytterhoeven, Arnd Bergmann, Kevin Hilman, Olof Johansson,
Simon Horman, Laurent Pinchart, linux-arm-kernel, Linux-Renesas,
Yoshinori Sato, Rich Felker, Linux-sh list, uclinux-h8-devel
Hi Magnus,
On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
>> is considered stable, hence enable it by default.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> arch/arm/configs/multi_v7_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index ea2075d8e185f7aa..072a455008df9751 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
>> CONFIG_SERIAL_SH_SCI=y
>> CONFIG_SERIAL_SH_SCI_NR_UARTS=20
>> CONFIG_SERIAL_SH_SCI_CONSOLE=y
>> +CONFIG_SERIAL_SH_SCI_DMA=y
>> CONFIG_SERIAL_MSM=y
>> CONFIG_SERIAL_MSM_CONSOLE=y
>> CONFIG_SERIAL_VT8500=y
>
> Thanks, FWIW I'm very happy to see DMA enabled for the SCIF driver in mainline.
>
> Since enabling DMA Engine still keeps PIO support around I wonder why
> we need this Kconfig at all - other drivers seem to get by without
> this kind of thing?
> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
> completely and reducing the number of special per-driver Kconfig
> entries.
In general, I would agree, and remove the option at the blimp of an eye.
However, this driver is shared with H8/300 and SuperH. While both could use
DMA (but it's not supported by Linux yet), I don't know if they are willing to
live with the increased static and dynamic memory footprint of SH_SCI DMA
support.
Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
ARM) is another question. Note that that wouldn't reduce code maintainability,
as the #ifdefs would be kept, and it would prevent building and testing
with/without DMA on ARM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 6:59 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 6:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Magnus,
On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> DMA for (H)SCIF(A|B) serial ports on Renesas R-Car Gen2 and RZ/G1 SoCs
>> is considered stable, hence enable it by default.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> arch/arm/configs/multi_v7_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index ea2075d8e185f7aa..072a455008df9751 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -330,6 +330,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
>> CONFIG_SERIAL_SH_SCI=y
>> CONFIG_SERIAL_SH_SCI_NR_UARTS=20
>> CONFIG_SERIAL_SH_SCI_CONSOLE=y
>> +CONFIG_SERIAL_SH_SCI_DMA=y
>> CONFIG_SERIAL_MSM=y
>> CONFIG_SERIAL_MSM_CONSOLE=y
>> CONFIG_SERIAL_VT8500=y
>
> Thanks, FWIW I'm very happy to see DMA enabled for the SCIF driver in mainline.
>
> Since enabling DMA Engine still keeps PIO support around I wonder why
> we need this Kconfig at all - other drivers seem to get by without
> this kind of thing?
> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
> completely and reducing the number of special per-driver Kconfig
> entries.
In general, I would agree, and remove the option at the blimp of an eye.
However, this driver is shared with H8/300 and SuperH. While both could use
DMA (but it's not supported by Linux yet), I don't know if they are willing to
live with the increased static and dynamic memory footprint of SH_SCI DMA
support.
Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
ARM) is another question. Note that that wouldn't reduce code maintainability,
as the #ifdefs would be kept, and it would prevent building and testing
with/without DMA on ARM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 6:59 ` Geert Uytterhoeven
(?)
@ 2017-07-11 8:39 ` Arnd Bergmann
-1 siblings, 0 replies; 52+ messages in thread
From: Arnd Bergmann @ 2017-07-11 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
> ARM) is another question. Note that that wouldn't reduce code maintainability,
> as the #ifdefs would be kept, and it would prevent building and testing
> with/without DMA on ARM.
arch/sh/configs/sdk7786_defconfig enables it, too, so it should at least be
a user-selectable option on SuperH if you do that.
Arnd
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:39 ` Arnd Bergmann
0 siblings, 0 replies; 52+ messages in thread
From: Arnd Bergmann @ 2017-07-11 8:39 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Geert Uytterhoeven, Kevin Hilman, Olof Johansson,
Simon Horman, Laurent Pinchart, linux-arm-kernel, Linux-Renesas,
Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
> ARM) is another question. Note that that wouldn't reduce code maintainability,
> as the #ifdefs would be kept, and it would prevent building and testing
> with/without DMA on ARM.
arch/sh/configs/sdk7786_defconfig enables it, too, so it should at least be
a user-selectable option on SuperH if you do that.
Arnd
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:39 ` Arnd Bergmann
0 siblings, 0 replies; 52+ messages in thread
From: Arnd Bergmann @ 2017-07-11 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
> ARM) is another question. Note that that wouldn't reduce code maintainability,
> as the #ifdefs would be kept, and it would prevent building and testing
> with/without DMA on ARM.
arch/sh/configs/sdk7786_defconfig enables it, too, so it should at least be
a user-selectable option on SuperH if you do that.
Arnd
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 6:59 ` Geert Uytterhoeven
(?)
@ 2017-07-11 8:42 ` Arnd Bergmann
-1 siblings, 0 replies; 52+ messages in thread
From: Arnd Bergmann @ 2017-07-11 8:42 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>> Since enabling DMA Engine still keeps PIO support around I wonder why
>> we need this Kconfig at all - other drivers seem to get by without
>> this kind of thing?
>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>> completely and reducing the number of special per-driver Kconfig
>> entries.
>
> In general, I would agree, and remove the option at the blimp of an eye.
> However, this driver is shared with H8/300 and SuperH. While both could use
> DMA (but it's not supported by Linux yet), I don't know if they are willing to
> live with the increased static and dynamic memory footprint of SH_SCI DMA
> support.
One more thing: enabling the DMA support in the console driver generally
means you cannot use printk in the DMA driver anywhere that may be called
during printk(). Not sure if that is a concern here.
Arnd
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:42 ` Arnd Bergmann
0 siblings, 0 replies; 52+ messages in thread
From: Arnd Bergmann @ 2017-07-11 8:42 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Geert Uytterhoeven, Kevin Hilman, Olof Johansson,
Simon Horman, Laurent Pinchart, linux-arm-kernel, Linux-Renesas,
Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>> Since enabling DMA Engine still keeps PIO support around I wonder why
>> we need this Kconfig at all - other drivers seem to get by without
>> this kind of thing?
>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>> completely and reducing the number of special per-driver Kconfig
>> entries.
>
> In general, I would agree, and remove the option at the blimp of an eye.
> However, this driver is shared with H8/300 and SuperH. While both could use
> DMA (but it's not supported by Linux yet), I don't know if they are willing to
> live with the increased static and dynamic memory footprint of SH_SCI DMA
> support.
One more thing: enabling the DMA support in the console driver generally
means you cannot use printk in the DMA driver anywhere that may be called
during printk(). Not sure if that is a concern here.
Arnd
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:42 ` Arnd Bergmann
0 siblings, 0 replies; 52+ messages in thread
From: Arnd Bergmann @ 2017-07-11 8:42 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>> Since enabling DMA Engine still keeps PIO support around I wonder why
>> we need this Kconfig at all - other drivers seem to get by without
>> this kind of thing?
>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>> completely and reducing the number of special per-driver Kconfig
>> entries.
>
> In general, I would agree, and remove the option at the blimp of an eye.
> However, this driver is shared with H8/300 and SuperH. While both could use
> DMA (but it's not supported by Linux yet), I don't know if they are willing to
> live with the increased static and dynamic memory footprint of SH_SCI DMA
> support.
One more thing: enabling the DMA support in the console driver generally
means you cannot use printk in the DMA driver anywhere that may be called
during printk(). Not sure if that is a concern here.
Arnd
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 8:39 ` Arnd Bergmann
(?)
@ 2017-07-11 8:57 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 8:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Tue, Jul 11, 2017 at 10:39 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
>> ARM) is another question. Note that that wouldn't reduce code maintainability,
>> as the #ifdefs would be kept, and it would prevent building and testing
>> with/without DMA on ARM.
>
> arch/sh/configs/sdk7786_defconfig enables it, too, so it should at least be
> a user-selectable option on SuperH if you do that.
But that can't enable DMA, as (1) the non-DT DMA configuration was removed
due to (2) being unused.
Cfr. commit 219fb0c1436e4893 ("serial: sh-sci: Remove the platform data dma
slave rx/tx channel IDs").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:57 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 8:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Magnus Damm, Geert Uytterhoeven, Kevin Hilman, Olof Johansson,
Simon Horman, Laurent Pinchart, linux-arm-kernel, Linux-Renesas,
Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
Hi Arnd,
On Tue, Jul 11, 2017 at 10:39 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
>> ARM) is another question. Note that that wouldn't reduce code maintainability,
>> as the #ifdefs would be kept, and it would prevent building and testing
>> with/without DMA on ARM.
>
> arch/sh/configs/sdk7786_defconfig enables it, too, so it should at least be
> a user-selectable option on SuperH if you do that.
But that can't enable DMA, as (1) the non-DT DMA configuration was removed
due to (2) being unused.
Cfr. commit 219fb0c1436e4893 ("serial: sh-sci: Remove the platform data dma
slave rx/tx channel IDs").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:57 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 8:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Tue, Jul 11, 2017 at 10:39 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> Whether we want to hide the option (and default to y if ARCH_RENESAS, i.e.
>> ARM) is another question. Note that that wouldn't reduce code maintainability,
>> as the #ifdefs would be kept, and it would prevent building and testing
>> with/without DMA on ARM.
>
> arch/sh/configs/sdk7786_defconfig enables it, too, so it should at least be
> a user-selectable option on SuperH if you do that.
But that can't enable DMA, as (1) the non-DT DMA configuration was removed
due to (2) being unused.
Cfr. commit 219fb0c1436e4893 ("serial: sh-sci: Remove the platform data dma
slave rx/tx channel IDs").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 8:42 ` Arnd Bergmann
(?)
@ 2017-07-11 8:59 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 8:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>> we need this Kconfig at all - other drivers seem to get by without
>>> this kind of thing?
>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>> completely and reducing the number of special per-driver Kconfig
>>> entries.
>>
>> In general, I would agree, and remove the option at the blimp of an eye.
>> However, this driver is shared with H8/300 and SuperH. While both could use
>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>> support.
>
> One more thing: enabling the DMA support in the console driver generally
> means you cannot use printk in the DMA driver anywhere that may be called
> during printk(). Not sure if that is a concern here.
Not anymore, as all of these prints should have been removed/disabled already.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:59 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 8:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Magnus Damm, Geert Uytterhoeven, Kevin Hilman, Olof Johansson,
Simon Horman, Laurent Pinchart, linux-arm-kernel, Linux-Renesas,
Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
Hi Arnd,
On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>> we need this Kconfig at all - other drivers seem to get by without
>>> this kind of thing?
>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>> completely and reducing the number of special per-driver Kconfig
>>> entries.
>>
>> In general, I would agree, and remove the option at the blimp of an eye.
>> However, this driver is shared with H8/300 and SuperH. While both could use
>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>> support.
>
> One more thing: enabling the DMA support in the console driver generally
> means you cannot use printk in the DMA driver anywhere that may be called
> during printk(). Not sure if that is a concern here.
Not anymore, as all of these prints should have been removed/disabled already.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 8:59 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 8:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>> we need this Kconfig at all - other drivers seem to get by without
>>> this kind of thing?
>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>> completely and reducing the number of special per-driver Kconfig
>>> entries.
>>
>> In general, I would agree, and remove the option at the blimp of an eye.
>> However, this driver is shared with H8/300 and SuperH. While both could use
>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>> support.
>
> One more thing: enabling the DMA support in the console driver generally
> means you cannot use printk in the DMA driver anywhere that may be called
> during printk(). Not sure if that is a concern here.
Not anymore, as all of these prints should have been removed/disabled already.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates
2017-07-10 13:28 ` Geert Uytterhoeven
@ 2017-07-11 9:13 ` Simon Horman
-1 siblings, 0 replies; 52+ messages in thread
From: Simon Horman @ 2017-07-11 9:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arnd Bergmann, Kevin Hilman, Magnus Damm, Olof Johansson,
Laurent Pinchart, linux-arm-kernel, linux-renesas-soc
On Mon, Jul 10, 2017 at 03:28:13PM +0200, Geert Uytterhoeven wrote:
> Hi Arnd, Kevin, Magnus, Olof, Simon,
>
> This patch series updates shmobile_defconfig and multi_v7_defconfig to
> (re-)enable some features:
> - Re-enable R-Car PCIe (shmobile_defconfig),
> - Re-enable R-Car XHCI (shmobile_defconfig),
> - Re-enable R-Car sound (both),
> - Update DRM bridge (both),
> - Enable serial port DMA (both).
>
> There also a patch included to refresh shmobile_defconfig.
> To avoid conflicts, I didn't refresh multi_v7_defconfig (although it could
> definitely use a refresh), and only made "simple" changes to it.
Thanks, all applied.
Personally I would be in favour of co-ordinating a refresh of
multi_v7_defconfig.
>
> Thanks!
>
> Geert Uytterhoeven (9):
> ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency
> ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM
> ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by
> SND_SIMPLE_SCU_CARD
> ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge
> options
> ARM: shmobile: defconfig: Enable DMA for serial ports
> ARM: shmobile: defconfig: Refresh
> ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by
> SND_SIMPLE_SCU_CARD
> ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge
> options
> ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
>
> arch/arm/configs/multi_v7_defconfig | 5 +++--
> arch/arm/configs/shmobile_defconfig | 16 +++++++++-------
> 2 files changed, 12 insertions(+), 9 deletions(-)
>
> --
> 2.7.4
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates
@ 2017-07-11 9:13 ` Simon Horman
0 siblings, 0 replies; 52+ messages in thread
From: Simon Horman @ 2017-07-11 9:13 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 03:28:13PM +0200, Geert Uytterhoeven wrote:
> Hi Arnd, Kevin, Magnus, Olof, Simon,
>
> This patch series updates shmobile_defconfig and multi_v7_defconfig to
> (re-)enable some features:
> - Re-enable R-Car PCIe (shmobile_defconfig),
> - Re-enable R-Car XHCI (shmobile_defconfig),
> - Re-enable R-Car sound (both),
> - Update DRM bridge (both),
> - Enable serial port DMA (both).
>
> There also a patch included to refresh shmobile_defconfig.
> To avoid conflicts, I didn't refresh multi_v7_defconfig (although it could
> definitely use a refresh), and only made "simple" changes to it.
Thanks, all applied.
Personally I would be in favour of co-ordinating a refresh of
multi_v7_defconfig.
>
> Thanks!
>
> Geert Uytterhoeven (9):
> ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency
> ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM
> ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by
> SND_SIMPLE_SCU_CARD
> ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge
> options
> ARM: shmobile: defconfig: Enable DMA for serial ports
> ARM: shmobile: defconfig: Refresh
> ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by
> SND_SIMPLE_SCU_CARD
> ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge
> options
> ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
>
> arch/arm/configs/multi_v7_defconfig | 5 +++--
> arch/arm/configs/shmobile_defconfig | 16 +++++++++-------
> 2 files changed, 12 insertions(+), 9 deletions(-)
>
> --
> 2.7.4
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 8:59 ` Geert Uytterhoeven
(?)
@ 2017-07-11 10:37 ` Rob Landley
-1 siblings, 0 replies; 52+ messages in thread
From: Rob Landley @ 2017-07-11 10:37 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>> we need this Kconfig at all - other drivers seem to get by without
>>>> this kind of thing?
>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>> completely and reducing the number of special per-driver Kconfig
>>>> entries.
>>>
>>> In general, I would agree, and remove the option at the blimp of an eye.
>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>> support.
>>
>> One more thing: enabling the DMA support in the console driver generally
>> means you cannot use printk in the DMA driver anywhere that may be called
>> during printk(). Not sure if that is a concern here.
>
> Not anymore, as all of these prints should have been removed/disabled already.
Last I checked qemu-system-sh4 still doesn't work with current linux
serial driver unless you do:
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
(unsigned long)s);
} else {
- if (port->type = PORT_SCIFA ||
+ if (1 || port->type = PORT_SCIFA ||
port->type = PORT_SCIFB)
scif_set_rtrg(port, 1);
else
Does this DMA stuff make that situation worse?
Rob
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 10:37 ` Rob Landley
0 siblings, 0 replies; 52+ messages in thread
From: Rob Landley @ 2017-07-11 10:37 UTC (permalink / raw)
To: Geert Uytterhoeven, Arnd Bergmann
Cc: Magnus Damm, Geert Uytterhoeven, Kevin Hilman, Olof Johansson,
Simon Horman, Laurent Pinchart, linux-arm-kernel, Linux-Renesas,
Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>> we need this Kconfig at all - other drivers seem to get by without
>>>> this kind of thing?
>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>> completely and reducing the number of special per-driver Kconfig
>>>> entries.
>>>
>>> In general, I would agree, and remove the option at the blimp of an eye.
>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>> support.
>>
>> One more thing: enabling the DMA support in the console driver generally
>> means you cannot use printk in the DMA driver anywhere that may be called
>> during printk(). Not sure if that is a concern here.
>
> Not anymore, as all of these prints should have been removed/disabled already.
Last I checked qemu-system-sh4 still doesn't work with current linux
serial driver unless you do:
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
(unsigned long)s);
} else {
- if (port->type == PORT_SCIFA ||
+ if (1 || port->type == PORT_SCIFA ||
port->type == PORT_SCIFB)
scif_set_rtrg(port, 1);
else
Does this DMA stuff make that situation worse?
Rob
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 10:37 ` Rob Landley
0 siblings, 0 replies; 52+ messages in thread
From: Rob Landley @ 2017-07-11 10:37 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>> we need this Kconfig at all - other drivers seem to get by without
>>>> this kind of thing?
>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>> completely and reducing the number of special per-driver Kconfig
>>>> entries.
>>>
>>> In general, I would agree, and remove the option at the blimp of an eye.
>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>> support.
>>
>> One more thing: enabling the DMA support in the console driver generally
>> means you cannot use printk in the DMA driver anywhere that may be called
>> during printk(). Not sure if that is a concern here.
>
> Not anymore, as all of these prints should have been removed/disabled already.
Last I checked qemu-system-sh4 still doesn't work with current linux
serial driver unless you do:
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
(unsigned long)s);
} else {
- if (port->type == PORT_SCIFA ||
+ if (1 || port->type == PORT_SCIFA ||
port->type == PORT_SCIFB)
scif_set_rtrg(port, 1);
else
Does this DMA stuff make that situation worse?
Rob
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 10:37 ` Rob Landley
(?)
@ 2017-07-11 10:46 ` Geert Uytterhoeven
-1 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 10:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rob,
On Tue, Jul 11, 2017 at 12:37 PM, Rob Landley <rob@landley.net> wrote:
> On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
>> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>>> <geert@linux-m68k.org> wrote:
>>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>>> we need this Kconfig at all - other drivers seem to get by without
>>>>> this kind of thing?
>>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>>> completely and reducing the number of special per-driver Kconfig
>>>>> entries.
>>>>
>>>> In general, I would agree, and remove the option at the blimp of an eye.
>>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>>> support.
>>>
>>> One more thing: enabling the DMA support in the console driver generally
>>> means you cannot use printk in the DMA driver anywhere that may be called
>>> during printk(). Not sure if that is a concern here.
>>
>> Not anymore, as all of these prints should have been removed/disabled already.
>
> Last I checked qemu-system-sh4 still doesn't work with current linux
> serial driver unless you do:
>
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
> setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
> (unsigned long)s);
> } else {
> - if (port->type = PORT_SCIFA ||
> + if (1 || port->type = PORT_SCIFA ||
> port->type = PORT_SCIFB)
> scif_set_rtrg(port, 1);
> else
>
> Does this DMA stuff make that situation worse?
No, SH-SCI DMA is not used on your platform.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 10:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 10:46 UTC (permalink / raw)
To: Rob Landley
Cc: Arnd Bergmann, Magnus Damm, Geert Uytterhoeven, Kevin Hilman,
Olof Johansson, Simon Horman, Laurent Pinchart, linux-arm-kernel,
Linux-Renesas, Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
Hi Rob,
On Tue, Jul 11, 2017 at 12:37 PM, Rob Landley <rob@landley.net> wrote:
> On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
>> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>>> <geert@linux-m68k.org> wrote:
>>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>>> we need this Kconfig at all - other drivers seem to get by without
>>>>> this kind of thing?
>>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>>> completely and reducing the number of special per-driver Kconfig
>>>>> entries.
>>>>
>>>> In general, I would agree, and remove the option at the blimp of an eye.
>>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>>> support.
>>>
>>> One more thing: enabling the DMA support in the console driver generally
>>> means you cannot use printk in the DMA driver anywhere that may be called
>>> during printk(). Not sure if that is a concern here.
>>
>> Not anymore, as all of these prints should have been removed/disabled already.
>
> Last I checked qemu-system-sh4 still doesn't work with current linux
> serial driver unless you do:
>
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
> setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
> (unsigned long)s);
> } else {
> - if (port->type == PORT_SCIFA ||
> + if (1 || port->type == PORT_SCIFA ||
> port->type == PORT_SCIFB)
> scif_set_rtrg(port, 1);
> else
>
> Does this DMA stuff make that situation worse?
No, SH-SCI DMA is not used on your platform.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-07-11 10:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2017-07-11 10:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rob,
On Tue, Jul 11, 2017 at 12:37 PM, Rob Landley <rob@landley.net> wrote:
> On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
>> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>>> <geert@linux-m68k.org> wrote:
>>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>>> we need this Kconfig at all - other drivers seem to get by without
>>>>> this kind of thing?
>>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>>> completely and reducing the number of special per-driver Kconfig
>>>>> entries.
>>>>
>>>> In general, I would agree, and remove the option at the blimp of an eye.
>>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>>> support.
>>>
>>> One more thing: enabling the DMA support in the console driver generally
>>> means you cannot use printk in the DMA driver anywhere that may be called
>>> during printk(). Not sure if that is a concern here.
>>
>> Not anymore, as all of these prints should have been removed/disabled already.
>
> Last I checked qemu-system-sh4 still doesn't work with current linux
> serial driver unless you do:
>
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
> setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
> (unsigned long)s);
> } else {
> - if (port->type == PORT_SCIFA ||
> + if (1 || port->type == PORT_SCIFA ||
> port->type == PORT_SCIFB)
> scif_set_rtrg(port, 1);
> else
>
> Does this DMA stuff make that situation worse?
No, SH-SCI DMA is not used on your platform.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
2017-07-11 10:46 ` Geert Uytterhoeven
(?)
@ 2017-11-01 8:58 ` Rob Landley
-1 siblings, 0 replies; 52+ messages in thread
From: Rob Landley @ 2017-11-01 8:58 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2017 05:46 AM, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Jul 11, 2017 at 12:37 PM, Rob Landley <rob@landley.net> wrote:
>> On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
>>> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>>>> <geert@linux-m68k.org> wrote:
>>>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>>>> we need this Kconfig at all - other drivers seem to get by without
>>>>>> this kind of thing?
>>>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>>>> completely and reducing the number of special per-driver Kconfig
>>>>>> entries.
>>>>>
>>>>> In general, I would agree, and remove the option at the blimp of an eye.
>>>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>>>> support.
>>>>
>>>> One more thing: enabling the DMA support in the console driver generally
>>>> means you cannot use printk in the DMA driver anywhere that may be called
>>>> during printk(). Not sure if that is a concern here.
>>>
>>> Not anymore, as all of these prints should have been removed/disabled already.
>>
>> Last I checked qemu-system-sh4 still doesn't work with current linux
>> serial driver unless you do:
>>
>> --- a/drivers/tty/serial/sh-sci.c
>> +++ b/drivers/tty/serial/sh-sci.c
>> @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
>> setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
>> (unsigned long)s);
>> } else {
>> - if (port->type = PORT_SCIFA ||
>> + if (1 || port->type = PORT_SCIFA ||
>> port->type = PORT_SCIFB)
>> scif_set_rtrg(port, 1);
>> else
>>
>> Does this DMA stuff make that situation worse?
>
> No, SH-SCI DMA is not used on your platform.
>
> Gr{oetje,eeting}s,
This issue is still there. QEMU's serial output is borked with the last
year's worth of vanilla superh kernels.
Rob
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-11-01 8:58 ` Rob Landley
0 siblings, 0 replies; 52+ messages in thread
From: Rob Landley @ 2017-11-01 8:58 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Arnd Bergmann, Magnus Damm, Geert Uytterhoeven, Kevin Hilman,
Olof Johansson, Simon Horman, Laurent Pinchart, linux-arm-kernel,
Linux-Renesas, Yoshinori Sato, Rich Felker, Linux-sh list,
moderated list:H8/300 ARCHITECTURE
On 07/11/2017 05:46 AM, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Jul 11, 2017 at 12:37 PM, Rob Landley <rob@landley.net> wrote:
>> On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
>>> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>>>> <geert@linux-m68k.org> wrote:
>>>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>>>> we need this Kconfig at all - other drivers seem to get by without
>>>>>> this kind of thing?
>>>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>>>> completely and reducing the number of special per-driver Kconfig
>>>>>> entries.
>>>>>
>>>>> In general, I would agree, and remove the option at the blimp of an eye.
>>>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>>>> support.
>>>>
>>>> One more thing: enabling the DMA support in the console driver generally
>>>> means you cannot use printk in the DMA driver anywhere that may be called
>>>> during printk(). Not sure if that is a concern here.
>>>
>>> Not anymore, as all of these prints should have been removed/disabled already.
>>
>> Last I checked qemu-system-sh4 still doesn't work with current linux
>> serial driver unless you do:
>>
>> --- a/drivers/tty/serial/sh-sci.c
>> +++ b/drivers/tty/serial/sh-sci.c
>> @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
>> setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
>> (unsigned long)s);
>> } else {
>> - if (port->type == PORT_SCIFA ||
>> + if (1 || port->type == PORT_SCIFA ||
>> port->type == PORT_SCIFB)
>> scif_set_rtrg(port, 1);
>> else
>>
>> Does this DMA stuff make that situation worse?
>
> No, SH-SCI DMA is not used on your platform.
>
> Gr{oetje,eeting}s,
This issue is still there. QEMU's serial output is borked with the last
year's worth of vanilla superh kernels.
Rob
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports
@ 2017-11-01 8:58 ` Rob Landley
0 siblings, 0 replies; 52+ messages in thread
From: Rob Landley @ 2017-11-01 8:58 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/2017 05:46 AM, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Jul 11, 2017 at 12:37 PM, Rob Landley <rob@landley.net> wrote:
>> On 07/11/2017 03:59 AM, Geert Uytterhoeven wrote:
>>> On Tue, Jul 11, 2017 at 10:42 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Tue, Jul 11, 2017 at 8:59 AM, Geert Uytterhoeven
>>>> <geert@linux-m68k.org> wrote:
>>>>> On Tue, Jul 11, 2017 at 5:38 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>>>>>> On Mon, Jul 10, 2017 at 10:28 PM, Geert Uytterhoeven
>>>>>> Since enabling DMA Engine still keeps PIO support around I wonder why
>>>>>> we need this Kconfig at all - other drivers seem to get by without
>>>>>> this kind of thing?
>>>>>> So in my opinion it would also be nice to get rid of SERIAL_SH_SCI_DMA
>>>>>> completely and reducing the number of special per-driver Kconfig
>>>>>> entries.
>>>>>
>>>>> In general, I would agree, and remove the option at the blimp of an eye.
>>>>> However, this driver is shared with H8/300 and SuperH. While both could use
>>>>> DMA (but it's not supported by Linux yet), I don't know if they are willing to
>>>>> live with the increased static and dynamic memory footprint of SH_SCI DMA
>>>>> support.
>>>>
>>>> One more thing: enabling the DMA support in the console driver generally
>>>> means you cannot use printk in the DMA driver anywhere that may be called
>>>> during printk(). Not sure if that is a concern here.
>>>
>>> Not anymore, as all of these prints should have been removed/disabled already.
>>
>> Last I checked qemu-system-sh4 still doesn't work with current linux
>> serial driver unless you do:
>>
>> --- a/drivers/tty/serial/sh-sci.c
>> +++ b/drivers/tty/serial/sh-sci.c
>> @@ -2193,7 +2193,7 @@ static void sci_reset(struct uart_port *port)
>> setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn,
>> (unsigned long)s);
>> } else {
>> - if (port->type == PORT_SCIFA ||
>> + if (1 || port->type == PORT_SCIFA ||
>> port->type == PORT_SCIFB)
>> scif_set_rtrg(port, 1);
>> else
>>
>> Does this DMA stuff make that situation worse?
>
> No, SH-SCI DMA is not used on your platform.
>
> Gr{oetje,eeting}s,
This issue is still there. QEMU's serial output is borked with the last
year's worth of vanilla superh kernels.
Rob
^ permalink raw reply [flat|nested] 52+ messages in thread
end of thread, other threads:[~2017-11-01 8:58 UTC | newest]
Thread overview: 52+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 13:28 [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 1/9] ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 2/9] ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 3/9] ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 4/9] ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge options Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 5/9] ARM: shmobile: defconfig: Enable DMA for serial ports Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 6/9] ARM: shmobile: defconfig: Refresh Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 7/9] ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:41 ` Laurent Pinchart
2017-07-10 13:41 ` Laurent Pinchart
2017-07-10 14:05 ` Geert Uytterhoeven
2017-07-10 14:05 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-11 3:38 ` Magnus Damm
2017-07-11 3:38 ` Magnus Damm
2017-07-11 6:59 ` Geert Uytterhoeven
2017-07-11 6:59 ` Geert Uytterhoeven
2017-07-11 6:59 ` Geert Uytterhoeven
2017-07-11 8:39 ` Arnd Bergmann
2017-07-11 8:39 ` Arnd Bergmann
2017-07-11 8:39 ` Arnd Bergmann
2017-07-11 8:57 ` Geert Uytterhoeven
2017-07-11 8:57 ` Geert Uytterhoeven
2017-07-11 8:57 ` Geert Uytterhoeven
2017-07-11 8:42 ` Arnd Bergmann
2017-07-11 8:42 ` Arnd Bergmann
2017-07-11 8:42 ` Arnd Bergmann
2017-07-11 8:59 ` Geert Uytterhoeven
2017-07-11 8:59 ` Geert Uytterhoeven
2017-07-11 8:59 ` Geert Uytterhoeven
2017-07-11 10:37 ` Rob Landley
2017-07-11 10:37 ` Rob Landley
2017-07-11 10:37 ` Rob Landley
2017-07-11 10:46 ` Geert Uytterhoeven
2017-07-11 10:46 ` Geert Uytterhoeven
2017-07-11 10:46 ` Geert Uytterhoeven
2017-11-01 8:58 ` Rob Landley
2017-11-01 8:58 ` Rob Landley
2017-11-01 8:58 ` Rob Landley
2017-07-11 9:13 ` [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates Simon Horman
2017-07-11 9:13 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.