* [Qemu-devel] [PATCH v2] build: disable Xen on ARM
@ 2017-07-11 10:00 Paolo Bonzini
2017-07-11 12:47 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2017-07-11 10:00 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, sstabellini, anthony.perard
While ARM could present the xenpv machine, it does not and trying to enable
it breaks compilation. Revert to the previous test which only looked at
$target_name, not $cpu.
Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 806658c98b..5096cbcf14 100755
--- a/configure
+++ b/configure
@@ -202,9 +202,9 @@ supported_kvm_target() {
supported_xen_target() {
test "$xen" = "yes" || return 1
glob "$1" "*-softmmu" || return 1
- case "${1%-softmmu}:$cpu" in
- arm:arm | aarch64:aarch64 | \
- i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64)
+ # Only i386 and x86_64 provide the xenpv machine.
+ case "${1%-softmmu}" in
+ i386|x86_64)
return 0
;;
esac
--
2.13.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] build: disable Xen on ARM
2017-07-11 10:00 [Qemu-devel] [PATCH v2] build: disable Xen on ARM Paolo Bonzini
@ 2017-07-11 12:47 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2017-07-11 12:47 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers, Stefano Stabellini, Anthony PERARD
On 11 July 2017 at 11:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
> While ARM could present the xenpv machine, it does not and trying to enable
> it breaks compilation. Revert to the previous test which only looked at
> $target_name, not $cpu.
>
> Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 806658c98b..5096cbcf14 100755
> --- a/configure
> +++ b/configure
> @@ -202,9 +202,9 @@ supported_kvm_target() {
> supported_xen_target() {
> test "$xen" = "yes" || return 1
> glob "$1" "*-softmmu" || return 1
> - case "${1%-softmmu}:$cpu" in
> - arm:arm | aarch64:aarch64 | \
> - i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64)
> + # Only i386 and x86_64 provide the xenpv machine.
> + case "${1%-softmmu}" in
> + i386|x86_64)
> return 0
> ;;
> esac
Thanks, applied to master as a build fix.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-11 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 10:00 [Qemu-devel] [PATCH v2] build: disable Xen on ARM Paolo Bonzini
2017-07-11 12:47 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.